From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CDD7A00C2; Wed, 28 Sep 2022 10:13:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 108164113C; Wed, 28 Sep 2022 10:13:09 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1DA1E40F16 for ; Wed, 28 Sep 2022 10:13:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664352787; x=1695888787; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Io5pQsdePxOjWmzmrCm8M9pZzaP1+ulhtK3MkHMnL7M=; b=fMOAh6FWAJdRUhD4hxObAoALumJHzXEIb2qZ9EuC+xa2hkCw26AdV/TY i9nOiGDIvuvSMvAYCMSnY+TiBUUiJnudg7DGv8BXm7pplJTEvSVAY8kJ2 iu+iW6/E8cN3LxF23gAarcAQciJmmuBb2s2dmYQjGbIvB2ShkiuODjPUq hMeL4rLeOPVGvBHsTMqLBIyzvX1Al8NpZzbLeTRO54NlJO0ZxUJ+DLIbE 8WChpmE5TDZhQUtzobzzCvR/YwQ/3wpYskLF70kDlQqQBOGaDAh4tPz8Y qmbatNwpkUpD1GMfmw/Ep9LtaAKvTatOxsNI/UYTpG2XAdIAchjyj7kQz A==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="363379481" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="363379481" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 01:13:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="572947504" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="572947504" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 28 Sep 2022 01:13:04 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 01:13:02 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 01:13:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 28 Sep 2022 01:13:02 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 28 Sep 2022 01:13:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lS7dPLKlKVkXChduWjNJOfhVd6u1OlfEheCILQu8j0ttNN05fFHM5fwJ87js1ewJhNO02IB0OBgkxjRiGxQoV1EUWUrXBik6q20IOhgxjwIYFlnVpFBJ6UeKoIuD3w3lQnpbLa/3J0f6hh7+LdasiNK/bnK4l9FdbQus8WhNWmbPES18sSZsiKacyn2Lnq70QyLyZlh3b5LEq+V/onZZpDtxHy/6xwjUO0KlEyb6tUkaU31KWJIICBJGBeUqfphmvqMsO3B1UyHC4qC8ScRA8fbQdIG2xo742jR0p8iilbC0IOuLfj0u9sbWCvd6vTMKKszDO0C5ckAAYZgDrOpaug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eu5TOJ7HGWvlqYoMqE+Am9tK1X3vxwOy9egeSjtunPk=; b=MMG405+8xK/dsBjdMQeupwG5yDoASXYmNPRJCsX58wcEdxJLrF+3lHehvd9MR5ApE0VknrpGsrvjyYmXDRDDPjBekiw+YX/71ylcfID93RBuuH7oFy4gXxLMRtmrje1H9WGPIf6P7coxtaoifAJuy+fN0MatqD11iWA+8/e0Zb65xYgZrfWmug+6a0XyjWj7TdUFXjjJvMueV5tDuYHr+0ID8iHGyLR1WKM764ukIJnKE1odm8lzw8kaFFVsekqzL+fFthLa/GSUOwWftdkelYWKp25DUpo5qH5phHdiC67PcVO1w0DVcnGSgbcga4lDXz8kXLL4ZcEFrdhi/p946A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6953.namprd11.prod.outlook.com (2603:10b6:510:204::6) by SN7PR11MB6923.namprd11.prod.outlook.com (2603:10b6:806:2aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Wed, 28 Sep 2022 08:13:00 +0000 Received: from PH7PR11MB6953.namprd11.prod.outlook.com ([fe80::b4ae:1525:a457:6ad6]) by PH7PR11MB6953.namprd11.prod.outlook.com ([fe80::b4ae:1525:a457:6ad6%9]) with mapi id 15.20.5654.020; Wed, 28 Sep 2022 08:13:00 +0000 From: "Wang, YuanX" To: "Xia, Chenbo" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "Hu, Jiayu" , "He, Xingguang" , "Jiang, Cheng1" , "Ma, WenwuX" Subject: RE: [PATCH v3] net/vhost: support asynchronous data path Thread-Topic: [PATCH v3] net/vhost: support asynchronous data path Thread-Index: AQHYts0YZ5z+s+YGGk64pVXf4xJKWK3xfEaAgAF3aECAAay+EA== Date: Wed, 28 Sep 2022 08:13:00 +0000 Message-ID: References: <20220814150636.2260317-1-jiayu.hu@intel.com> <20220823163534.947869-1-yuanx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6953:EE_|SN7PR11MB6923:EE_ x-ms-office365-filtering-correlation-id: a04a8194-25e3-4bba-c690-08daa129424a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4lxJyUXWIg5DLtXwVf2v4tvKp/XxQhrz1LBn0EAwXmeF4jJgqY/WNglfK2bGZc3RH89T8GS+VrBIoGzNdSGwkDHNkkMpNKktGhDs0ee1ETN0fNTmO95s7V/xR95aUO+DKOg/fJ5cc+KAg+mzxWgxBOIJDJClICBArPuBoimvQOhxh+CLgkxt1ep2RGL2VYpud3yChaRZqfy4HYIF9KAsZeSSDIJMZsFSi2A/ZyMaZpS5enyoucuHf1ejYhtLfk+pEhfOq5Cm9YOEZ8EW1cv5KdUefzzyfskZfX2CATrvc8/zNWiVn/AmqwauQDW6VRpEXFTS+QHAec8lApjPl6PwhaY2aYDBfEi/cUy2S/3rbYPTRrXef6ElHCXEafRhLnjP4omcbrIo99beesXNUrWGqmDqbluFViSOiE06vUOHNYcKWLYlav7fV5Ixiw0ODZ/jqRiBZoSwiiF+NJ3c1pgtmqCzDs9U2udVVskbX9SvlK0/ETdfkygmt7oExMnVIvWQLuA+hSducV6zvr0NltZww62vrR8O37Me4QCAFAtXZLP9cmedgyN/CYmVn1HqvYlX3RtozcGeuMCVckQ1jNqhTwllB3yldfx0qJwKpzDZjcrfc6wD9Pkz4s+CEhVZ27Jh7of8juQrtoLJthfa4qSBawVxVPgavKQK3akxcyjTpJSKrrDWev4P1kAEaNSGvOQRTiMi7AfuT2+U1j3zPPHV3J/XkQzhYlgAzRz2Q9TfMiMqwvqSMhgomtcddc6b2MlqrWQ/IU6p1uYwLWYbVvre4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6953.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(366004)(39860400002)(346002)(396003)(451199015)(6506007)(7696005)(9686003)(122000001)(53546011)(66946007)(26005)(71200400001)(186003)(83380400001)(52536014)(5660300002)(107886003)(66476007)(55016003)(110136005)(54906003)(66556008)(478600001)(64756008)(41300700001)(316002)(66446008)(76116006)(8676002)(8936002)(2906002)(4326008)(38070700005)(33656002)(82960400001)(38100700002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jqp340Syecu/cM427K28HkMIgSPvTidn2orkTdyDaEhJXAl9jQaiRzj9XLOT?= =?us-ascii?Q?33gTgGvFtadv5PT9CiDRlC/2Us1c0LwI1TTSgE3Ud1oCCLnpFy+V6hqjd/Es?= =?us-ascii?Q?xwnEhxfWBF4ecbu2YvUl/MzXMK2D5kIqW0aEAxwYttcHAFEi7hsBaKOqdEYo?= =?us-ascii?Q?uGEyVUJzBUmeBFqlJDWkFTO0qqTkiZsLNYJfEv5tu8f1S2OagjJouIzINVAe?= =?us-ascii?Q?LiEXDJQ63C+7poCfUEtlQrWwyFb6NwEcTus+5FM6kHzUm7ctcpQYe/ztETxE?= =?us-ascii?Q?yN9fIohHMq0sBLUED05U/cJ6HoQtuJC9LE2M0OeX+ey8crWTPIH0C8qwJymx?= =?us-ascii?Q?rjq7ZZH82JDStHcOXXIdeWPjickyZcjCnWPz7W/WVZA403odpxm4CmvKmZsJ?= =?us-ascii?Q?I20bFTXQuvIyXoqI+xGDU87URAuZjK/9aHbcK9tvSV5CCO9VpUdv17k+HCW9?= =?us-ascii?Q?m5OEtBOoWB9wUjYubesW1wIbKiEOQByl/XI2oxDcNORenTwa6+4mjrGNu6rc?= =?us-ascii?Q?tSn141Gzp5RZ37XF+15rrz5rua9PVfsLGoKtdBFK9tqecVxdym+vQrHXhCLi?= =?us-ascii?Q?qQD5NvI+Ph1WGr+I8P8dww1ryyw9GLvmetHNsJxV4u27HRti+q8k6AihnnUb?= =?us-ascii?Q?A13RQnLAX+Z3g3952T0oLFANIfnqnXEzBNAuFknLSqrHEmtH9pvwR9xhtONa?= =?us-ascii?Q?ZL07I9mx39OQEWliOYB0aNlkMV0Fd+rYCX3pgonrzrXbvwkt46duepVtZ5df?= =?us-ascii?Q?qZiTwlTcOuo9XxUFAIhbw/bbmuc6p6hfIPbA01pQVxK2BQvqrumM4lQD3WDt?= =?us-ascii?Q?Cn25Svp8v0sDlAIvRoYihj8+i1VmgjZWWNJ9EAFR26jD6qaPT5t+m7vRZonw?= =?us-ascii?Q?Z9/OAnboVpT2/PhhldQ16WIGypl7mIt1sCD5Df9MA5nITnBUBziqvwN4/70N?= =?us-ascii?Q?umDEww2nLc2NPt3NtlceRU8lvgj1QpylDOs2qbznMQQrk6fbYDS96lt6hBwJ?= =?us-ascii?Q?yS7iiBWPlKDa0/KBOlQTETO6O/Cwc6jTPQjXvata2V2LrBCF1agaV4iQyuQt?= =?us-ascii?Q?e2Z71L+iorhRccUF800P07vGIdeTVOB2yLpw84n43r0GJ2pj9lfpwg9gyoVZ?= =?us-ascii?Q?Qc8FEPe5exjdGwrhLtiYYMJQ/ck7DsHpwYRoA8VPrW2OaSK3wNuKk7bPXFoD?= =?us-ascii?Q?T8uxb/MI+GgjNOfUG9dnNsaKWL411SWgvygoRbyFbUud9g1Sq8EykUz/9V2E?= =?us-ascii?Q?knSEi63Uk/riDuEfWVu//AJRvXN/+EtIrsNiTf2i/hUf5SY5M/mM6aRe1wL+?= =?us-ascii?Q?E4q0lLGhewpjuUtFIzokSQdTWZ958vdG2ULoDPiVHBUZCWZ4DcntbjD2V/4v?= =?us-ascii?Q?M8z8D4EW87JRqjlPNohTQfVO6NXNjqwq/b0c5EFAPVFkjdNY2yacoyKs86rY?= =?us-ascii?Q?G7nNmkgEhm8RY6cTJj97WGp1zor09e7NCt0ErECGkTSsdMa2ZVmic1oTLhKw?= =?us-ascii?Q?JGLejdPo483nGgh/WKru5xOeuoXOQIFb1y5mqfgwYCrLYQjFu0XlndSEqZX+?= =?us-ascii?Q?xz+iz0bIZNlgjehpYy7QjNKO3rIo2on+r+TiBa0T?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a04a8194-25e3-4bba-c690-08daa129424a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 08:13:00.3961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5ESwBWtrrVJrg8SJgsdKprpbc2iDDIfx3hugkwLCZ44iteWc92Bi9WGs3fRBJOGUoiXYptmgGHxR3xnkB084cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6923 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, > -----Original Message----- > From: Wang, YuanX > Sent: Tuesday, September 27, 2022 3:34 PM > To: Xia, Chenbo ; maxime.coquelin@redhat.com; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang > ; Jiang, Cheng1 ; Ma, > WenwuX > Subject: RE: [PATCH v3] net/vhost: support asynchronous data path >=20 > Hi Chenbo, >=20 > > -----Original Message----- > > From: Xia, Chenbo > > Sent: Monday, September 26, 2022 2:55 PM > > To: Wang, YuanX ; > maxime.coquelin@redhat.com; > > dev@dpdk.org > > Cc: Hu, Jiayu ; He, Xingguang > > ; Jiang, Cheng1 ; Ma, > > WenwuX > > Subject: RE: [PATCH v3] net/vhost: support asynchronous data path > > > > > -----Original Message----- > > > From: Wang, YuanX > > > Sent: Wednesday, August 24, 2022 12:36 AM > > > To: maxime.coquelin@redhat.com; Xia, Chenbo ; > > > dev@dpdk.org > > > Cc: Hu, Jiayu ; He, Xingguang > > > ; Jiang, Cheng1 ; > > > Wang, YuanX ; Ma, WenwuX > > > > > Subject: [PATCH v3] net/vhost: support asynchronous data path > > [snip] > > > +static cmdline_parse_token_string_t cmd_tx_async_vhost =3D > > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, async_vhost, > > > "async_vhost"); > > > +static cmdline_parse_token_string_t cmd_tx_tx =3D > > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, tx, "tx"); > > > +static cmdline_parse_token_string_t cmd_tx_poll =3D > > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, poll, "poll"); > > > +static cmdline_parse_token_string_t cmd_tx_completed =3D > > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, completed, > > > "completed"); > > > +static cmdline_parse_token_string_t cmd_tx_what =3D > > > + TOKEN_STRING_INITIALIZER(struct cmd_tx_poll_result, what, > > "on#off"); > > > + > > > +static void > > > +cmd_tx_poll_parsed(void *parsed_result, __rte_unused struct cmdline > > > +*cl, > > > __rte_unused void *data) > > > +{ > > > + struct cmd_tx_poll_result *res =3D parsed_result; > > > + > > > + if (!strcmp(res->what, "on")) > > > + rte_eth_vhost_async_tx_poll_completed(true); > > > + else if (!strcmp(res->what, "off")) > > > + rte_eth_vhost_async_tx_poll_completed(false); > > > > We should print log when the user input is not on/off. >=20 > Thanks for your suggestion, will add the log in v4. Sorry, I made a mistake. Entering other values will cause testpmd to report= a "Bad arguments" error. So, I don't think additional log is needed, what do you think? Thanks, Yuan >=20 > Thanks, > Yuan >=20 > > > > Thanks, > > Chenbo > > > > > +} > > > + > > > +static cmdline_parse_inst_t async_vhost_cmd_tx_poll =3D { > > > + .f =3D cmd_tx_poll_parsed, > > > + .data =3D NULL, > > > + .help_str =3D "async-vhost tx poll completed on|off", > > > + .tokens =3D { > > > + (void *)&cmd_tx_async_vhost, > > > + (void *)&cmd_tx_tx, > > > + (void *)&cmd_tx_poll, > > > + (void *)&cmd_tx_completed, > > > + (void *)&cmd_tx_what, > > > + NULL, > > > + }, > > > +}; > > > + > > > +static struct testpmd_driver_commands async_vhost_cmds =3D { > > > + .commands =3D { > > > + { > > > + &async_vhost_cmd_tx_poll, > > > + "async_vhost tx poll completed (on|off)\n" > > > + " Poll and free DMA completed packets in Tx path.\n", > > > + }, > > > + { NULL, NULL }, > > > + }, > > > +}; > > > + > > > +TESTPMD_ADD_DRIVER_COMMANDS(async_vhost_cmds) > > > -- > > > 2.25.1