From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F5CC42CCD; Fri, 16 Jun 2023 03:59:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D966B40DDB; Fri, 16 Jun 2023 03:59:32 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7B5384021E for ; Fri, 16 Jun 2023 03:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686880771; x=1718416771; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yzHgcW3005aoEpS8t+XTpQ7R99+IqijRaJfJcmP7xi0=; b=P5UcDnyA5f2LPd5sUnCKCj3S5h9JBFF67LsC0zR+ivnpqI1JvZSpweA/ H94HrAq2Yu+W1zOgJSv3N7F2pq1rtEYOjpeZQzO228JmO1eE5Ab1Ijtje RQexzzlJ6KGqMLCCLS9SMTl8bSQMpJNrx11PuryHgEF1SW28H9DBT1GTB ix717Pihqzib3tN5lvwxt281tClJbiZZHjCqq2/OT+zaUWo+mIqFD6Y9V xclp8Pfl/ey0Og4KR+WWytYGQ4ThIudXF8uttdobfxOQBLDr/ijbhHKaM /53GwSXQHA5b1Vb5KsLA+dTCsSTFLB4l60hHy/W2VLR+6mMjYYUKEZ7T0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="425021573" X-IronPort-AV: E=Sophos;i="6.00,246,1681196400"; d="scan'208";a="425021573" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 18:59:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="802641393" X-IronPort-AV: E=Sophos;i="6.00,246,1681196400"; d="scan'208";a="802641393" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jun 2023 18:59:30 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 18:59:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 18:59:29 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 18:59:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZQzAk3zzHZvrHPMRhGqtprYy1C9IFCz1NL0XrHxhHE7njxdUjyYiicP2FtYl/7rqT1Zq0mn9oja18nzOfGSuivGITq0+L51ttYq55K4//Ldf/67G+ppPKVeFP1FQwBQ3vSpifVA0TsPr2H+6CwchUM/2Y2k8G6Nryc9qvPvpO4DJHccuP4hZxdJeycbFoTXaREi5FudXPzEmw1QowdSf49ipqUPho7Lw13s5B9MBMwbTKEKnCet204DNelSdLOgQ8Q2gxc0Pwb/MRR52g7IlRm6J0Yxfv3DlWHvMUEAIQcxHgPyLYJqmPzxkEoB6s9twhfkfXN82CEuWP2UqLYfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzHgcW3005aoEpS8t+XTpQ7R99+IqijRaJfJcmP7xi0=; b=lfELKG4BAUHzI7ZSYlUo1rWsf3t6ufzQ5627uCgMdFAcz80FlPreomRFb4M8mLzUImobVkkgOdhnNH91JAzLYhvc0W8TxmqQkEEiiADnQWD+7O5nGhoG9XhlkeNiOlEbvFX9jxJ0RQIEMN+um3+tWYKoePt9oS+qtoAZSm16qVhM5O3ew3Y3vY/BQ8VAMCRL49CEa9Ao8JMIs4juNLgB0wOH3Ey+1hlX7lDIVZrUmiBFmflxdj8oGQ6zL5v8RvLp3P8GPqPqKJ1J+0JWF+uNGpb4GxyPKL+MjnNrUAMZs71+iN1vKA1ltrWAIvAet+vpKfVxAZu1nklEMnmvMjXq4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB7514.namprd11.prod.outlook.com (2603:10b6:510:276::16) by SA1PR11MB8328.namprd11.prod.outlook.com (2603:10b6:806:376::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Fri, 16 Jun 2023 01:59:28 +0000 Received: from PH7PR11MB7514.namprd11.prod.outlook.com ([fe80::b169:b7ca:70ab:4bc3]) by PH7PR11MB7514.namprd11.prod.outlook.com ([fe80::b169:b7ca:70ab:4bc3%4]) with mapi id 15.20.6477.037; Fri, 16 Jun 2023 01:59:28 +0000 From: "Chen, LingliX" To: "dev@dpdk.org" CC: Tyler Retzlaff Subject: RE: [PATCH] net/ixgbe: fix inverted test and set conditional Thread-Topic: [PATCH] net/ixgbe: fix inverted test and set conditional Thread-Index: AQHZn7/eE+s5C/gTWkOysZd0Uojm3q+MQA8AgABsZpA= Date: Fri, 16 Jun 2023 01:59:27 +0000 Message-ID: References: <1686857402-29916-1-git-send-email-roretzla@linux.microsoft.com> <1686857402-29916-2-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1686857402-29916-2-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB7514:EE_|SA1PR11MB8328:EE_ x-ms-office365-filtering-correlation-id: 937aecd5-ca8b-4a7e-7abb-08db6e0d5124 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FynB/TiU7MgQuQzXTtDl5Hffc5NoofuPvbanKX4fiVuXD65R+94Lvyk3EHlWLUw7Aj1BlLPyic7v282dxP+AU+gNykU/YiKishWQ/fdJUQskN0KN+8y5bvKw7DNcsiQeJkdX8PsstX7k5CkmkaOTWgYAPdIs923oFrTANV88quR/jUg6xwsM8gHKFBSE8TZIYE8kzpxHVuAaidPnmNoa0bRcf/NzWhaFb7mZhPjtkxVoOB9r4vXDs/4BNr1zihSvmZOcaSnvBVLl0V1jsZIyzaCYCBcONwphx467H8syGgi+OSTFOIRzsfMhfE20XBEP5HfToVc53sZib0cpiFhiayGGqnRuYr1r3C5Yaeo3MSMoVPGEX8WxEPRiO/xrJklEHeX5nsACy+NFHBUaRRpbn8Xc0mr5jkKphnmymNFiAnwkxHgQr2WRxnuv1T+i2Nf6nPepVZ1d+dWkrOlRQPvwHhiegW1e3VuTixhFSNWiwDmHZ4Ih/lEQ7HR8bsG3cIeBF6IcPZKb2X+pGxhlrhyZOpHTxtB4utMrczmc+PfEtvvbSpJz2PxpkmrPNIFPbkL6TL6RRzSjsSK5k4Yqgwe/QGagAchPa0LCgdCcmfkJNvs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB7514.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(55016003)(26005)(9686003)(53546011)(6506007)(82960400001)(38100700002)(38070700005)(122000001)(86362001)(186003)(33656002)(52536014)(5660300002)(4744005)(2906002)(71200400001)(83380400001)(41300700001)(8936002)(8676002)(64756008)(478600001)(6916009)(66556008)(66946007)(76116006)(316002)(66446008)(66476007)(4326008)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6bUGP2lEM7eWD+eFSo3ZTdRW+TEHxwwM1Ugc8ibKNJ4y41JM+6IqlC2NBWut?= =?us-ascii?Q?TPPjwVs0zuoLkq9tjJftM9+CmADNDIBgBUKC6+PuVhPsVXzqQ/kaMQmG7DtF?= =?us-ascii?Q?dTJEk3bVlM3is3xLrrNsziXa0EiLl5vyoiX+q3w4SWimFoo++65khBFlmBTK?= =?us-ascii?Q?S/VRXGACFCYU6KwAMoJfWVP4ufITWI8oIM2gtqeRcM+D9i6YUP+W/tOGWzL1?= =?us-ascii?Q?xWj6ZSejdJCKw+ocmNCBhAxPQSxkhaLExe4lL2sBhF4uHvTvrmKs6sRXOFIf?= =?us-ascii?Q?OibavXuWxd5eApXZiAxEpeJg0Z70GgmIj/p65Xw8s8OyRzORg1sRBdA1HjXs?= =?us-ascii?Q?hzo4WGZGw3Cwe0LOOz5bGWLvE4b2u3VMxWcuimkpQlcwxvOIivvhRAvzrm5N?= =?us-ascii?Q?4FNZxLa12mCf69aJGU2GWwsDH9abTQHdRGQAqUvzsmX0zr60RxpB+zpVttlR?= =?us-ascii?Q?r9XAcX8bg8UH6o3WwDuzSoP3yB+YvA4RjmA/hZGHVyNxknORZh0Opr61tVPo?= =?us-ascii?Q?uL81yXet5T5PXqICdcQZ6D2mgrXo2xqNuxWy2B3tR99m1XPOR6eo8RUCyXlM?= =?us-ascii?Q?nVRYUL35j/yY1BvkrkdgJOQyvQ1pfACZF5pthDGPYINkqt0yGAZ/DZHLXHme?= =?us-ascii?Q?SQWIXmGYPY/atBPiVe5+TFMw8v5yhoMJVE64AD5G3Mp0QmW6bB1tqqMoh+Ac?= =?us-ascii?Q?M93x485v80AZEx241oPUoVukDrH3OniO40U5svQ70sWfNbQs48FNW/L/G/Ys?= =?us-ascii?Q?1m3zl+yeWJO31yOeB0T2ZeO09/zcyq5W/oZ6eGveSz4/8AQItOfv+iUbRixz?= =?us-ascii?Q?3kz4fUWzCjb1QJSX6w4J906Q9gl9EAtf75uI2j+cESGWB8XCD8ROKJI37QPT?= =?us-ascii?Q?t0lvziBh65sXZQyW3VOYDp+c/U5okwatMtrTi3bV04rc48zD5VCirYEaGfk8?= =?us-ascii?Q?4E0xu5XgV2hh8LLA35kSvoQelJrf9I0qRQYOY8OHyUyV4G/WJ6t0wv5xPFw1?= =?us-ascii?Q?UZogx11mePJ8ZcEjqfIVHvZOw1QDbMxOHTkDR/SGPcywtqgfAFZXkoRpyltD?= =?us-ascii?Q?HKxMKGjf/jOb0inYiAXcK/bbefNOd0qZAhasE6SSR96Fsh46zdRCVx/6OfTR?= =?us-ascii?Q?y3aG3f+liLffBxGZJ3kuA75C6a8Xkf3V1A7fdrRE5MOne/Iz9p0185TXt7TA?= =?us-ascii?Q?5vIqYJnvUaulC174/o2f90XsAtgMgK39YfAk4CR0IvlrynAy/YiePOINw5VS?= =?us-ascii?Q?BGTl7l78ab+0Pm/d+t13NqEv4tP5yhoy1k95zk20yujlb753wOhkbjD3Pq8g?= =?us-ascii?Q?bCRVMAidCiOOCVlliQVue/eSzeEdkjDDUxahRRmMTd/njWje0kVtcyGJbO3r?= =?us-ascii?Q?FL+QhPTh9Nziw3QrCeSEleeHDOjbW8TopyVh9kK3fEHNpnQ5fFU1nS6wQnS3?= =?us-ascii?Q?fhGDOuzBiwfOowWKTB12WsOrMIZh2GKrhuxBlTyhc5Fn33o5R4cJ5Tz2qOA0?= =?us-ascii?Q?4TW2xjZZLlb+BPKQjRjBisKVL3NETIaD6sChe0VdIR2Cwds7p1IT5wdeDB+J?= =?us-ascii?Q?FYfhBsiEnqKe2LdnzdDGCdKy9TVN6bFPbiQ4Z5JI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB7514.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 937aecd5-ca8b-4a7e-7abb-08db6e0d5124 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 01:59:27.7538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fzeDScrd4Vb7b6oMNm0afxmK2sxJOH6aaEoUIzUZrpgNpZIv/smI48ZTp8Hv3WsIPvqazAOeG7tahzffvbxfjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8328 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Tyler Retzlaff > Sent: Friday, June 16, 2023 3:30 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Wenjun1 > ; mb@smartsharesystems.com; Tyler Retzlaff > ; david.marchand@redhat.com > Subject: [PATCH] net/ixgbe: fix inverted test and set conditional >=20 > Correct a mistake when converting ixgbe to use __atomic_test_and_set > instead of rte_atomic32_test_and_set. The return value from > __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. >=20 > Fixes: e90baf6b82f6 ("net/ixgbe: replace legacy atomics with GCC builtin > atomics") > Cc: roretzla@linux.microsoft.com > Cc: david.marchand@redhat.com > Cc: qiming.yang@intel.com >=20 > Signed-off-by: Tyler Retzlaff > --- Tested-by: Lingli Chen