From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 901B8423C1; Fri, 13 Jan 2023 12:58:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33CA442D53; Fri, 13 Jan 2023 12:58:26 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2071.outbound.protection.outlook.com [40.107.212.71]) by mails.dpdk.org (Postfix) with ESMTP id F3E0A410EF; Fri, 13 Jan 2023 12:58:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhT2BoOBy34mxJ0sNUIO1Bq+MpAzYnbV52X068rhzH9iiIsseffCsXYQRKIZ21vI0q/isfqlDUfgHttz4+7gwINr86J5qupp1GLqirh+ddeR4bMVCrXXta+HbKEOyOpAQgatc2H3wurwjSMs6Pa+zNHFNU3hFlvzaAUookCEPtqdqhGCkpMTzjYvv0W7a7dZeu/Cd1TrC0v9Z2W57RR2A/DHthsknm/nepwiTPZX1ftrEOIY/MCPn6crbBbdCHQcI2yZJahRBuujDC0jpfKcDVYjViWR0cI7F5HCzCaMdq3OMEijjqv/6bEKZUmWrKLKVyBZ7wCsM7BKC4SHV/prLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B0FitJS1Ti4jjNOA0VUPK9T44IWnZ2oijULPqCpv8wU=; b=HYLlwTh4Ryc8ReyqWv4PCidoeInsANyLF9CnSDq47mATLZyiTIaAbQawXrnLh//XnBwnrkqz72Z3vYrTLaEaztmcKoQMgdJaD68cUCTdTm4UIPKi97R+36uYuA9G9V8vMKU08NuR5Ou1ptKVImrYKmlV44LTFzgSF5HGB3OYb6edafGJWZL1qNbYAiJb277dqQVO6cFSzEQnhRHw2TvgXjJ+UQj31tyaPI2e/YH5fhKE/j/mLlFFrlJ0UFBXyXKnM5kSvPv359A4uFI02na8PLqYXl/rfKqEQLkD14RJpFOVEltm5eMGuKyrKy7GSNk0syLBg+HY4xp2l9kuHgZWVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B0FitJS1Ti4jjNOA0VUPK9T44IWnZ2oijULPqCpv8wU=; b=jl5d41QGXRwWu3c6XyqVqpV9H0Ami3yk9yzYsx3XjBYNw08xkKbHU5GRss038JvnWHNtXXE0YjaeOXlzmwZpPjGhWmiECw6bNVmf08O3AORktuIh2A6GL75hjbcpf/lesLOTHTyoMo7OO9LGxzSAsdU+ePsbsijVEs0sxOXmof8= Received: from PH7PR12MB6694.namprd12.prod.outlook.com (2603:10b6:510:1b1::8) by DS7PR12MB6069.namprd12.prod.outlook.com (2603:10b6:8:9f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 11:58:22 +0000 Received: from PH7PR12MB6694.namprd12.prod.outlook.com ([fe80::e09f:be08:39fb:4490]) by PH7PR12MB6694.namprd12.prod.outlook.com ([fe80::e09f:be08:39fb:4490%6]) with mapi id 15.20.5986.018; Fri, 13 Jan 2023 11:58:22 +0000 From: "Uttarwar, Sunil Prakashrao" To: David Marchand , "dev@dpdk.org" CC: "gakhil@marvell.com" , "stable@dpdk.org" , "Kumar, Ravi1" Subject: RE: [PATCH v2 1/4] crypto/ccp: remove some printf Thread-Topic: [PATCH v2 1/4] crypto/ccp: remove some printf Thread-Index: AQHY19bunLy8bi1gJ0Cu382y7M/C6K6c3LTQ Date: Fri, 13 Jan 2023 11:58:21 +0000 Message-ID: References: <20220909150411.3702860-1-david.marchand@redhat.com> <20221004095132.198777-1-david.marchand@redhat.com> <20221004095132.198777-2-david.marchand@redhat.com> In-Reply-To: <20221004095132.198777-2-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-01-13T11:58:18Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=6089005f-9206-40e7-842b-999900ad939f; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6694:EE_|DS7PR12MB6069:EE_ x-ms-office365-filtering-correlation-id: d7e3e601-4e3d-4c14-43d2-08daf55d780a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DC4bSoRwH6mmDQOiZ01ds2V/YMUaUofiIzORHwKIGoht/x4P7oOOJUPYO/GZr07beDGpy7Vi1FwMDewj35KanG3ny1wrBAH6mHo0oGFrPnzA/rwkTVzhi9cjulggJpLcwgfuFL51Dnp9eC7jysi7oKuwtjXe6r7VJkQ3+TDGnV2UjURX0AyeRbYm/bjQFMVsUswYUEXzcKeeKNdacVOda7Lu7d6QEoJbbk/dwZGDtN2vhqHRaL4kKL2WhLPhrdqQvM4XC6VY02FL2oO8LdfEHKV3Zuq3kn0+nQ/dGPr0y3gla5a3Gj4ltxRM/utP0mxGrSnWM1UlXH8S25x5juVcfhyO4zwsA4ugCg7DLAkFlmZbEx1q5CleG4vdOctGhLTf7i1hDZhRQYp6XnG84iI5SYcWa91IUW5R1IRSmXkCudOOr/TBmr0S736JOZ5pu60jat+I44z7s8mTkmQxFy8z7i2RSL8RSjixXXwSyofWn+Z344IJ/5hLu6Qthr09WwrswtnMPIPF7A4silEfsuTcwBkxWumvOLeirXhYph/C96rpXmIJ07uSV6dljA8zlEMYmZBgBZndnQpVran4z5GrbfmIw9Y3As+5sr/DL0k5tuIdB84aKYlG9SC3IFj2HwzW/rcp+YNPA6Bq9KC4QEnI4cmnaASYG3vwlRQ6b91u/80kLHGMmTlotda+gUqZXyRNiACJIy88gc7ZXWwjV9uB/w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB6694.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199015)(4326008)(33656002)(53546011)(6506007)(122000001)(66446008)(76116006)(38100700002)(8676002)(66946007)(66476007)(64756008)(41300700001)(66556008)(86362001)(9686003)(8936002)(26005)(478600001)(5660300002)(71200400001)(55016003)(316002)(52536014)(38070700005)(54906003)(83380400001)(7696005)(2906002)(186003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bdh+60t3hbPppJNxrAKpqmnRwy8lXYvtO3CP1dFcwBouK3Ohq9/twn5jyFyW?= =?us-ascii?Q?2DYRS2KC/e0XAFNjg1KROVAbMplxdhVTM13HjqEHPZ3HFGNVDiBC6BgNOrE4?= =?us-ascii?Q?DN5FUX2TJImIqK5hyYcLWgSdvFyJUJEofXKev/MtdaP2Br8/O/y3cvm6C0a9?= =?us-ascii?Q?ztHm970KHF2AFxSuzuUxl261irBjv9E+Pphq698p5TjRmCsDO997pE3ToPPF?= =?us-ascii?Q?JIPWqnn7WoBhwIa5d8E/I8DBkgsPLBk7Cwwp02VJ8882MpUJcYNooO31dkLf?= =?us-ascii?Q?457XM5AYk5fw+cIf2i7z4g09imVBtEDfsfSy2MMZyoXUk1pBWYOr0RGTKrcl?= =?us-ascii?Q?HQvQrznL0ONHT5w4u2jn4xo/Vxc0CkqPHsdDvZRTbmfpD/w70OLzzau7A0dE?= =?us-ascii?Q?USeWhLo3LHWNBoDUjz8N6HEYvJh6n59fz0HtwP4rEbOtoUkrqyYZrXBuE+kt?= =?us-ascii?Q?cgHNGN61WfnVPOd0tjJ6OR/nC4QE40RjOO4s/lr+Bk32PRIb2kK5RN6vBrAP?= =?us-ascii?Q?qi+elA4ppwNRUCgXiDKX5fVhV1AncP8vgtBPcLl5US9M2PFCtMKW9EdK3sPw?= =?us-ascii?Q?l9LFE9/E4SJk/KVgfp3XL7hZ6QvdJD8OhPo/qf5VlVQsx5nQFnF8p+9kzCU7?= =?us-ascii?Q?u7VUcOlNB5yb9jDQkaamNjAmKzf/5Aa6I3x48i5hSovMTSYGcE9K7h8ETtgd?= =?us-ascii?Q?TK8XbSc8pVC4ZtNHBHZW81zR7+Q/QPMizo+R89DUvJH/r8Ap9BnUUn5h9qM6?= =?us-ascii?Q?MfnqEAzJPt+8Eb2sTFHDgRWGCmLfG2clxUYvORQByucY9kT8Tsn2fUrdTv4q?= =?us-ascii?Q?xetIJIS0GjWhoFDQSRXcPODbVqnYpkJrjKm4pthKOAgCZy+++hIkPoXykn2X?= =?us-ascii?Q?nfzmxEL021XdQtFVkfv9Kyop9Z27NejIzldcpnT5agTGMPxvOTlzXph5BUo9?= =?us-ascii?Q?Jw0ZGkriZDal8yoyixiTyecb0+ris7xrvmaDf4A/BAW5WU/m67ArXZbsbhZ4?= =?us-ascii?Q?Ov/Ja9ox6/cjwSoSnpVe9UblPOlKfSASY1J1WR/y58smaCTOMbJocruKinDn?= =?us-ascii?Q?wBvejnBQydmPiunWgQyk+/1iweqXpT8jBslB8ti/2rn/pny8HbtiJeMEf9+g?= =?us-ascii?Q?9XL80YByde09zXRVLTr+gukyJvG8BPJZx0NmyTzAYV9t3wE1XY6P+hCcAWgn?= =?us-ascii?Q?zgU/KRFkY2QxB7we2Y3xpzCpRh37R0oa9RxiF6ysvzuoBNBNc3uXTg28JI0D?= =?us-ascii?Q?hLJ2iOHG3JD0lPYVxHmSpQJusDXcVVbyMklg+lexvppcpJ4BXrndiWt/3WHs?= =?us-ascii?Q?L4YRsPTuS7BZKo2hQoR8QBo6DnyFymoihXCuaQ5QChvtzBTK7YhdG63/z8i4?= =?us-ascii?Q?PXeiHqEhitkAOPfHg+Z/2jYqF3nW0LtUcrACS+pKQ+l038Nw+kQ5PaI2gubp?= =?us-ascii?Q?whBpLn39nfgMhQQRDbOI+sbvlm0vGODr6w0xCIFiE+nJ59Db/2+rxe0JZ0y6?= =?us-ascii?Q?NHwbxGi1VLgBKh4oqaIDlS66SXgdQ2wdYTA3jPQDoTsNAuncyut9iVyaZHq6?= =?us-ascii?Q?cmtPx9RfD9tD922le94=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6694.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e3e601-4e3d-4c14-43d2-08daf55d780a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 11:58:22.0423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K8gJ3HxBG7ltzAxL+P2Dr2UmTQVlFVA3Gg26/VRlz6m5ucrdzvoi7vqv9TgYyGdktVb449MgeRjPS28UjTMIaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6069 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Sunil Uttarwar -----Original Message----- From: David Marchand =20 Sent: Tuesday, October 4, 2022 3:21 PM To: dev@dpdk.org Cc: gakhil@marvell.com; Uttarwar, Sunil Prakashrao ; stable@dpdk.org; Kumar, Ravi1 Subject: [PATCH v2 1/4] crypto/ccp: remove some printf Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. A DPDK application must _not_ use printf. Use log framework. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/crypto/ccp/ccp_dev.c | 4 ++-- drivers/crypto/ccp/ccp_pci.c | 3 ++- drivers/crypto/ccp/rte_ccp_pmd.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c in= dex 424ead82c3..9c9cb81236 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -362,7 +362,7 @@ ccp_find_lsb_regions(struct ccp_queue *cmd_q, uint64_t = status) if (ccp_get_bit(&cmd_q->lsbmask, j)) weight++; - printf("Queue %d can access %d LSB regions of mask %lu\n", + CCP_LOG_DBG("Queue %d can access %d LSB regions of mask =20 + %lu\n", (int)cmd_q->id, weight, cmd_q->lsbmask); return weight ? 0 : -EINVAL; @@ -709,7 +709,7 @@ ccp_probe_devices(struct rte_pci_device *pci_dev, snprintf(dirname, sizeof(dirname), "%s/%s", SYSFS_PCI_DEVICES, d->d_name); if (is_ccp_device(dirname, ccp_id, &ccp_type)) { - printf("CCP : Detected CCP device with ID =3D 0x%x\= n", + CCP_LOG_DBG("CCP : Detected CCP device with ID =3D= =20 + 0x%x\n", ccp_id[ccp_type].device_id); ret =3D ccp_probe_device(ccp_type, pci_dev); if (ret =3D=3D 0) diff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c in= dex 38029a9081..c941e222c7 100644 --- a/drivers/crypto/ccp/ccp_pci.c +++ b/drivers/crypto/ccp/ccp_pci.c @@ -11,6 +11,7 @@ #include #include "ccp_pci.h" +#include "ccp_pmd_private.h" static const char * const uio_module_names[] =3D { "igb_uio", @@ -41,7 +42,7 @@ ccp_check_pci_uio_module(void) rewind(fp); } fclose(fp); - printf("Insert igb_uio or uio_pci_generic kernel module(s)"); + CCP_LOG_DBG("Insert igb_uio or uio_pci_generic kernel=20 + module(s)"); return -1;/* uio not inserted */ } diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_= pmd.c index 013f3be1e6..7338ef0ae8 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -250,7 +250,7 @@ cryptodev_ccp_create(const char *name, goto init_error; } - printf("CCP : Crypto device count =3D %d\n", cryptodev_cnt); + CCP_LOG_DBG("CCP : Crypto device count =3D %d\n", cryptodev_cnt); dev->device =3D &pci_dev->device; dev->device->driver =3D &pci_drv->driver; dev->driver_id =3D ccp_cryptodev_driver_id; -- 2.37.3