DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/mlx5: support no host PF configuration
@ 2023-10-11  6:41 Jiawei Wang
  2024-09-27  7:11 ` Bing Zhao
  0 siblings, 1 reply; 2+ messages in thread
From: Jiawei Wang @ 2023-10-11  6:41 UTC (permalink / raw)
  To: suanmingm, xuemingl, viacheslavo; +Cc: dev, rasland

From: Xueming Li <xuemingl@nvidia.com>

In BlueField, a new firmware configuration option NUM_OF_PF=0 disables
PF on the x86 host side, no HPF on the ARM side, and the only RDMA port
on the ARM side is the bonding device(PF0). A device probe with devargs
of representor=pf[0-1]vf[...] will probe PF0 and PF1 one by one, and
it's possible that PF1 device scan results in no switch ports.

This patch supports the new configuration by allowing a PF scan with
empty switch ports.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_os.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index d5ef695e6d..75f53ade8e 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -2195,13 +2195,6 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev,
 				     list[ns].info.master))
 				ns++;
 		}
-		if (!ns) {
-			DRV_LOG(ERR,
-				"Unable to recognize master/representors on the IB device with multiple ports.");
-			rte_errno = ENOENT;
-			ret = -rte_errno;
-			goto exit;
-		}
 	} else {
 		/*
 		 * The existence of several matching entries (nd > 1) means
-- 
2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] net/mlx5: support no host PF configuration
  2023-10-11  6:41 [PATCH] net/mlx5: support no host PF configuration Jiawei Wang
@ 2024-09-27  7:11 ` Bing Zhao
  0 siblings, 0 replies; 2+ messages in thread
From: Bing Zhao @ 2024-09-27  7:11 UTC (permalink / raw)
  To: Jiawei(Jonny) Wang, Suanming Mou, Xueming Li, Slava Ovsiienko
  Cc: dev, Raslan Darawsheh

Hi,

> -----Original Message-----
> From: Jiawei Wang <jiaweiw@nvidia.com>
> Sent: Wednesday, October 11, 2023 2:42 PM
> To: Suanming Mou <suanmingm@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: support no host PF configuration
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Xueming Li <xuemingl@nvidia.com>
> 
> In BlueField, a new firmware configuration option NUM_OF_PF=0 disables PF
> on the x86 host side, no HPF on the ARM side, and the only RDMA port on
> the ARM side is the bonding device(PF0). A device probe with devargs of
> representor=pf[0-1]vf[...] will probe PF0 and PF1 one by one, and it's
> possible that PF1 device scan results in no switch ports.
> 
> This patch supports the new configuration by allowing a PF scan with empty
> switch ports.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
> ---
>  drivers/net/mlx5/linux/mlx5_os.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index d5ef695e6d..75f53ade8e 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -2195,13 +2195,6 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device
> *cdev,
>                                      list[ns].info.master))
>                                 ns++;
>                 }
> -               if (!ns) {
> -                       DRV_LOG(ERR,
> -                               "Unable to recognize master/representors
> on the IB device with multiple ports.");
> -                       rte_errno = ENOENT;
> -                       ret = -rte_errno;
> -                       goto exit;
> -               }
>         } else {
>                 /*
>                  * The existence of several matching entries (nd > 1)
> means
> --

Acked-by: Bing Zhao <bingz@nvidia.com>

Thanks

> 2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-27  7:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-11  6:41 [PATCH] net/mlx5: support no host PF configuration Jiawei Wang
2024-09-27  7:11 ` Bing Zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).