DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <Vipin.Varghese@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	David Marchand <david.marchand@redhat.com>,
	 "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v3 1/2] latencystats: fix receive sample MP issues
Date: Fri, 27 Jun 2025 02:05:15 +0000	[thread overview]
Message-ID: <PH7PR12MB85964FDB5AC5A6C86D60FAFC8245A@PH7PR12MB8596.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250626080117.24bb3cc7@hermes.local>

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Stephen

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, June 26, 2025 8:31 PM
> To: Varghese, Vipin <Vipin.Varghese@amd.com>
> Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com>;
> stable@dpdk.org
> Subject: Re: [PATCH v3 1/2] latencystats: fix receive sample MP issues
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, 25 Jun 2025 11:31:43 +0000
> "Varghese, Vipin" <Vipin.Varghese@amd.com> wrote:
>
> > Following are our understanding
> >
> > 1. increase in multi-queue latency is attributed by spinlock.
> > 2. the lower latency with patch for multi-queue is because the lowest of all queues
> are taken into account.
> >
> > Question: will there be per queue min, max, avg stats be enhanced in future?
> >
> > Tested-by: Thiyagarajan P <Thiyagarajan.P@amd.com>
> > Reviewed-by: Vipin Varghese <Vipin.Varghese@amd.com>
>
>
> It would make sense for the latencystats to be per-port/per-queue and avoid the
> locking, but it would be a significant API change. If you actually use this then would
> be good to make it better.

Thank you for the update, we were thinking about measuring latency stats with RTE_FLOW QUEUE redirect. RTE_FLOW+QUEUE redirect is been used extensively in Virtual Ran and Packet core.

Hence we were inclined using per queue latency stats and jitter. As per my current understanding this will vary from NIC to NIC depending on ASIC and FPGA logic (for fixed function).

  reply	other threads:[~2025-06-27  2:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13  0:34 [PATCH 0/2] Latencystat optimization and fix Stephen Hemminger
2025-06-13  0:34 ` [PATCH 1/2] latencystats: fix receive sample MP issues Stephen Hemminger
2025-06-13  0:34 ` [PATCH 2/2] latencystats: optimize locking on transmit Stephen Hemminger
2025-06-13 11:13 ` [PATCH 0/2] Latencystat optimization and fix Varghese, Vipin
2025-06-16 16:04 ` [PATCH v2 0/2] Latencystats optimizations " Stephen Hemminger
2025-06-16 16:04   ` [PATCH v2 1/2] latencystats: fix receive sample MP issues Stephen Hemminger
2025-06-16 16:04   ` [PATCH v2 2/2] latencystats: optimize locking on transmit Stephen Hemminger
2025-06-17 15:00 ` [PATCH v3 0/2] latencystats: fix receive sample MP issues Stephen Hemminger
2025-06-17 15:00   ` [PATCH v3 1/2] " Stephen Hemminger
2025-06-25 11:31     ` Varghese, Vipin
2025-06-26 15:01       ` Stephen Hemminger
2025-06-27  2:05         ` Varghese, Vipin [this message]
2025-06-17 15:00   ` [PATCH v3 2/2] latencystats: optimize locking on transmit Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR12MB85964FDB5AC5A6C86D60FAFC8245A@PH7PR12MB8596.namprd12.prod.outlook.com \
    --to=vipin.varghese@amd.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).