RE: [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

["Varghese, Vipin" <Vipin.Varghese@amd.com>]

[Public]

Since somehow the email are split it is difficult to see the indexing

>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Stephen,
>
> Many thanks for diving deeper into the issue and sharing the insights.
>
> I agree. given that the primary tears down all the devices on exit, the secondary is
> left with dangling pointers and inconsistent state.

Secondary if PMD should not be attempting to cleanup (especially for ethdev_ptr shared from primary) I agree to that.
But should not be covered in library or PMD. While cleanup for other needs to be done properly

 Without a mechanism to notify or synchronize that teardown,

You already have health check added in the code for identify if primay is still alive or not..
There used to be MP thread spawned which actually piggy back the communication. Is this broken? Can you please point to git-blame where MP thread does not communicate or notify the cleanup or synchronise (lets fix it asap).


 I think it is the only option for the secondary to exit
> immediately, without attempting any cleanups, once it detects the primary has
> exited.
>
>
> Best regards,
> Khadem