RE: [PATCH] vhost/crypto: fix build with asserts

[Ali Alnubani <alialnu@nvidia.com>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 5, 2025 11:43 AM
> To: dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Chenbo Xia
> <chenbox@nvidia.com>; Akhil Goyal <gakhil@marvell.com>; Gowrishankar
> Muthukrishnan <gmuthukrishn@marvell.com>
> Subject: [PATCH] vhost/crypto: fix build with asserts
> 
> ../lib/vhost/vhost_crypto.c: In function ‘virtio_crypto_asym_rsa_der_to_xform’:
> ../lib/vhost/vhost_crypto.c:538:42: warning: comparison of integer expressions
> 	of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’}
> 	[-Wsign-compare]
>   538 |         RTE_ASSERT((tlv + len - &der[0]) == der_len);
>       |                                          ^~
> ../lib/eal/include/rte_branch_prediction.h:43:45: note: in definition of macro
> 	‘unlikely’
>    43 | #define unlikely(x)     __builtin_expect(!!(x), 0)
>       |                                             ^
> ../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’
>    47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp)
>       |                         ^~~~~~~~~~
> ../lib/vhost/vhost_crypto.c:538:9: note: in expansion of macro ‘RTE_ASSERT’
>   538 |         RTE_ASSERT((tlv + len - &der[0]) == der_len);
>       |         ^~~~~~~~~~
> 
> Fixes: d1b484bf1876 ("vhost/crypto: support asymmetric RSA")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks!

- Ali