From: Long Li <longli@microsoft.com>
To: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v4] net/mana: fix uninitialized scalar variable
Date: Fri, 14 Jun 2024 05:47:41 +0000 [thread overview]
Message-ID: <PH7PR21MB3071D56CF87C6061141118FECEC22@PH7PR21MB3071.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20240613183040.865732-1-mahmoudmatook.mm@gmail.com>
> Subject: [PATCH v4] net/mana: fix uninitialized scalar variable
>
> [You don't often get email from mahmoudmatook.mm@gmail.com. Learn why
> this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> in case we didn't enter or finished the loop without getting ifname we ret
> shouldn't have an arbitrary value.
>
> Coverity issue: 424690
> Fixes: 84497839d9ca ("net/mana: support MTU update")
> Cc: longli@microsoft.com
>
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Reviewed-by: Long Li <longli@microsoft.com>
> ---
> v4:
> * used full name in the sign off
> v3:
> * add Fixes and Cc tags
> v2:
> * Fixed typo in word "arbitrary"
> ---
> drivers/net/mana/mana.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index
> 68c625258e..c37c4e3444 100644
> --- a/drivers/net/mana/mana.c
> +++ b/drivers/net/mana/mana.c
> @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev
> __rte_unused) static int mana_get_ifname(const struct mana_priv *priv, char
> (*ifname)[IF_NAMESIZE]) {
> - int ret;
> + int ret = -ENODEV;
> DIR *dir;
> struct dirent *dent;
>
> --
> 2.43.0
prev parent reply other threads:[~2024-06-14 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 21:43 [PATCH] " mmaatuq
2024-06-12 18:23 ` [PATCH v3] " Mahmoud Maatuq
2024-06-12 23:39 ` Long Li
2024-06-13 13:44 ` Ferruh Yigit
2024-06-13 18:30 ` [PATCH v4] " Mahmoud Maatuq
2024-06-14 5:47 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB3071D56CF87C6061141118FECEC22@PH7PR21MB3071.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=mahmoudmatook.mm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).