From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EF18439CA; Fri, 26 Jan 2024 02:13:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2258F402A7; Fri, 26 Jan 2024 02:13:51 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11020003.outbound.protection.outlook.com [40.93.193.3]) by mails.dpdk.org (Postfix) with ESMTP id 0D1E240289 for ; Fri, 26 Jan 2024 02:13:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTTktwc6XjcT/g9djrVTVJ4PzFYt4GdUqfN/KAvV6V8NNLdGggzwMpPzZTdfvscavQ6maPc2nbqUvMTK+JmYY60bX7xO/4H08Z4fkD778uMU33XKgdssfBnV1ILrR3GPmywjlEDqp/CxzZE9INYpNbKnImYAkSDpZe0kZkMsi7bWHyPPnlFik9kDWKTmG6iOODOMV806lZpQ84JiKND4K0RMhH19BIQgqnxg6zr5BFJ0LG0SwIz+e7YlPNTlcKx4zFxGhclPpLH3YxQjg/PW6QPIiGjrRCIYbnJSHoMXFsboh0N4q1mrBFTEs6CCxs9OdzqQKsnzePHu5GRYtBu/TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fdlPNyyJPkFLLvbaMyOOK7/TcvrZ/ZPxBBBUQYE9pUo=; b=g4vRrrMsSB/usww7xkp+JZW3iRi61vsorYBzdiC6caBcCiV/8RL60x4TXEIodGO9Exv/tp393dxtIL2hJ44WQRkF76BjB7x4yD8X3wqs4ydcyFQM//m1Ic3IOx3IWAqSbhBE1LUgnUISnr9nLjx0b5ZfJAiejJ/ho18eNjqR5ON6BOfx+ol/YBX/P0JLKXsaaLwHIxZi0WScY/qvZNalpZCMmXpde7um4X7H5eI11Ldogok2xMM33XXVNqa9yYQFMAPoGfiAfy3qiyEeyHXzOpvYesE9TU8EPoxp1um9+4X62gQMrWR7IUjUYUWDV9PNjPn8XW8Pz8RaTParEGw81g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdlPNyyJPkFLLvbaMyOOK7/TcvrZ/ZPxBBBUQYE9pUo=; b=CNNFYTb6jN28LEzExr2xgMPLEyd6md3//4uZi7kDnqjcy2hsOoCRo6PLpVWt9LVCc+qQsXLcgY8jS+29nT/Ef6jQnsmqIjn2Bs5a7BRsuF8jAy4fMgz8O0mtm/a6UBeOtiKg0J1T59x1yoPWJ/vgu2XsIIZFFYnpteKs9oMqG0w= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by CY5PR21MB3567.namprd21.prod.outlook.com (2603:10b6:930:c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.14; Fri, 26 Jan 2024 01:13:47 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15%3]) with mapi id 15.20.7249.010; Fri, 26 Jan 2024 01:13:46 +0000 From: Long Li To: stephen , "longli@linuxonhyperv.com" CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs Thread-Topic: [PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs Thread-Index: AQHaTzgv54QqXn23WUek0AXNC50UkLDrPvUAgAAH7pA= Date: Fri, 26 Jan 2024 01:13:46 +0000 Message-ID: References: <1706150562-23248-1-git-send-email-longli@linuxonhyperv.com> <20240125162918.15a066da@hermes.local> In-Reply-To: <20240125162918.15a066da@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=e71f1df2-815e-430a-a182-5ff24e2d24ad; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-01-26T00:57:41Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|CY5PR21MB3567:EE_ x-ms-office365-filtering-correlation-id: 79f28cea-cb9e-400a-acd8-08dc1e0c0bb4 x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oIed1VAjT5GalejFsdaD4rffFRQ3wRE3SiKOVr1c4NC4avA9RJnuyt3NkV10Tk2ANd27M2GcPA/TPc3iyTDGd1qGVyWmd16c3dvbdFRMXwjGtdGB5CP8y9WvWaAbktdKcOuMFAU+NAiDBPmKBDjKWFoqRCK0Ny6UaNEoB7YPfEqeEDoQarbjpMQ53f5l/qjrnXn3x368VpZdJx60RbL1HFCiM5zClLK9Ua1+f5kO78vJOfcBls9N3MhRY0Y3IrGBrilGjZyb+H1gSeikggcm+5X7k4W/UUwdJUm/DIt8iwjUVgBYYPcGHVZf0EiDf03KsmmbKoNJW9YNJFuogdigtizV5+RwuvP73QjAophjoU9sNrvgDdn4FsGT9GBZFcqiFSmDjRr7cVioxxn+6kYYCCumzlJkrxKvXEXB7906Xtv/iGZV9PJVzBvp8ENHCZQFtvHXyGp7i4jl51mn0qsRqpawCxiN50K+i8mJQheLaqZZSYMLBgWTzrqWQRMi5fMVAYPnCPkpac4bsWfIlE6bAA/oI8wAh+M0maTxiGJVmitOHQnBaYiLC38YFL94sAj/sUORZn+3+B2WWqrwH+/2xDeynQuGGmCJTWKAXSmX/aOrVxYEKFrzeugXU49dTxkQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(396003)(346002)(366004)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(41300700001)(9686003)(6506007)(71200400001)(7696005)(55016003)(26005)(4326008)(8936002)(8676002)(52536014)(10290500003)(66446008)(66476007)(64756008)(66556008)(76116006)(54906003)(66946007)(478600001)(110136005)(86362001)(5660300002)(122000001)(82950400001)(82960400001)(316002)(38100700002)(2906002)(8990500004)(33656002)(4744005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8xfLbdJyYEGdwLE7rXasVhra8/99kzS+JVgVLEnsltxh09IPEUD87kBYm4qj?= =?us-ascii?Q?NquAAL+fgYJY88IxU63iRMy88bgnFwsLhyGpvCMn7cRuqWnAKn5HtEunRirC?= =?us-ascii?Q?1aWRkIGn3HDV/8L8uwVWedO7va5yCM51CUsDusxUIbKawQ4RXVEUS31duywD?= =?us-ascii?Q?xTS0KibqhL7GF/wLplpdzjWxHQf+S0JQn+sQy+1AVJkN35d1JtDtdxoJIm3y?= =?us-ascii?Q?dfQkG9DGYOH6WW5MH/tzr6SBg1y45so4pHZC9/KV0q1QM9ft/ZzdTLsgL3rl?= =?us-ascii?Q?sPePZXBwGXfndhjyfp+nm4HTbwJhZ598ouLbQOb6J8rWe3A5++wKwoARCQpn?= =?us-ascii?Q?LLJK6awqPPAgTdHRptSfBa/k84+q+/T6UsYsTjdwvNt3xRcDfOcA9K2CsFD8?= =?us-ascii?Q?FlX7gmrgxyB4V124a28w/AXE7U5+K86usdaKbj5DU2zQH3Bjj4nsWHKI1NSO?= =?us-ascii?Q?aznVCO1UIoZuCn30BLRIk2cupKijxZ6EieLAOh8u0LC5Dhv1C9jq+A0G3IXI?= =?us-ascii?Q?JFJ2ov6kFjW8wh17EfL4wQe+FWFgqUtai1Xmyh7AC+jN5asQTqDoa840/jep?= =?us-ascii?Q?mWTShmowyLEyxqz1JA9HPF9eINZ4xrjeQ/LMsW2Y2vF89aqmOfzkSKLrkGn7?= =?us-ascii?Q?aWG1WsrX6ygsgDO8ob27SYe+vy8ftxQ2eLQpCuNuLrkQH8E+u84CU2fe2JR5?= =?us-ascii?Q?VXdKsQsK5Z0PwF5cRMCxZDrlse4RGAVLCKOOCEY6yX2kbzU10PBCfyMwj0WJ?= =?us-ascii?Q?V7qe2/s3eXMDxKvurC6X4PKRnCkCenA/Tk1692bkPmNpFRKKcAMkn0mLo6wK?= =?us-ascii?Q?vUwhIR5PcIBRKHRFKSZXFOiHGf9vO/Xlg0WEtImSD7+l0HuABiigo9udpG+d?= =?us-ascii?Q?DEgQZD16qA5IEoFj4YLnp6QeJwRUBS2B+asIhPv0GICK7EZcHlybxCwUebur?= =?us-ascii?Q?Pzv46j3q832JAM/Y8p7KP2JOqamwLuTJICN5cESg5FhvxJIRv5Az41lhcGSd?= =?us-ascii?Q?oq58TBzHIRArauJTHdhHYlT8RKQQ4xGE/ww+eAcz7fmmsdumHc9GOOl42zq6?= =?us-ascii?Q?u2PvSU2vaEWNI1H6y4W/+BA5klZ7q6uo5Cs/00zUBsAma2Fu94aHfnBytzgy?= =?us-ascii?Q?qVMBgGBTHUxFPstVpUnXlKrY1jrNRHakBdw/GkOSP7lGCzlqp1HceVwHmubr?= =?us-ascii?Q?ng75GrndmAfrtnR450LFSjV0besgkQMsIVPMvPHBQcO/as3kWt+UQ/j7Ciwu?= =?us-ascii?Q?yijDusPVdAgl4tAgf22kaBAmL1rTw4pEx0+I1EnQfhx6pzHAI2X68RXwKtzf?= =?us-ascii?Q?Kt//24OxeAS3uP03cZJE/tDzDGzrs5+O2eOU3nPA9sgbfc0qFfsQIlFx19Td?= =?us-ascii?Q?PwerCc1aOW3qPpgUUhZ4JorhTgviqgIgjfCU7846rxc2LapGv/v3oIHkkRNT?= =?us-ascii?Q?v+RwxwnHUcj6Fthnck4Og2kCtSEXluTQYW8zYUG5QaNXiJ3vFJ/5REjKdOyj?= =?us-ascii?Q?z5lTcjNiZ/efNwKalJ1X+xEFCY076hDbcraxsawtIyENfSac4zsEr1GLZH93?= =?us-ascii?Q?lHy2f1nTrxPUgT0J4zVJS1ARouf7sHomNCFcPZSg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79f28cea-cb9e-400a-acd8-08dc1e0c0bb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2024 01:13:46.4385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qDe0Mpl0pDyZc7l7adXVGx3JQq5y96C/o7WopQ6AhlR3wj5SXwWLnsHpM7LETaKnMd4WJcUpCJ30FgseT0kd6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR21MB3567 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating = RX > WQEs >=20 > On Wed, 24 Jan 2024 18:42:42 -0800 > longli@linuxonhyperv.com wrote: >=20 > > + struct rte_mbuf **mbufs; > > + > > + mbufs =3D rte_calloc("mana_rx_mbufs", count, sizeof(struct rte_mbuf *= ), 0); > > + if (!mbufs) > > + return -ENOMEM; >=20 > Looks good, you might want to make this numa aware in some future version= . >=20 > Reviewed-by: Stephen Hemminger Thank you! I'm sending v2 to fix this. There are a couple of other places in MANA doing memory allocation that sho= uld be NUMA aware. I will send another patch to make them NUMA aware. Long