From: Long Li <longli@microsoft.com>
To: stephen <stephen@networkplumber.org>,
Alan Elder <alan.elder@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata
Date: Fri, 9 Feb 2024 01:13:57 +0000 [thread overview]
Message-ID: <PH7PR21MB326314E44A430F41B7050B52CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20240208095419.3b5579eb@hermes.local>
> > +struct ndis_pkt_vlan_info {
> > + union {
> > + struct {
> > + uint32_t pri:3; /* User Priority */
> > + uint32_t cfi:1; /* Canonical Format ID / DEI */
> > + uint32_t vlanid:12; /* VLAN ID */
> > + uint32_t reserved:16;
> > + };
> > + uint32_t value;
> > + };
> > +};
>
> Order of union elements is byte order sensitive, granted Hyper-V/Azure doesn't do
> big-endian.
Hyper-V/Azure uses the same endian for host and guest. They are all in little endian on X86 and ARM. If it uses big endian, this bug will not show up.
>
> Most of this driver came from FreeBSD. Did you look there to make sure naming is
> the same. I.e would be good to be able to have same code in both places as much
> as possible.
next prev parent reply other threads:[~2024-02-09 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 14:12 [PATCH] " Alan Elder
2024-02-08 14:42 ` [PATCH v2] " Alan Elder
2024-02-08 17:54 ` Stephen Hemminger
2024-02-09 1:13 ` Long Li [this message]
2024-02-09 15:40 ` Alan Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB326314E44A430F41B7050B52CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=alan.elder@microsoft.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).