From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2F2343AB6; Fri, 9 Feb 2024 02:14:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4099F40697; Fri, 9 Feb 2024 02:14:02 +0100 (CET) Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11021007.outbound.protection.outlook.com [40.93.193.7]) by mails.dpdk.org (Postfix) with ESMTP id 7E4A3402AF for ; Fri, 9 Feb 2024 02:14:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g5eC889ibDhL/dwUN779R+jX62Rb8AXISlpKeEkMI4cvZofrcXZnLY0fxM8bk8BvpiHB6iSr7rIW11t9K8GugTRRpBp71cK/BpgzmLwVUi9tToqplKscElRmAlkyLa0tt5dZHacypVdXiLS80wtb1Di5/fJ2jldhLnCAqCGhDtnyiJ6/T9BHxSiqgjRC34dvai3XBT+esWxw5sZbO0Z26S+wRz1Ke0BjefmS3npwKWcXxJT+SCCuZJ42N53PImlM2SOlSZM+zg+tQGgKmfq67xoA4SQq9HEfFe8baOfDmIZxUbKb+afz7dBP/n01sRvnXJzBvvLWdyTBuDXDgtkSTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jxA1PdNHU/cTfrZ0Kee2U+7Sn0NG8luDnrtKm8aIcdM=; b=aktMTe0roghWZjSwabZUOIGiMinRWkxD2int+2hNtJ/vk0BbUVxoLLMMVBe2oH+iMbcg6b0C/PP4bT9tx6c+G2ZUL/1OOlVLEJst/IMGqIIS4xF4MNVSrZAXdBJ1FONM7gVXQDi+0dvUq8mm90+Tx9NleLtQEPoG29v9Tl2ncKHCuD0z0x1K5XUpr1JzazrtAgblhLP5m2lfnDJngf7o6qMibBaulSGAv9TK99zvBj3X1CiZOGUlgydvKMDDXn4KvJWNHGSevxfkEQL04/VZAhH9ykjeAu66zQ/W/bF7zeIZhT+FP+nBGaxfF3mZYReFo5tNaSHVpmrtk5YecBzfPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxA1PdNHU/cTfrZ0Kee2U+7Sn0NG8luDnrtKm8aIcdM=; b=XFoqzyiA+HoopFOj08m/QtjKANtZt2Ymm43WhLa7hPIaYBNjBvb9CuGkdlbctk/9RG9HfliQSQum2mTtHMpi8vTaoOIhieBltXmgJKTe2WY162hxeJNk508EZAKdkIMWl6FouPAmOb04G9PFRx2NWeX1JUaRoa8raEfxdnbY1EQ= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by MW1PEPF0000E690.namprd21.prod.outlook.com (2603:10b6:329:400:0:2:0:12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.11; Fri, 9 Feb 2024 01:13:57 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15%3]) with mapi id 15.20.7292.001; Fri, 9 Feb 2024 01:13:57 +0000 From: Long Li To: stephen , Alan Elder CC: "dev@dpdk.org" Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata Thread-Topic: [PATCH v2] net/netvsc: fix parsing of VLAN metadata Thread-Index: AQHaWp0WZ+N0IrbMAUaqGUaKKZyI+7EAunOAgAB5/FA= Date: Fri, 9 Feb 2024 01:13:57 +0000 Message-ID: References: <20240208095419.3b5579eb@hermes.local> In-Reply-To: <20240208095419.3b5579eb@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=6b9f94c3-c82b-44bb-8036-75f0967d54cc; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-09T01:10:55Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|MW1PEPF0000E690:EE_ x-ms-office365-filtering-correlation-id: 43b948d0-a5a9-4824-cf63-08dc290c6435 x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DZFJZKw9ZJzVKuW/+bxcH00fVj6LVXa/6DUwOtVGMIvOtt4iOl1bzQhwI0dqmdg5hH3ez4SfiF28O7oYUovy8dfFRgbZACq4FebOS/vP3hoodswqWPj07y8hKleJmIb7XW4IEbg8tb5i/OJOrzqAwq56WxBYT+tnMosumA4p1Wo/pNbM1rqLL3vPlOUtDYFhDTYIbLKm8SnjvHAVfCQiUl8jDk2Lw9+tl7gjJMsW/TcAx8dGWHbwWG2S8hFba1G3ecOGf+nn8TJYHGka/iQoA57f1vvDCTuHXEHLd6vEr6MNv2/ro4el3YYmfuaZBVdxUmIx2lyCaHJsobcu81mqGb3ReM1kY9fOkNCeSyx92cMKpsD5YyV+OXlTmgRobDYIlER7QJ+awJME3RZoHUHwZvUQQdiYYFzUTmlmhsJK+JiMkRFMIVsVmqyohWMswvSviRa6W+3mpJgAR0SiYltklXGcS9Ni8bljRByFDH6gb+43p3WaVxl81jEqmxDDmsJrrtp63Mtl7/oKglWQ7wRHiNAVMGQdPp+WXtCAKGjpBmJsjB+s72SK0CLRUMcB0HKT1+Z5EAXyZZ+sah5abmrs77igvmOSory5aRx+8Fdv3iV86ES77OA2JNGzCtoeec/z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(376002)(396003)(39860400002)(346002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(2906002)(4744005)(8990500004)(71200400001)(6506007)(7696005)(38070700009)(478600001)(26005)(10290500003)(82960400001)(38100700002)(122000001)(86362001)(83380400001)(82950400001)(33656002)(4326008)(8676002)(52536014)(8936002)(5660300002)(9686003)(66556008)(66946007)(6636002)(64756008)(66476007)(66446008)(316002)(110136005)(76116006)(55016003)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gse6Ja03PsyNoSIITDLENegjQmoJ2Y0Vmuno+wQRuQkSJ2hXCZ9XvFe5TaCD?= =?us-ascii?Q?WBA69W20teq+mMsUaE4NI7jPNyCQUyy2loGjPs6HUuBeM9Ic1943wFoIvBMt?= =?us-ascii?Q?j7FL2pzmZ4z3wjs8ddEy8a6+xJPVSkAxHpUx/De2t11sDvk7pf5VwA/VBzeo?= =?us-ascii?Q?HRsz/nZkiCDWKjU/E7fYa+q9f4keCq1Zg4DzRa2TzFQmaney30OBz3vH/9g9?= =?us-ascii?Q?/fe8xLOVglk0YZXqFU0/u+YF9NX63azL1BPgvUGovLBbq7bsMQvE/hLZ9PXO?= =?us-ascii?Q?sQGk0xDboyK7UzDQ/BkI1nJCzlfK3m/hQ8ejawtUnZbmiO5UHdW4P682qo13?= =?us-ascii?Q?cVVfk6+ksHLUVdlm7yNFFaHTFpYs2n1d52LYAuxIOCuum3WY19eI01qGZbhM?= =?us-ascii?Q?B+3aRs9mUkh6wEh9w+6MfsarDM86UrzRsxEj4BkJlD7E2DmFUhlc/P/7iph6?= =?us-ascii?Q?rX4CEsI1Ayej2IGyyZlN+SYIUfw5FR3eDAeYXkHHg3C2o7YH1opTLU1QnwWq?= =?us-ascii?Q?w2+XrqpYtPgqjc0yAUTtXJTBMzXHn5NVEK4JgFSecVQi2Y5eVjIJmffDTM8V?= =?us-ascii?Q?uakRhqcBFTiiLjtWPLQLNXwDg8BlXHPR3TrMEpfNginfUJtCG9Y9QzHycXlS?= =?us-ascii?Q?v9fy2vQOE93IXU8TnCrjhq7YqtoOIohoOA0cbJXi6fm1a0KEf4YYLOn+KBp8?= =?us-ascii?Q?LM/J5laKOgT9C6T1OU5XIYtoDMjQ/YjUcRM11I1dEFzp0G8/RTOHMa2On4Nf?= =?us-ascii?Q?VjibFLS2ZXssVUYpmh/nONpI4ssyLo39I8IKehIbigsRVrpVsA/ujoKTu73H?= =?us-ascii?Q?E0ObHeRNyVxuhT+bmqeDhjkoFg8FOozA6xX+tyR7jIbEib3vh9k40QXBguKa?= =?us-ascii?Q?wSL7Nf2UKEGqb+a0GlQBblEkc3YTKcOPBK+v1ebnZoMadTVVkIzsO+wE71Wp?= =?us-ascii?Q?E5l0Ohz6EdAVLiE9PrXFj8SsOO3INRpg9O/E1rTzS9S2sPEeLJq/SCD6mvDj?= =?us-ascii?Q?jjIHBO3pp/JRHX2D2W9s2XJPFAg95jpW/VHujxChGvjFAdSYcr5zbeqTrO2r?= =?us-ascii?Q?689e0g4lq63iDIV6V2zAlSuexjpf2OM7BOTPn5wvqpwi8xa0o3SsskF8w01s?= =?us-ascii?Q?NKOQtr2n7i1eupHS/Kip7Gc/4j/GrVGyM+5nHfIDpqFwSYgqVAgQU68ud/Wm?= =?us-ascii?Q?xrVNvOKMxBzKLWB3XAXhusOZinPpUKgwju9XiQ8UEij7UW6zEE1uiXfCLl4H?= =?us-ascii?Q?pI6dsczPJA/Bkp47I4zARKdl2iwYrYn0hhBxh+fToKcEW5ZGilOix4knkyds?= =?us-ascii?Q?K63sZqMpzmtF4aNNl/JWDQv5r6ZOX9BScwVYSyLPBUh2i2OAEA5aFTI08Npf?= =?us-ascii?Q?3XVF9q6lqKWD9/7iczlTKWdbvhUjamWAf1EajrwGouKKJuR/rHR2uJoYjihw?= =?us-ascii?Q?GLW2Civ27e/ExPeNJbzlu2O/GD5KKDQD+sl+hiOoo4AAaagbaUAcm0UZ6TXN?= =?us-ascii?Q?Ftepoc8zjxmAWvj9NkcN7Xon+RTGDbhM8fpxVDhoyZzYhYse5a1hQoyB5Kjt?= =?us-ascii?Q?D5uyge/r/K3eyD67WwFQNflfGJy4Z+yasRzWLg3e?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43b948d0-a5a9-4824-cf63-08dc290c6435 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 01:13:57.7267 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aj3Lq2K2W+qUMTEImjPCD51EjIgmNSnErmFSLyEqizRZAK6GeXLl3bpVKGl8xvGDDWDDVK2SMwNda1Pf4rfs9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW1PEPF0000E690 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > +struct ndis_pkt_vlan_info { > > + union { > > + struct { > > + uint32_t pri:3; /* User P= riority */ > > + uint32_t cfi:1; /* Canoni= cal Format ID / DEI */ > > + uint32_t vlanid:12; /* VL= AN ID */ > > + uint32_t reserved:16; > > + }; > > + uint32_t value; > > + }; > > +}; >=20 > Order of union elements is byte order sensitive, granted Hyper-V/Azure do= esn't do > big-endian. Hyper-V/Azure uses the same endian for host and guest. They are all in litt= le endian on X86 and ARM. If it uses big endian, this bug will not show up. >=20 > Most of this driver came from FreeBSD. Did you look there to make sure na= ming is > the same. I.e would be good to be able to have same code in both places a= s much > as possible.