From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
Ajay Sharma <sharmaajay@microsoft.com>
Subject: RE: [PATCH] net/netvsc: set the correct queue state
Date: Fri, 7 Jul 2023 20:43:51 +0000 [thread overview]
Message-ID: <PH7PR21MB32632951B0A4BB8D89649489CE2DA@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20230707131601.1b2f9cd1@hermes.local>
> Subject: Re: [PATCH] net/netvsc: set the correct queue state
>
> On Fri, 7 Jul 2023 11:53:16 -0700
> longli@linuxonhyperv.com wrote:
>
> > From: Long Li <longli@microsoft.com>
> >
> > Set the queue state when queue is started/stopped.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > drivers/net/netvsc/hn_ethdev.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
>
> Interesting that not all drivers do this.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> The ones not doing it.
> af_packet
> af_xdp
> avp
> axgbe
> bnx2x
> bonding
> dpaa
> dpaa2
> e1000
> ena
> enetfec
> gve
> hinic
> igc
> ipn3ke
> kni
> liquidio
> mana
> memif
> mlx4
> netvsc
> nfp
> null
> octeon_ep
> pfe
> ring
> softnic
> vdev_netvsc
> vhost
> virtio
> vmxnet3
Testpmd added the check for stopped queues:
3c4426db54 app/testpmd: do not poll stopped queues
To pass testpmd, PMD needs to set queue state.
next prev parent reply other threads:[~2023-07-07 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 18:53 [PATCH] net/mana: " longli
2023-07-07 18:53 ` [PATCH] net/netvsc: " longli
2023-07-07 20:16 ` Stephen Hemminger
2023-07-07 20:43 ` Long Li [this message]
2023-07-08 1:52 ` Stephen Hemminger
2023-07-10 8:34 ` Ferruh Yigit
2023-08-29 18:29 ` [Patch v2] " longli
2023-10-16 12:02 ` Ferruh Yigit
2023-10-16 11:52 ` [PATCH] net/mana: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB32632951B0A4BB8D89649489CE2DA@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@linuxonhyperv.com \
--cc=sharmaajay@microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).