From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD19042DFC; Fri, 7 Jul 2023 22:43:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94BB3406B5; Fri, 7 Jul 2023 22:43:55 +0200 (CEST) Received: from BN3PR00CU001.outbound.protection.outlook.com (mail-eastus2azon11020019.outbound.protection.outlook.com [52.101.56.19]) by mails.dpdk.org (Postfix) with ESMTP id 8D9554021F for ; Fri, 7 Jul 2023 22:43:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GvE7i6RGQBKTT7qBpRXavLoJRbo7Z+YlWziN9Ykyn8WyIURWEb1AP9l6VTZ2MvisqsXHKR9rxZWcUPNXIO4cjfHEetD+9SPKKB/WmbjdrOC5TGJ9SXi06MXH5i8qeYvxipLCqZJAOsZjzSRSRNwcqhi/tzmDCLA7SxdzzeVE5hjANN/tm7IpqHXLSk4CRhmP2pXBPmn2UZWIT4xLWDXYx35XDkl/3XpM2YbCsdi1RunbtmsPOCcQMMzuUqUMJrp30mvLuX4OoB2RGCBWZzGjNAp6C2SS5ShQxT6YC/JFPZUaH0oSFFTCI97RDhQoExneeb567+NAtEWiSFV9JmJliw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5MluALHP/LBbbQRV3+frbei3xxYkgW4cP1t5NmRXWMs=; b=ZKl/8CUASzSFN0EMOuacPEH/zprofvsUysZVsxzglQGWVrQFRTHgLxU9E7MVIxt9H9oPdYnkxVBjMF9LsmI++IHiYfJK1AokJA9bbR9Jezutd5JLswi/phXpHu+M+tQQtiNGhamfZEQ/ga+4M48i+AAAJKnHpBTIYEjH9OBwj+fnPENyoHKVu4CKwOttCb0ds73F4m5ClB/CU4OwewSp+35ONy9eGy2oGXMm+YcZMi55jXrcLqbl5SGoFXqqdsbZ1bj+hxBthV6jb3bJRFgWzQMjwGgQb6cpY8QzshIphkTNcT/DZkURikrFbJJelCCvWVreeu63lvFVozsQyxqrpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5MluALHP/LBbbQRV3+frbei3xxYkgW4cP1t5NmRXWMs=; b=Gea11kJB1+IYYI3iUHr7jw4TwkyaXQe2LXtJA22nPFwCNF1OB+fGVhgO7cqv4X73FmYSPbF/+77X0vFy3jnWHfBG9D+pSxwcHed190qy8QmtiHnZXR7yak8QR/TXnmR8iel2aOfqgqugtWiB9km0J7Y7jSo1Cpq4cZsnDKcnS4c= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by DS7PR21MB3669.namprd21.prod.outlook.com (2603:10b6:8:92::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.9; Fri, 7 Jul 2023 20:43:51 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::eee5:34cd:7c3b:9374]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::eee5:34cd:7c3b:9374%5]) with mapi id 15.20.6544.002; Fri, 7 Jul 2023 20:43:51 +0000 From: Long Li To: Stephen Hemminger , "longli@linuxonhyperv.com" CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Ajay Sharma Subject: RE: [PATCH] net/netvsc: set the correct queue state Thread-Topic: [PATCH] net/netvsc: set the correct queue state Thread-Index: AQHZsQRTdJyeYyojTUeTCoRZvbgb8q+uvamAgAAG0sA= Date: Fri, 7 Jul 2023 20:43:51 +0000 Message-ID: References: <1688755996-25172-1-git-send-email-longli@linuxonhyperv.com> <1688755996-25172-2-git-send-email-longli@linuxonhyperv.com> <20230707131601.1b2f9cd1@hermes.local> In-Reply-To: <20230707131601.1b2f9cd1@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=aaf81ba6-203e-43c9-a1d6-1bbec372a9b2; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-07-07T20:40:25Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|DS7PR21MB3669:EE_ x-ms-office365-filtering-correlation-id: ca3fb21d-9ad4-4eeb-97c4-08db7f2adf5a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L9ixAhQiTPlZOz/8v0SigaI0SAkqPKKvMQpgsTmrDtjtKTeNe3EfTTNkBlgOQNjsW4ry7NFNSXULj/Y0AXRv2Uly9l0lXWoXVKSBttpMIrY5xy3ziccad+c+oC7BnjpPzmmfE4exiKT0EftUnFFNiO/QJr5aPgXkmEYT2vd9V+kPNlwFTU/ZlkmotZKZu6ExKug1o4wECiPbZLplqkF8BgUC1/ZzHPn3nLpeDS84QBFiMR3BTzsrGApQIw7wUvfdct+qq3OnNipib8zIoTodyg1zkSYeJZzxHmyQYeFagk5xpJDG8D1QzPEAb4PBNudy/c1Uqk6a9UKUjz5HNqc7ysW7C+q+TvFt5LPJ4/pjpWkEUcafH3I7+TkLeOF0ogkoA7mUkn3v70uwRl8KNC0HhRg3SBSvLxXQPzntzQaSORE61pzps/OAXjs/hv/VM+n7iOEX0pzPbPfWe51AYvEgqZ6cxfmPcf2fTLWBVOv7jNaUxhJZdnSRfaOnnOHOtVyEdu2n1v7s0tAIyfG2/FzH5x+52/wIcur7hVHxy2C8xTl6pZLfo78fXqqs/2ri9j99O/Vz2Kb16zAWjh7RJRiv+PsLR3HR9eoOAgzSFsr/s+kDnL5gq8Hq3ingnVnfZcO/mxFGfU7elb9Jdc9cOWvBVOa0HIdarrEhQAhkqFzxNx8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(451199021)(2906002)(38070700005)(66476007)(55016003)(316002)(76116006)(64756008)(66556008)(66446008)(4326008)(82960400001)(6506007)(186003)(82950400001)(38100700002)(122000001)(26005)(8990500004)(9686003)(66946007)(71200400001)(7696005)(10290500003)(107886003)(478600001)(54906003)(110136005)(8676002)(83380400001)(33656002)(8936002)(52536014)(5660300002)(4744005)(86362001)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CUPTg4Am1Qv89W/2wwmEebTicTvVqAxkLBMUMpeRzzOsV7ik4O78C67YpRxV?= =?us-ascii?Q?ZQVBaOIa7mbNzYmgA8E/v3+yn/tVThwgOOSnCHu48DOBSnwa2XiN8PUtO+GQ?= =?us-ascii?Q?Byr1wWrNJ+piCnrpxs2pEG1R+d+DANRxbS7RzsrM4m/VtIekSBafhdq6WHx0?= =?us-ascii?Q?6iA/N4y/9V6wCIWbD+nlWQtMegjiq4qjpNEqb+FuuzjlM45qHAxvn4sjQaYp?= =?us-ascii?Q?msleSL/Wb5awKB86Gv2NBCIu3qKGl5uGJtMTvCx/0L5RbXbIgvxpKByhzJkI?= =?us-ascii?Q?CAsrNcQ5vFw1PQ3f8OAAQDNaAomP19fPAr1f/J2nDXLOw5XQXMPPDFTG3NC6?= =?us-ascii?Q?PV2JcfmBXxBvNJ8bp/uYVNBwK7jXSdvLxURkGIeOH51SCraK4y+xMLgE1Y0b?= =?us-ascii?Q?4DzmQK3X+xwV6ThXZMhois5D5V7ZcVvwgNnWAgU4CFkIgWoMdRJHB3JrR/yK?= =?us-ascii?Q?grKId1wOFTO4IXmLYcDXgQYGZV4hqIrfDO5ufm/PFFX02k7H0gbn7IwxiN3u?= =?us-ascii?Q?DaoZiJ4/U575prFVvKFdQu3mMKc8XIv2ewu/K30cB0c8txwwUlckJdzg3aCk?= =?us-ascii?Q?uYWsjOjxnz9xdist1hOzlfch3aImIzR1t6CxqcdnKJT9Fkr8LhkQ4YJa3qBA?= =?us-ascii?Q?VORZqbhlxu4xkiXWoCW+kNW6fIPi0wJ57T2Pg08Y5+UyIII+MlrswED7snSu?= =?us-ascii?Q?pulMgsX4VJkBD1egD5IliGda5/kgtkctEAZUsacYpQNWjwxaXftXm8UzYRav?= =?us-ascii?Q?WFFsqpeoYChNvj8VGQg3wUAooRh8QA9VmfwG+cuQ5MCKtuCEUzy7Rne4aqe1?= =?us-ascii?Q?uKtRBPkBQHiz4EnJYwXittPPzjCjIXHO+qsZx2e5utpc+KEBHJdHRdsJKyzL?= =?us-ascii?Q?An+3REk7D467ieX0xWH4pXVFxehJMN7vFxjZxHiK33baXQSqBPch/hxNr1VG?= =?us-ascii?Q?/DYvk6keG+t2Dr+ocfWaEo/tupAjDiAoqWtCXheFKWEO5jjb9B7jvge/HjMS?= =?us-ascii?Q?87QLp5/YOCRFZVM5t7n1wgGcmKXzV36ZOxLBQdffhV5TeFyTD2tjc5ZDGU0j?= =?us-ascii?Q?5RuDjIDJ/F/++sYowfJwHx59deHshoedBr48iVOdLyDuWL6vTRn4XiyVHsnr?= =?us-ascii?Q?nK928qpAUQoZvGgy/OSExctxXogtVE7fhMviwLIOhOjHZoR17dnZ9TTpq305?= =?us-ascii?Q?/zaFTuA2ZIC1EZuPnr5gLy2hNqSUNaGphR6vjk60YGq6Q1k0j8MZeaE2+23W?= =?us-ascii?Q?Jb1yCXxxtVYgESXf3n4XjXfH0VZrz1hS6gdECnhUuEaQv+KDe7n7+xpvPamR?= =?us-ascii?Q?rrytjkV1xxBLUtxaSdzCZ7zFfx1SmPjiWEtZyZxX3wn6b/fV+PBFvG++15Iq?= =?us-ascii?Q?zW24+e3dXr7VbWvgEL5FwOhavpqrmFg8SKqmuk9Pk2NjJDymrjb5uo/rEyRE?= =?us-ascii?Q?KpszfuWllacASjYOmaIloBt0BCGb2EJJ/Ub2yvUcWuFI8faZmfZ/t6GiIQ3v?= =?us-ascii?Q?SNVBLtDhxRrdZbOr4ZWvSEW9f4qK68lNvyLP0ERJZ3cv9ibh9DxD/Z+8eT3P?= =?us-ascii?Q?AyVmYBK2VWOn/0wIwHYALCCDSosl5eQ1R0DPBztn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca3fb21d-9ad4-4eeb-97c4-08db7f2adf5a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2023 20:43:51.5128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RtRkO43rAAv3T/5iHhpdSEiI8e9PGX1r57U/MHlfbeusGYl0VxM/zxfZrNXvMAB9EyHdzafSKancay5abYqpAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3669 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [PATCH] net/netvsc: set the correct queue state >=20 > On Fri, 7 Jul 2023 11:53:16 -0700 > longli@linuxonhyperv.com wrote: >=20 > > From: Long Li > > > > Set the queue state when queue is started/stopped. > > > > Signed-off-by: Long Li > > --- > > drivers/net/netvsc/hn_ethdev.c | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > Interesting that not all drivers do this. >=20 > Acked-by: Stephen Hemminger >=20 > The ones not doing it. > af_packet > af_xdp > avp > axgbe > bnx2x > bonding > dpaa > dpaa2 > e1000 > ena > enetfec > gve > hinic > igc > ipn3ke > kni > liquidio > mana > memif > mlx4 > netvsc > nfp > null > octeon_ep > pfe > ring > softnic > vdev_netvsc > vhost > virtio > vmxnet3 Testpmd added the check for stopped queues: 3c4426db54 app/testpmd: do not poll stopped queues To pass testpmd, PMD needs to set queue state.