From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0301A0550; Thu, 8 Sep 2022 00:24:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AFF440143; Thu, 8 Sep 2022 00:24:15 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2103.outbound.protection.outlook.com [40.107.243.103]) by mails.dpdk.org (Postfix) with ESMTP id 824DB400D6 for ; Thu, 8 Sep 2022 00:24:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/OoBPGMYSOfZ13FP4CKdqPXWg9fajPOFHdQNb3qVE+qJkl7fXP3KYX+St8OGl15EyrRvlwa9aZyq+yaWu5IxKHKeWDrLSocVvwMCtjfYAmabLfiGEzaQZuiEosOG6scHHRfZDZvkupY43pDDo0jHPuuSmyDiCrWD5FfJJArgQLMS+qrVVZP7tchQu9o+AiPn0X1v3goxloiXI+0gv0kMZW1dWGPbaWBJbTYewHR9dUneQW3RBD5WoKuQzVxbNDrRy6NNBu0SY9SABrhOLFw6LqL/nXEs24oCZ/E8uGmdRLLUSWzZJJ4A+0/2XteUy2kbjOu9aAP7/UmWCN2aP9R3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RgX45c6X4rufdVLFh+oZErHTYoz6iIslcimOarLZ4OE=; b=VrBr9odfEZxHaztx8r8VTBrz+5wzuyrOxmUj/LjsSd66BcipCjazBiEgJsVanxbTs56OJoOyD4inH3WE+oFk/++2F+nt+Tqb+RCXIpnXOFWDk+c4ZoGn6Ev5iTAPgre+c9y0wWuWw2QR+bAAaeOv19R3uFg07uEtPo9fjdxKMT75J4FHav97qkWjoHJPCTLSGv/UPSP7UCrZXnKrDybwvkseOF/BdkC+3o7sMHEW45WhdDanPStGdwmCCt/JcdtICOF/PnEnJ+gigLHI8RgV1rN1w7d4+8yUHkhfH8BHwOevi+sAToLH9UBvi3s0W1hQWWkVZS5m1W5fDBx7FOBo0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgX45c6X4rufdVLFh+oZErHTYoz6iIslcimOarLZ4OE=; b=ZxmcIyna2ZwBgNX9+woWjqIneT3MIRtzC+dhdgvkp8BiveP9PqywYMo/Y3xdLZypvnNinJtjg5EfG2ANBdXMAOGATRrf0zDyDid1cS9L7QRtwcOmavbb8qfxXkYuFWqz475KTY1gUD65anMeHdEev3yP6frdW6URh/xkl9rWcwE= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by SJ1PR21MB3648.namprd21.prod.outlook.com (2603:10b6:a03:454::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.3; Wed, 7 Sep 2022 22:24:12 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac%8]) with mapi id 15.20.5632.002; Wed, 7 Sep 2022 22:24:11 +0000 From: Long Li To: Ferruh Yigit CC: "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Topic: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Index: AQHYvzZA189idMIQUU+0ipuUZahvta3SYymAgADUrgCAAA+KkIAAbh+AgADc3/A= Date: Wed, 7 Sep 2022 22:24:11 +0000 Message-ID: References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|SJ1PR21MB3648:EE_ x-ms-office365-filtering-correlation-id: 25d2c51e-e411-4d3f-0188-08da911fb08d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +VU3wajwBUaHsEbh0agCwzWYuUuHqCw4NZnc/OBpxPzFv5LLl60e9JS9VuZeF5qVrzy9H09St9fVDmArMrigh55pwyJiRXF1JlPQbEtvLHwOd28p6lXcEdKozprQ5GwKt2Mzi79XyHiiSMT3kM5NpkeAPJxS2o0GsRrk4RKfZLkXXqJGRPbVHqWj+Oz+qHtEjxABCBcEUgnkoO82A18/zDkWB7D+9LIFTrSvWZTFmZ02VLxqe55vCiaAMPtExmKcZ2DmsF5XX62pb6mR4h/nMyiun182R2ijdy7RTiPqAGHOwocgXip6FIMFtACA6htPJgU2rIBB3/kZrh6CX/focnwiRjbak535OIi8dfCLuZBXpbkb2KCw1ZTmhMMCexHvlKinbXARhXA5Xpv5O2AwEZ8+QSSXeDqmCz3teBurR2MRjlv9IPLuIDfjJ1khDMs6YgrVK3KAr7qRBGw0O5KWkX4BtoFHQXSSXxsOvahlnaGGSnTYbvhtz8at9U1qI6jruL2HdNy1+1QW7bOtfwOHiEfS+mUgbNx4d0m28mNssSEAGlGeycIgY1j9OrJM7fW6ExMVqStMfM76HYRvNBcAG+ng+uzyN0AqypGy05O/eQ2oa0UnGF/6KSCMTv+bNgz7nLDuZ5Tl58JN768y/STpp1bmFklvMc6mO542VuMpOCdixA9A14m7IuDz7XkHotA5/tKVXyHOMCzv/fIdYVhnscvShQJe00/jNycZ1fMecb2h6oKltMLRUXROx+B4McLv/kfTuMgSr3pqdaZVVp2vDsYhxdECazkWwJG/ugnelv0uHAovgzFw4BAvSK7SSIRePC1SRfXdD2e5p309/JFyK3fa7oLTXRmjrtrC+3ChIZ1uUCCbLGT/gzs01zWz2uRF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199009)(6506007)(9686003)(107886003)(7696005)(6916009)(478600001)(54906003)(53546011)(26005)(10290500003)(41300700001)(316002)(966005)(71200400001)(38100700002)(122000001)(55016003)(83380400001)(38070700005)(76116006)(82960400001)(8676002)(33656002)(66556008)(186003)(86362001)(66476007)(66446008)(64756008)(82950400001)(4326008)(8990500004)(5660300002)(66946007)(2906002)(52536014)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t6qmUddDZ45dj9vnGa/MpmUO7gd3VO6evuLd70q8BG97dGWZygfmbyx5Guhz?= =?us-ascii?Q?1q8ce/kNLU3UsM2HwFrCgvAsacR0u+cwepEHg30KQUOmiv7sUJazMuuWqczV?= =?us-ascii?Q?t6B8WVaYJrh2HgxAB0v6blZ08pGKjfSvmW9j+PXZumiVv9EAljcfp15Bisca?= =?us-ascii?Q?scZJl+mOUWCUtRiWZ0j/G+CMYOOmZIejR6WU6FOc5DBk0J9Lp9wHpBfKNOYZ?= =?us-ascii?Q?F7+rJDc3uswkFY7IKS2YcA4CCcCdbwjMz3iR8K/bz2JEtgtOZG1eMzawn91+?= =?us-ascii?Q?uMeJE4hbVAetrMYeYK+8c9L8IwemDiTQllBwDTjCoMu3ufLayuqBu/Cgd5F7?= =?us-ascii?Q?smS7tLiDjw904F/zmTCkC7oQzwO0Q5pX9xHdWiDTWlU2zveLQeSqqjY2gsQr?= =?us-ascii?Q?y2ZzbmWLfnM8DxtYJ8KiT5QagJIzSsx6gUFQJnXy5K9AhzmCWGdTwKqP0HDv?= =?us-ascii?Q?897ZshLjO7q+B6eAFqIvpa9QYnUvFYuKEx8h4Qoy7vNVEk1CCc/npUaHLYCI?= =?us-ascii?Q?NNfJdfVxk2O2ytPBs7w4YqM+jvaiBb/IFQiAzwjbCRi+HUUPi4aHvUiYYAU5?= =?us-ascii?Q?oCy78ylUlbskcyGwDER74ZoeFSHkJ0ZMgGDSSmB6M4Ju15vlC06xh3UV6xcD?= =?us-ascii?Q?Ijh2/A2Df1/IKU/HqI+Z3Kw+xeSPpevv5lWxUl7HOliSuJ3EEYV2zF3VobTY?= =?us-ascii?Q?zow7cEaoqZA89z/sECqbxYXHKLHq4drHDnj7c+j9Y2tH1eYM5/Z8GNSuui1n?= =?us-ascii?Q?G2jhBHIeJJZozUGRWBH2a8ubXvil+/dgNpn8z8Ohttt4MXIEX94d82rQsENX?= =?us-ascii?Q?ugCIT6z449HeZKhAbInO36EcWcyWxD5m8KfeBDD3Tnj5KddMjV4vxBUzHxl9?= =?us-ascii?Q?k0SnBOexFIDeNawyM1v/D2jBrg4U4IkiH2bpmMpcYV6jY1ROTyxFVNVtRIIT?= =?us-ascii?Q?J1iEDHwgCNKmJq59VI3dQ9+v4LEvVwDoF4iiVt/oVlooHoFYNddjxk6JsES5?= =?us-ascii?Q?+fjqxWr7p3/eGidGMiuX/AJ9FN6RgLpasc0KJrSHtnwKmhqUmr7/dP2rWVsz?= =?us-ascii?Q?+ms19y4dG8D4o/3GMuAVn7EH10BlUg8NHrag0CAGk6riSZVgP1ogHlUb2pDb?= =?us-ascii?Q?yWZEqF5GRNo/swfUdW9t+rZrnGkhRzkavNrBHbDGAW8X1jTsveWulENsd1bp?= =?us-ascii?Q?nzwOkDGtvadFIEHr1o3Z6/mXGSvl4fNGhWucfLAlFLaSyD4SkQx6NVUq8vpr?= =?us-ascii?Q?mtahH9hMVYyVoVTzvOVuUN/AXp58cu+YWLOITxT6pIDi3owRbKTziFQN+3mv?= =?us-ascii?Q?qGE7Gj0m6jeayNEnJq7vFaG2uO9atRD3d5iOlhI6MNjs+xTT12PkB6+jup5P?= =?us-ascii?Q?BgrfG+o1Kfhr6tgbiHgGlh9oKp2XLhgo5R0jx5TeVzpQ65nCNe7X4HNN1ido?= =?us-ascii?Q?ks1TvYOtnHCf9e7sduJJS6xj64nT0PlqfgbFcOlOZyu1oL5t1fuQPLH0d263?= =?us-ascii?Q?IHGjtkXI7I41wrSzG0s5gwKYjgG31Kcq8Z2rgIgP4BDmz9S8NqQZ3s1DYO5D?= =?us-ascii?Q?gD+HWyIfy66RIHtRr50iIzSiP/BWFH6vhnYkGLPO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR21MB3648 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environme= nt > and doc >=20 > On 9/7/2022 3:41 AM, Long Li wrote: >=20 > > > >> Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build > >> environment and doc > >> > >>> Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build > >>> environment and doc > >>> > >>> On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: > >>> > >>>> > >>>> From: Long Li > >>>> > >>>> MANA is a PCI device. It uses IB verbs to access hardware through > >>>> the kernel RDMA layer. This patch introduces build environment and > >>>> basic device probe functions. > >>>> > >>>> Signed-off-by: Long Li > >>>> --- > >>>> Change log: > >>>> v2: > >>>> Fix typos. > >>>> Make the driver build only on x86-64 and Linux. > >>>> Remove unused header files. > >>>> Change port definition to uint16_t or uint8_t (for IB). > >>>> Use getline() in place of fgets() to read and truncate a line. > >>>> v3: > >>>> Add meson build check for required functions from RDMA direct verb > >>>> header file > >>>> v4: > >>>> Remove extra "\n" in logging code. > >>>> Use "r" in place of "rb" in fopen() to read text files. > >>>> v7: > >>>> Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > >>>> > >>> > >>> Can you please check review comments on v4 [1], they seem still > >>> valid in this version. > >>> I didn't go through other patches, but can you please double check > >>> comments on all v4 patches? > >> > >> Sorry it was an oversight. Will remove all the "\n" and double check. > > > > Are you referring to " Remove extra "\n" in logging code." In the comme= nt? > > > > There are two places "\n" are used, DRV_LOG() and PMD_INIT_LOG() in > mana.h. I think they are okay as there is a single "\n" on each output li= ne. > > > > Please let me know if I missed anything. > > >=20 > Not referring specific to '\n', there are multiple comments there. > Can you please double check the email or archive link, comments are all i= nline? I apologize I have missed some of the comments. I will address those and se= nd next version. >=20 > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Finbo > x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- > 0852317b4a72%40xilinx.com%2F&data=3D05%7C01%7Clongli%40microsoft > .com%7Cf92fcbd63c2e47b00aed08da90b11cc8%7C72f988bf86f141af91ab2d7c > d011db47%7C1%7C0%7C637981387628427454%7CUnknown%7CTWFpbGZsb3 > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000%7C%7C%7C&sdata=3Dg1dkWTofo%2FD40ANMkI09jpyHp8Q > UEtCoRTCff1mrPEs%3D&reserved=3D0 >=20 > >> > >>> > >>> > >>> [1] > >>> > >> > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Finb > >> o > >>> x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- > >>> > >> > 0852317b4a72%40xilinx.com%2F&data=3D05%7C01%7Clongli%40microsoft > >>> .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab > 2d > >> 7c > >>> > >> > d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3 > >>> > >> > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > >>> %3D%7C3000%7C%7C%7C&sdata=3D4CHI9uw%2B0MwJtVjamECVZW > vU > >> Yq > >>> BCitq7STstFNPNIN8%3D&reserved=3D0 > >