From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [PATCH 13/17] net/mana: add function to start/stop RX queues
Date: Sat, 2 Jul 2022 08:42:54 +0000 [thread overview]
Message-ID: <PH7PR21MB3263601FAF5FB580A51EAC12CEBC9@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20220701094041.43e5d16c@hermes.local>
> Subject: Re: [PATCH 13/17] net/mana: add function to start/stop RX queues
>
> On Fri, 1 Jul 2022 02:02:43 -0700
> longli@linuxonhyperv.com wrote:
>
> > +
> > +static uint8_t
> mana_rss_hash_key_default[TOEPLITZ_HASH_KEY_SIZE_IN_BYTES] = {
> > + 0x2c, 0xc6, 0x81, 0xd1,
> > + 0x5b, 0xdb, 0xf4, 0xf7,
> > + 0xfc, 0xa2, 0x83, 0x19,
> > + 0xdb, 0x1a, 0x3e, 0x94,
> > + 0x6b, 0x9e, 0x38, 0xd9,
> > + 0x2c, 0x9c, 0x03, 0xd1,
> > + 0xad, 0x99, 0x44, 0xa7,
> > + 0xd9, 0x56, 0x3d, 0x59,
> > + 0x06, 0x3c, 0x25, 0xf3,
> > + 0xfc, 0x1f, 0xdc, 0x2a,
> > +};
> > +
>
> Is this constant?
I found it awkward defining it as const.
Later, the code uses ".rx_hash_key = mana_rss_hash_key_default" to assign this to the IB verb interface. rx_hash_key is of type uint8_t * (non const).
I'm yet to find a way to do this assignment without the compiler complaining about convert const pointer to pointer.
next prev parent reply other threads:[~2022-07-02 9:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:02 [PATCH 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-07-01 9:02 ` [PATCH 01/17] net/mana: add basic driver, build environment and doc longli
2022-07-01 16:29 ` Stephen Hemminger
2022-07-01 16:44 ` Stephen Hemminger
2022-07-01 16:45 ` Stephen Hemminger
2022-07-01 16:47 ` Stephen Hemminger
2022-07-03 7:56 ` Long Li
2022-07-04 16:35 ` Stephen Hemminger
2022-07-04 16:41 ` Stephen Hemminger
2022-07-05 19:50 ` Long Li
2022-07-01 16:49 ` Stephen Hemminger
2022-07-01 19:40 ` Long Li
2022-07-01 9:02 ` [PATCH 02/17] net/mana: add device configuration and stop longli
2022-07-01 16:34 ` Stephen Hemminger
2022-07-01 9:02 ` [PATCH 03/17] net/mana: add function to report support ptypes longli
2022-07-01 9:02 ` [PATCH 04/17] net/mana: add link update longli
2022-07-01 9:02 ` [PATCH 05/17] net/mana: add function for device removal interrupts longli
2022-07-01 9:02 ` [PATCH 06/17] net/mana: add device info longli
2022-07-01 9:02 ` [PATCH 07/17] net/mana: add function to configure RSS longli
2022-07-01 9:02 ` [PATCH 08/17] net/mana: add function to configure RX queues longli
2022-07-01 9:02 ` [PATCH 09/17] net/mana: add function to configure TX queues longli
2022-07-01 9:02 ` [PATCH 10/17] net/mana: implement memory registration longli
2022-07-01 16:37 ` Stephen Hemminger
2022-07-01 9:02 ` [PATCH 11/17] net/mana: implement the hardware layer operations longli
2022-07-01 16:38 ` Stephen Hemminger
2022-07-01 9:02 ` [PATCH 12/17] net/mana: add function to start/stop TX queues longli
2022-07-01 16:39 ` Stephen Hemminger
2022-07-01 9:02 ` [PATCH 13/17] net/mana: add function to start/stop RX queues longli
2022-07-01 16:40 ` Stephen Hemminger
2022-07-02 8:42 ` Long Li [this message]
2022-07-01 9:02 ` [PATCH 14/17] net/mana: add function to receive packets longli
2022-07-01 9:02 ` [PATCH 15/17] net/mana: add function to send packets longli
2022-07-01 9:02 ` [PATCH 16/17] net/mana: add function to start/stop device longli
2022-07-01 9:02 ` [PATCH 17/17] net/mana: add function to report queue stats longli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB3263601FAF5FB580A51EAC12CEBC9@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=longli@linuxonhyperv.com \
--cc=sharmaajay@microsoft.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).