From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABB27A00C4; Sat, 2 Jul 2022 11:55:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50CD540E03; Sat, 2 Jul 2022 11:55:40 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021015.outbound.protection.outlook.com [52.101.62.15]) by mails.dpdk.org (Postfix) with ESMTP id D736240A83 for ; Sat, 2 Jul 2022 11:55:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJWCFJi7vrO9rjGYBAtx6zuGKVxuKG4210c4YVm4GWSF/qJncqYPAP8rB9R1GhUsKtlY3CaUXDcqZjgzjSuAjVtJjvKzXJZ7Z5tD2H6yePuuyXcWm4dAlUdP/hfyMya/6LwOSlqbM5IW8taj1aMdNMP8I7ZHbBBwg6TeLUuJJ/62/joj5uoTDO7akJe45KP4KzfdTNiqLWFvy5Ky3UITgTE3UQzGWd0/nzQch+85CkcXP8IUOoyXDggczaZsCck+ryOslYtKawHwk9KpKIhmGWYqcV2iXZhFWXTCyHxJ8NBFH20SF+yzbTTJtM/IAI7+3na8hQ0ijLg5ixatfxZ+rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fnoX3PjUC4BoDixKNKvgXKIacuzyxDPHpQd2/HWi59c=; b=EmWp2LBgbW30rHJeG+O4Z5ifP94kfIOkAd7xBDNQwB8T4BF1tJO6aagkYoah6QbDl4Py4nXrtZs5+QXnFTy1ZwqUKZuWA17dOVCseNCQsyyGvHAaSfUn8tNXiaEwfa31S1qEwDSLrYSu3a9XZux7cOIZeYzv2NDKQfuqhAfcWt3mMutKNC7P5Sfku1UMh5U3kCyGNaTL5B3luFv5uwN06VmKeSA7Rs3cJITYG2g9UMWjmsKl0vYYNumv/uuP61DVBMI3zVi/TTBDS8Rb0Y9M5Trm4kRo31mGS0bv/AHZZL/fXl1LDsOG5DDzzmE+QQ5cL7ml+Yi2G/DJ/MmdQU1MYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fnoX3PjUC4BoDixKNKvgXKIacuzyxDPHpQd2/HWi59c=; b=SIsuMIuzNyujmfYghaga7Suzw1IHprGOPxvnc0SkEkKID4qBPjcVe1xGKeJCSGwmwOaKYgBZlwQLTu6dl9HmyK5sjfE094OWgCPs/brfS2ue5mLWz+LQc0tkJIZhsHrksL0OrIGEBV0sdyUPS4RbgVpBnrN2umQAnPVGOCkx120= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by PH0PR21MB1328.namprd21.prod.outlook.com (2603:10b6:510:105::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.11; Sat, 2 Jul 2022 09:55:36 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::11a4:ce07:c6d8:c172]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::11a4:ce07:c6d8:c172%7]) with mapi id 15.20.5373.010; Sat, 2 Jul 2022 09:55:34 +0000 From: Long Li To: Stephen Hemminger , "longli@linuxonhyperv.com" CC: Ferruh Yigit , "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger Subject: RE: [PATCH 13/17] net/mana: add function to start/stop RX queues Thread-Topic: [PATCH 13/17] net/mana: add function to start/stop RX queues Thread-Index: AQHYjSlkiDy3IOpSB0eIVi+CzelOeK1puEeAgAELCgA= Date: Sat, 2 Jul 2022 08:42:54 +0000 Message-ID: References: <1656666167-26035-1-git-send-email-longli@linuxonhyperv.com> <1656666167-26035-14-git-send-email-longli@linuxonhyperv.com> <20220701094041.43e5d16c@hermes.local> In-Reply-To: <20220701094041.43e5d16c@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=fcb78b34-7bde-4283-baf5-e7665c378dad; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-07-02T08:36:27Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c0446ec-1b11-40d0-9619-08da5c110176 x-ms-traffictypediagnostic: PH0PR21MB1328:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J3GMxEClqKHNajy8AXWUJUUup+uiOxE10poGB9P4VHcfhjKtJZTFoId0qJ7Zd8M/NfzXrusd0xZTC/HcVTxw1T33DrP3K7vlur5l3R4I2CQiKCs+HP5Dp5g3jvzgmnQ5rpz+GPD4I8+my7RGLfEq+cwkajZiehegs2ab0rW2s4B+/IcxoVg/5PiFs+AW5Evu9uNji0oWU0fJN+/Z7krg31XuvdRP6E0V43v/seD6oDQxNotERhqUmJuEDEUclOpB52dBynwV3wrcbDgbgJlxEld0Z71QbS7npHetRqIUJ9b3VVEP1eFW8NKwaPGBhvO0hc4wwAt90s/lMbhcjw0Y4kR6vIA6ts9AfFHUPyOn9wvH8Nso3/9rKfgEeIXUw3cArg1O132KJt6XhbfhJK4koGjPidz5jiRjGvW7xxmw9UX0UMWmyUmxWiF65Jn8SE/Hr5R2L6sQ20fvGRx3MgpIG2QM2maxXf6GKD1JZ5ug3DO1ZU9tEQY+UEo8rcYdE9OqeMIJwBWx8gTsegjBtBL9ssaEYnlC4Qjc+Y+DLY44gQo93bKqUGppZvA2jKztQ4Ui8+BiJt9ea8uSFPpV/iHM+Xvcx+5ga8gjJ+A3f1gW1gfSsmQvrfNbpx0ek9buT3i6rVyK5mlRuZ9n2A2IIz1+XxDo9e2XvgZ+A/OjMDyEXwrj8aLKTaK/ZBaYhOdCiM3do0lwEwcTzSOViYkoMcM6QMbPhDPhH7N9UVgjzL/zIqL8v6fHwBC3bzA16fz7dh9Es1Lc1WziPYJPPMw2Vr3MmBj0TYJdjJ3g/3TiyhHV6pRQiaL8v+jlVVKBR8I2DKhvnbrtQ+U6RHX/gR/AuDnjjbCFcxEHlUmS3uUmtAQwiSU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199009)(110136005)(10290500003)(5660300002)(316002)(54906003)(2906002)(33656002)(4744005)(8936002)(86362001)(52536014)(82960400001)(66946007)(82950400001)(64756008)(122000001)(76116006)(38100700002)(4326008)(66556008)(66446008)(8990500004)(66476007)(55016003)(8676002)(186003)(478600001)(7696005)(26005)(6506007)(9686003)(41300700001)(71200400001)(38070700005)(6666004)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MTIZvLMdsrpIQxjWboGesUXr7xWe8ccfr+Hv4X/MR33xx/OiLcTt3dkAlx/Y?= =?us-ascii?Q?x5Lm8D9OoPW0vFIn4ETV0wH6FBcwYyvD246Bt7ag6o4zkQP4RCELsUloHDYI?= =?us-ascii?Q?m4/J0aktTmEpm69bld7twCoF37M+N8uUj7ioNXqgTyjbfebw51S+8kVlcFu6?= =?us-ascii?Q?JlrSRr7Izb264AdZ1h5aC3/XG9lKjVq70zgLTMVKCSZVu2EOnaL7dCTfHpYE?= =?us-ascii?Q?slaRFeZ3MrL0e3rjDL982Vt9y2Msgy3yj5+GX00Av+bo1IA6ex3CC5sSGHNT?= =?us-ascii?Q?NHOVzxNHvrydTiPCtWN1lvZ5mz+upSwI1UZ8SRKBT1IhO5Wi/kRHJeYHgetF?= =?us-ascii?Q?fChfcf+cIE2sc1qb4/6MmVF7rtAqJJfotryfVKArS+pXPORUsM73tMPGtVLh?= =?us-ascii?Q?O/xHJU3mPoEeSUY69TwFP6G6XDFf3MgsVw3VgkeVoHK250x8xhDbVLWIElTX?= =?us-ascii?Q?HGjgvm/4PJ3GkYFVdSycDA0LPG0ZpZFeV4UqnwNUYpangCYzee9Sw5+2NXnT?= =?us-ascii?Q?WqhgcCsZVBIeRPNR7SzTf5NJ7JJFo0gHLNIlyDMVA9QbKtearKl4KFmaZNeo?= =?us-ascii?Q?VuDcfZoC58fCPiIoOJGGp+BRosc7wG0skqXsEqd/r6BfMx4/IL3fW0IeislD?= =?us-ascii?Q?HjOrGlw/hEIJGXyihbkHWYDLxEWLwwGfVbZJByS084brj0J7fCTr4UotFc5L?= =?us-ascii?Q?R12Tt/+bqzZ2L9JH7HFt6JW40+7RqI5iYTacdrc6pmf+ANUeTjwrKrHNY7Jo?= =?us-ascii?Q?RTlnjohc9Rc0C6h8x4L0Z2881UG/h6iO+eoRF53KUt8RU1v0okHzC/qqTPaN?= =?us-ascii?Q?2/PeZYEfay6vSpE3JdY1ZUsOeYD55CuVyJRxvQn8omp0zlhWEJ9jR+zDQtvM?= =?us-ascii?Q?XY4ZhzvhrsI0tGvkJ3EfhaCUKO0e9Ri9EnmJ7sz7Lqfneb1uVddO9RIzVY0d?= =?us-ascii?Q?ZHvT2ZJrYAp4MBV3/NzFSufrbY0emCrmzKI0sIztB7zEAjNSb5TK2tJ/V3D1?= =?us-ascii?Q?AlOurSF0gqCxSon3P38SfdWseevqwkDhJAJ9BoOrGY8NMztYn9NIxsb+QmxD?= =?us-ascii?Q?19BE+/i9K2S4rL3xsY9brnTVEElNtJ+9ajzK1z9MSUUY7X1qN69mNtuqxb7l?= =?us-ascii?Q?XCyRZYQn3ltBLV9iW/tUQmq9BrNpGmfZGk/Od+gxRDZbuT7c0EAf8hxTU3Na?= =?us-ascii?Q?FOtOYFa/hUr9vQsOxmktgvGkCaK+yfOppV+YukU5XMNcdo7Uo2uAi9ZAMMRx?= =?us-ascii?Q?NZYESay0cr70gsRPR46qmtRiTJmEg0XEH2z2nyC72z0Ag3px3AFYaHKhFogG?= =?us-ascii?Q?5QjCVhnwkCTISseDQlVlrf1nrYfi/RmJ5+w6pIIvKcidX5hzocyizDbmjU0V?= =?us-ascii?Q?Xq68KUh4y+ccp8nKLC6UUzkUdTWVTvW6Saqli+CGD6xB8dhTMCHmuy/4Aid/?= =?us-ascii?Q?jTxQoH30K1kZWoU3PvOIXMMvH0SpuZi7pMzEbsUPVanbr7W0HAqFTk+4qwLM?= =?us-ascii?Q?JumMgbAapdVeDroG6ajX3dzhblEYn6K/owUPT1slHrt1ZmX7LEMj8MHuNC1J?= =?us-ascii?Q?CW8naKHpvdgHjthHh4I56P/Rsx2IFpYDvXctNkPx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c0446ec-1b11-40d0-9619-08da5c110176 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2022 08:42:54.2411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f/5kGUPUIac5NROuh8kCfyjv9YecW//R+PmdOjQpyGGaC9zitbGSyc7Ln9ivrJZFzwhJ4lF5yzNFHRNy9kLhfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR21MB1328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [PATCH 13/17] net/mana: add function to start/stop RX queues >=20 > On Fri, 1 Jul 2022 02:02:43 -0700 > longli@linuxonhyperv.com wrote: >=20 > > + > > +static uint8_t > mana_rss_hash_key_default[TOEPLITZ_HASH_KEY_SIZE_IN_BYTES] =3D { > > + 0x2c, 0xc6, 0x81, 0xd1, > > + 0x5b, 0xdb, 0xf4, 0xf7, > > + 0xfc, 0xa2, 0x83, 0x19, > > + 0xdb, 0x1a, 0x3e, 0x94, > > + 0x6b, 0x9e, 0x38, 0xd9, > > + 0x2c, 0x9c, 0x03, 0xd1, > > + 0xad, 0x99, 0x44, 0xa7, > > + 0xd9, 0x56, 0x3d, 0x59, > > + 0x06, 0x3c, 0x25, 0xf3, > > + 0xfc, 0x1f, 0xdc, 0x2a, > > +}; > > + >=20 > Is this constant? I found it awkward defining it as const. Later, the code uses ".rx_hash_key =3D mana_rss_hash_key_default" to assign= this to the IB verb interface. rx_hash_key is of type uint8_t * (non const= ). I'm yet to find a way to do this assignment without the compiler complainin= g about convert const pointer to pointer.