From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9F3EA0542; Tue, 4 Oct 2022 21:37:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D43940DFB; Tue, 4 Oct 2022 21:37:27 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-eastusazon11020016.outbound.protection.outlook.com [52.101.51.16]) by mails.dpdk.org (Postfix) with ESMTP id 8841B40DDC for <dev@dpdk.org>; Tue, 4 Oct 2022 21:37:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aG/9oYYG9SaxFVJRe/Fhrfez7U+xmhXy7+bZlF/0OrMwnxlislzgevbIexWKGduf7c+0Zp8PEkwFiSrj+9D2SncqYQnZ1GOAc4OPPpW7LdBkUyz6Jzk4Md0T1qqY8wrT/bBLuA1s2rvod9EA6UMllaGsQYOpDetFeYnW8RBdeKwoXseeF1/O2zoi686gLROCxcPAvne2THEA7QIJZmczLJLhxzuCbsbVYe+5uiTEVj31fV4SVggam1VjBasPihXP9S/9syYMleF4MKWQ0JET/y6rfK4sajml0Qazts4w9m6aiEGlH/p3C+Y9Dd41gujgAeU30ZgayEyeWQvPBRoK1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rf7EsKv+N1KV6SUNuWG7+fHlleViEwWqP9d2UZWur3M=; b=KZdMXGCmPsfzZFSRMChhiq8KKSoELkWzMdDWlFEut4+oOXlJWaLWBThKuHKlZfzezZOKPywG1rENQKuLd8+NsJC5YGmCTzflo52HJZ/C9HW2qiHuJAfSXGsrG56agPYB9Ub52rkppyRDMSAHPphZFoTVdtxlUiaUypDuU8LrLLW2mEESQkvo+5yN0qHo4wsYhotWhHJxlCDSEa1ronTyRg4veIxaXJGj/8hOu4RZv83Lzw8iCW4Wpd4vy5SWBvbv1mjmHJZLrae/UAI4ULD/l1MZtCYIsW1I7QF+1HHPLwptqpF0YAq2kTK7gF6LBnvVSksxe1ojeYs5wZcF+7POCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rf7EsKv+N1KV6SUNuWG7+fHlleViEwWqP9d2UZWur3M=; b=dUtI69FZhDfng7r5ELlt/Rk4bQQkuTOTcWaCfe0DQPh4bpjGpGCR0PolR/oK5rTSowrZU6up//xxkCyoHct0jjpQM5rQO8AlgbZfOAwFeRM9NwFo3g0Ij1qCDieAbDFv5rKUiWi9xlDMRklYQ2J/pBGJdTRcCo9X+qOThhsADhI= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by DM6PR21MB1401.namprd21.prod.outlook.com (2603:10b6:5:22d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.8; Tue, 4 Oct 2022 19:37:24 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::e19e:c7cf:1bf0:1a75]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::e19e:c7cf:1bf0:1a75%7]) with mapi id 15.20.5723.009; Tue, 4 Oct 2022 19:37:23 +0000 From: Long Li <longli@microsoft.com> To: Ferruh Yigit <ferruh.yigit@amd.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Ajay Sharma <sharmaajay@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com> Subject: RE: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Thread-Topic: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Thread-Index: AQHYz7/E3E5SC3TF0kuezRUBXWxUfa3+lFIAgAAdfmA= Date: Tue, 4 Oct 2022 19:37:23 +0000 Message-ID: <PH7PR21MB32636454B77F15F8BCC7C003CE5A9@PH7PR21MB3263.namprd21.prod.outlook.com> References: <1662674189-29524-1-git-send-email-longli@linuxonhyperv.com> <1663987546-15982-1-git-send-email-longli@linuxonhyperv.com> <09656c03-8c4f-6550-dc7a-6b70568e798c@amd.com> In-Reply-To: <09656c03-8c4f-6550-dc7a-6b70568e798c@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=431d4f2d-78e6-42ac-9740-e34e12e853c3; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-10-04T19:36:53Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|DM6PR21MB1401:EE_ x-ms-office365-filtering-correlation-id: d9276dd9-c31c-46e9-fb02-08daa63fdc6e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GTDr4mOJYVnhoKrmVogLas1RlRQ73mfGWSS1S5DANQ9n6jVMmZZHcAZIj6ZXN1GJBmZjLPHJT7GBsrdNiLvlni6KLQb3fq133tIvX4lkEW69Q5pNcw7I/2/U8QT/FmFWT964RjVnP0Paud4OKpJhh9dAsDuP+MsG0hGZr5f92qekii6LZZgskHnr3eLqIx3VYK/x0r2Um8BM2W2mp01p9iptMzOXZq2l9t6Ie+kBRXQwpl008upDD6s4ITGZ8YLprtxOq55HprR8ewQZ4QK3MT7ri4R5jfMXyOt7jxm3MsUm1qP5nyFPMvTQsYY38aNdmxjHFkRfIoJ5dTogJApuBhn+cGnLowW2vtk0sDDGzdX64l0jkXKq61zLe5KPUDY3zPLYUi16EttNkbzGHeWFWuUtmz0I02kcSCbeaA9rY8g3UkDXjCWAAQM8gcagmqUzJmqVRKexazE6NQnFtmALVMP4iTlx/U5MznBA5zY2JXvWX/pnaugPsW6VibAW2tji1jUrAbkpFWJRE8CAR/DckAOjdfMpBOWziZMQqS1yrK0OhhYW0vj0zBZJ31XnTATNiO8yg1CF3klpIGVexof7WV2Md1dXTtbNdFdN+olfsecMGXNM6Oh50KhW5hcs4hqSPF2SNLOVdFir0Zb+SZx8hlpIIDMOgstiqJOKiS/psx3tnNyiah7vsbNRtLd2b1oS02mHF3/z5egDz0X3aNVepcAnIFL8/k6cDq+7fWL5i0m+MbwGmGXFrXecrXEbyTK6X9eqWPgtxSo6q8G1Jjl+DUnzHmr1WZG7DzVswacEHteyyL5AhmDrv31NhB/kXixJlDHeehsllLWfSDFs0Uk1jfqv7kbg5e3em+jnyWhpYp8u/BfppQ1WqqfVixv9etpA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(47530400004)(451199015)(38100700002)(122000001)(82950400001)(33656002)(82960400001)(38070700005)(86362001)(6506007)(8936002)(71200400001)(55016003)(8676002)(5660300002)(4326008)(7696005)(53546011)(9686003)(26005)(478600001)(66556008)(316002)(6916009)(966005)(64756008)(66446008)(54906003)(76116006)(66946007)(66476007)(2906002)(83380400001)(107886003)(10290500003)(52536014)(186003)(8990500004)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2ERpqDtVDOa4wFZnlKXHS+Fi7S+oOJ3TscFaFfvSzAbGmz5NSDRMRyK5yp4K?= =?us-ascii?Q?H0CjzLblZ81XXPBMbtVzWHe3Fy68iLoF++hAcuo10fy1dcFWEESzlhW0tbEs?= =?us-ascii?Q?SQgG1mL5nj9c25Fc165tjsQGhbruIJIwWA20W14ShWu9LtT5b2iOZKIdUlWJ?= =?us-ascii?Q?QVAyMHVsQRFLVZ/UcoDy4oN4HWqjyvONlAPBs14zENwqJBp3z4rjjDvGjACc?= =?us-ascii?Q?zt2dPGxJEyFs3qtCzGCrq2j7D4t7XMSKo3IsAM7MZLHiqf5rw/jBP0qSTZL+?= =?us-ascii?Q?QcmtyqUR78W3PQNdKlxCViuSE1QdnjvEMroVTpV1T7V+J8/zq3fjjBI48H67?= =?us-ascii?Q?OYLuqBf2j8SpmEtQSluWsawSN4ZumIODo5s+SM9CS+QIz3DBzdnmhEXaP47c?= =?us-ascii?Q?KSPpdgdNQFiiJLwa00HihKqKwDeTmR6HFiOmciMCAiDWM35Ql56pLeRkHe57?= =?us-ascii?Q?xn3Avp4aS1CNoq/FZRbgdGGKaFvsuwb6WOdrs85JkcAyizJy6R6058ekylkt?= =?us-ascii?Q?XD5//EHJvDMKwtK0RIDvq3cBuZLaSczc6X41qCckEKJ7Uwt4jQUXX0YPsl5a?= =?us-ascii?Q?oyuw+B43XhGATROsTGb3NqF4Ai3hAlOWXPMdcTY+BjxJhXOJN/Rthy+xNb6r?= =?us-ascii?Q?tMY3u8TegVeeiwdm+ayMPNYsxxx2MIOWLHlBcRKYKD19URLsNuGO55xedd7K?= =?us-ascii?Q?77I+F/cRkbCCSKGz1DEqADfml3qFUeqXF+26X354hWm9xQCwwyAWRAtZEnHt?= =?us-ascii?Q?zYr4DFnRpWcz0VMGoNo+vSID0JmAV44VZodWtw7ksuBs4PXH8DXJRGjV+8b4?= =?us-ascii?Q?hSiGU2XWReavSb6WAvwAOu2zDVsO+F9AygYJptlIrsiCT7WIrPfVeVdmVGFK?= =?us-ascii?Q?LCYu9qg9jeK9/C0U5zbW30AR8zXbMv0oqFZgWXNbTTy4cy2qOlMKTBebAfJW?= =?us-ascii?Q?is4eSBcDy3cfQEebBGzK5TrJ4//N20vQPJABkm0UIfYUg/bmg1DQxvCXj9gO?= =?us-ascii?Q?Z4QTw4eg23wnXYTdR/XyteivDjJA3of2i3GDHgnCxRWNe4+lvx9DFKcIU2gQ?= =?us-ascii?Q?PT9o+KP3OqSH9IwQ2ohpdiifjVvestZrlkVVzocHECkg0QN60+yxx++Lnxcr?= =?us-ascii?Q?n5WNDqi5n3Fl4fAw2GzgkKAGUVWRR1bTdKdtpETjtWPJx7K58WdeNW1okQ2b?= =?us-ascii?Q?z+AptGNW+ho1VdaD0lCh0fuzdi9CcdmT7LWoFymlO1/YDE9u2Bg9lx5arMyT?= =?us-ascii?Q?QpwD1+cNlQLmA2aG/E25kMjL555SeBScYwTUeyFpRpp3+tG1g0srOmVVa6cF?= =?us-ascii?Q?nlOeuihb/C1A7IJxyAaKLl0VogQJXiqSvID9QWjf1nW9jIl6F0yeBnmQey9L?= =?us-ascii?Q?8d4ofw8/yG0N81rTavBZviB7fX2c9ng2uH83YKpVbCHlgGfKJAMeRGUzKK4A?= =?us-ascii?Q?rAwQwcUgLeiJTboGW72RM3RZDeID/oPar8eSwp41tqdYqBUsMjXUZAtl36rB?= =?us-ascii?Q?9+RSvZtgkpoGqkYq+WHwKe58DIFWIRZ9nVaV56O+SIy4AvQWYTRV5pN8LJe/?= =?us-ascii?Q?UbLAnAp07GEOlEj8nFPbRkEFHvRUvVGqpS2HblmN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9276dd9-c31c-46e9-fb02-08daa63fdc6e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 19:37:23.7444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n+x2guBu9e1LGAAjftjEdjY3WyZzK8ZxcjDvX/PyINWcj4KLLmINKR7wsYRdM09U93RLc4s9e9MKB2nj/JpKZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1401 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > Subject: Re: [Patch v9 00/18] Introduce Microsoft Azure Network Adatper > (MANA) PMD >=20 > On 9/24/2022 3:45 AM, longli@linuxonhyperv.com wrote: >=20 > > > > From: Long Li <longli@microsoft.com> > > > > MANA is a network interface card to be used in the Azure cloud > environment. > > MANA provides safe access to user memory through memory registration. > > It has IOMMU built into the hardware. > > > > MANA uses IB verbs and RDMA layer to configure hardware resources. It > > requires the corresponding RDMA kernel-mode and user-mode drivers. > > > > The MANA RDMA kernel-mode driver is being reviewed at: > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatc > > > hwork.kernel.org%2Fproject%2Fnetdevbpf%2Flist%2F%3Fseries%3D678843 > %26s > > > tate%3D*&data=3D05%7C01%7Clongli%40microsoft.com%7Ccfd942f49229 > 4bbc3 > > > 5f208daa63110f7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6380 > 05026 > > > 942011972%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > oiV2luMzIi > > > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DDnuV > 1co%2F7ir > > 0MtjAlV17aDr9MyswVos8vcoOJfRpIxg%3D&reserved=3D0 > > > > The MANA RDMA user-mode driver is being reviewed at: > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > > ub.com%2Flinux-rdma%2Frdma- > core%2Fpull%2F1177&data=3D05%7C01%7Clongl > > > i%40microsoft.com%7Ccfd942f492294bbc35f208daa63110f7%7C72f988bf86f1 > 41a > > > f91ab2d7cd011db47%7C1%7C0%7C638005026942051727%7CUnknown%7CT > WFpbGZsb3d > > > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > 3D%7C > > > 3000%7C%7C%7C&sdata=3DCgggHkL2gGJmhNeZ4Bi5mZJPZC76pR7o8bB% > 2BKT6qcvY% > > 3D&reserved=3D0 > > > > > > Long Li (18): > > net/mana: add basic driver with build environment and doc > > net/mana: device configuration and stop > > net/mana: report supported ptypes > > net/mana: support link update > > net/mana: support device removal interrupts > > net/mana: report device info > > net/mana: configure RSS > > net/mana: configure Rx queues > > net/mana: configure Tx queues > > net/mana: implement memory registration > > net/mana: implement the hardware layer operations > > net/mana: start/stop Tx queues > > net/mana: start/stop Rx queues > > net/mana: receive packets > > net/mana: send packets > > net/mana: start/stop device > > net/mana: report queue stats > > net/mana: support Rx interrupts > > >=20 > Hi Long, >=20 > Driver looks good, only I put a few minor comments, can you please check > them? >=20 > Thanks, > ferruh Hi Ferruh, I will send v10 to address all the comments. Thanks, Long