From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4AAFA0551; Wed, 7 Sep 2022 03:43:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FA50400D6; Wed, 7 Sep 2022 03:43:56 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (unknown [52.101.56.26]) by mails.dpdk.org (Postfix) with ESMTP id AC87440042 for ; Wed, 7 Sep 2022 03:43:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/cBNTQiqcA72I/ylh/jLVIs7O5wibyMt/3TUXHAEa3eb+0dVq5Er72ukN+0SLcTrp5QELXW4aQC+XF6sj0a1ZDFK+IU8BHXQ0qpw4I640glHGWcDTwXTqSkXMr+oXn62E63Rdk4xrlphyCxx4HeCdVjGDyMfAtaCzNqHBfopM7R3M4DiAAts3FBX2VykIN1+MbGI78R1laRwVEs78AHmOxZ9zqjUYpN9Nhi2nrJbsuPiuyiuuCr1I7w+7is7U2J5WhHhqvm1LL191E1esOaCCZpTVNXLWU81HgUTd+2LQq2ESMAfPYvvW4dOuw8IfDdQnQlR6ukrIyKf2c957f1qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ORrb4unZ46U9A3uOXCBH+/hq+PRgfCS4GItfQsxuy8=; b=nxtW4tzFJOGfF5ngcVskMpEzXjbkmVrS8syFf9zsrz2FTksKwiB6cFIahQhlnoZBxqhONMJfZnnEgxuet6TAfZx2tJS1elsfrf3Zl6yS9JejRO0dnnjRKxYoLvFdC+KjxhkI2sxx6dBAsjTHLqbyvg4sqFfurU5GqMduoIvrm0FKeBUWHtI1jxUoMYLsOw5w3kwIEKFGgBFxr6EFppcPopCmRXoF//hitMfUFFenQh1xlgvpVKO1L7W7MWFXhTT7otVIW+H4leoMcoJcbyaEgC1ZpSSTghuYgr4aeSDmhaylyO7TJkwhN1O4phSnH/53CNG0QIXuEpPgSUAxGc6Z+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ORrb4unZ46U9A3uOXCBH+/hq+PRgfCS4GItfQsxuy8=; b=TgTz93VVG6NJnwiBQrlzJ13tkY1ZLpeQbviK5JsjGUudoEniIkQ9r+/JTmWvOhH67DKoheVoyVKtiy8XjMQeLoJo3WiZHgf49NGdDzqXnMJId2pCR3m/AGFTRw6Cib8uRzibjBC3YUALaUIdMMt42uCVEOe17DJMHy5X5jdbkzQ= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by SA0PR21MB1946.namprd21.prod.outlook.com (2603:10b6:806:e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.4; Wed, 7 Sep 2022 01:43:53 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac%8]) with mapi id 15.20.5632.002; Wed, 7 Sep 2022 01:43:53 +0000 From: Long Li To: Ferruh Yigit CC: "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Topic: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Index: AQHYvzZA189idMIQUU+0ipuUZahvta3SYymAgADUrgA= Date: Wed, 7 Sep 2022 01:43:53 +0000 Message-ID: References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> In-Reply-To: <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|SA0PR21MB1946:EE_ x-ms-office365-filtering-correlation-id: 2d6ff915-5604-4c9c-2785-08da90726bd6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XHOFRDqxvzoZjTCNTN86IWHI2DO4LgRIJVH8Px91s77fJ7sF+dvY1/AnqomC7E0ZI1XdmbmituIMVS5HSeqaiEZ43aGfOBRK2bNFXff3dlw3xEErVFBBdmjs76MF6s2cf+lcXRE/YISttfOzSNnvBIUlFx/LYt3DobjHjAioCQBNuJuc3kVhZ9vlUhNwOO9419d1vxuwjtLRsQLgFh0kF19Am4xUJtZHCMM75CIQMxCMbTYxnVmRuLweevtUeQ95mDN477ljJMoZ48fySvVZM/UPi0wRgsKPVSDl7B0fMQ3NUW3cfEwDdkHfkutCc9OjlvyOXSu87CcUEJ3uZ9eqhV692JEeVXCAFlUPH8CbR2T/HIKNrRAYfMTMFRtUVTkpxF1JB4k2ims052Lb6doBe27Dd6ywrevfzRgc7XobeWV2i8xi7YO4ge5jBtLRYfHbl8/fWByUkmppCi74MPggEILoTr1/Lq7hcaboX1xnB+PZ+BtNbelqNoqIJ55INcffG6SCLVq3kfKzEH8MnABGXTaxCkK642pyk+gkZl9cRHruJ2TNhPRSNJ3HSGVP04DOB94WFCjUMGMkR1MkqM/SDy1SIBegZsLU8HvCcsAkmN28U9rABkYsXNjBXOPBrGZlXYx4dEMcoZ6w9U/2ebx1QVf23dAKLbxTm0waUYSYPSWnQPqvsNlhMbeyI8sYVhRRdl5rwoYCTxn9KZ4knguLKsQlslnPgXXfTChHaCaeiee+C+i35mPOS5G+rR62KB1u4lnM9osWUx9rG2/dmZRBDmKIRa2Gi5S03Qz0q/vJHZNGsdaV5wXDjC31jwvMxV0mMBtWWyoMEuow+MnzP0pQ2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199009)(107886003)(66446008)(66556008)(4326008)(53546011)(64756008)(76116006)(66476007)(82960400001)(82950400001)(8676002)(10290500003)(966005)(38070700005)(478600001)(86362001)(66946007)(6916009)(316002)(54906003)(7696005)(9686003)(6506007)(26005)(55016003)(71200400001)(41300700001)(83380400001)(122000001)(8990500004)(2906002)(186003)(8936002)(52536014)(38100700002)(5660300002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4nfMOcG73x4rHC0vpCH4oujvmZ5eTC3TgLzqnDRAsArgzZ242afzOR97T0f3?= =?us-ascii?Q?es0KfXlzFITwZDDgDlIDbMVccO2YBeeJT/9NnyGNkERjHNAFgk6IChEQtyZi?= =?us-ascii?Q?u0eYACXK5dedNbFYDj713npZyVafqk8Ji00E/1ZqEglLxoBSnIMqnL6BI5Qi?= =?us-ascii?Q?f4evMniq4ZxnU9A/aiL6Xs6CkWkJ05YqD6NIYwq824COo1SN3HpxpBofZNQu?= =?us-ascii?Q?d6IAFA/m28sFlmCYXBgvwm85v8TgSoqdR9rEK+rgNdDBAZX/h7AlBSb4H8h4?= =?us-ascii?Q?zuWAWNffSJRr35fXX4NtmPAAvA7SNcjnMQ95k1QYpVaxcZJ9pZN8/oFVl77W?= =?us-ascii?Q?eUcLq1Z4hncst/Vf1Y/+WaPN8izXstE0scnEDIHUCMqa8/GJgfj9OmT1JZO/?= =?us-ascii?Q?6oEjx1QrYcc4dkcc7EfRQrDyyQPY247PGAbUpD87lrVATDzNWGV8YrkXpK1g?= =?us-ascii?Q?BvBUkqSJVg6AU7m7C3QiudxXsv89wXsFRx/jOfsjKU6XLJQsKOb3U27gy3b+?= =?us-ascii?Q?47LJcyshceNkGVsFYZaC7At4jj3UvryXrfFkt06uJJOh+rCCx7Y8K9oWB0q+?= =?us-ascii?Q?s/gV1MZ1KDWzyLAXrODPQc6xiMqcEBCzFRMhN7GkrHgzSovgAV+Qm07YV2k4?= =?us-ascii?Q?YaX6NtsVxLncRGd6TtmcI8ZFXI1595hxe3MbSkgh1YLuAJcPwacDdrDlxFJ8?= =?us-ascii?Q?Y+weCs9CvazyYngW8d1EBccvdjcnARZcm9lnHnSzCNhLp75lrQ8fpu2KOwzA?= =?us-ascii?Q?8bC5l003YPzkCl4vWnvfK8GAA91sNAbbaMgDgf3BPvOPb3jl9jwwXkozOBxc?= =?us-ascii?Q?x2jUpmkNV/WPQ42yZIqYpEXhczOzCmeGQQynv/Cb+7lFnpYtDRYWfJSPi9Ua?= =?us-ascii?Q?md6G7bMiKzWQ1AqszNsrIkCwtKxKthyZ/N+3tgQDoY8NHv5ON4fx7DfZJH4S?= =?us-ascii?Q?ubxA00mTWWeLx9LRXrMpeFIXfIB9hksZcNHLLeJTIIxUa6Gaj07qmeH4wUIX?= =?us-ascii?Q?REDgJKPjcb9hrX8Fcu1rz5i77Zh5+y4gRsTIpXOzTySLQP9BH4P02QW2M6dz?= =?us-ascii?Q?73B4zxO1eJvG3FzUR+jvroC6EvFJvSh5T/K2Wj1djB/Ci4lOQsqN3h6VbXOP?= =?us-ascii?Q?xoWZ7QDdaP1az7nbp8LtvX+arlHxZrd5Rii4ydaNDrFICAx7+zJ3muYmUs0i?= =?us-ascii?Q?LOWUZMUl8fSkscJfCltWgw8aN1DNKjGdOIsf5XwEUlafoW9Jeziv+PQia4sG?= =?us-ascii?Q?nMMtTERNFSRQME2FdS0opNdy5jWA+8mY8PqCHtDnK3Pk9mKWdFq+epzUbfgT?= =?us-ascii?Q?8JcoMHV1VCTqeX9BK4pdpul418bnc7lSw0xgZygTyRqwUYXIui7wG6+dcGYI?= =?us-ascii?Q?kaGmxNJK5xuNmKOxhN9XLbouBtikh558rXAP2uKfodenYquCqS5dx7OSNMBN?= =?us-ascii?Q?C/3PSImHHwaPOYN8G1/j6/zHS3bE5SGanWhPCIzLzmJzTmvcax7CnPDT5qnR?= =?us-ascii?Q?HuV+i9WvQiOStLkJuPt6c7Rofgfp5lCIASwxhcIlgj2zgS9yT2VZXtoLVdll?= =?us-ascii?Q?qRCZBsG6S/DTLdYqgYY2XuDHCA6OndhyPQfzdiQX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1946 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environme= nt > and doc >=20 > On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: >=20 > > > > From: Long Li > > > > MANA is a PCI device. It uses IB verbs to access hardware through the > > kernel RDMA layer. This patch introduces build environment and basic > > device probe functions. > > > > Signed-off-by: Long Li > > --- > > Change log: > > v2: > > Fix typos. > > Make the driver build only on x86-64 and Linux. > > Remove unused header files. > > Change port definition to uint16_t or uint8_t (for IB). > > Use getline() in place of fgets() to read and truncate a line. > > v3: > > Add meson build check for required functions from RDMA direct verb > > header file > > v4: > > Remove extra "\n" in logging code. > > Use "r" in place of "rb" in fopen() to read text files. > > v7: > > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > > >=20 > Can you please check review comments on v4 [1], they seem still valid in = this > version. > I didn't go through other patches, but can you please double check > comments on all v4 patches? Sorry it was an oversight. Will remove all the "\n" and double check. >=20 >=20 > [1] > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Finbo > x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- > 0852317b4a72%40xilinx.com%2F&data=3D05%7C01%7Clongli%40microsoft > .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab2d7c > d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3 > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000%7C%7C%7C&sdata=3D4CHI9uw%2B0MwJtVjamECVZWvUYq > BCitq7STstFNPNIN8%3D&reserved=3D0