From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8901743AAE; Fri, 9 Feb 2024 19:48:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E1884067A; Fri, 9 Feb 2024 19:48:15 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11020002.outbound.protection.outlook.com [40.93.193.2]) by mails.dpdk.org (Postfix) with ESMTP id 3ADE5402AF for ; Fri, 9 Feb 2024 19:48:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKEjxrgVF06Ych2XJa1LxYzGFlAwtVfoPaybMHe7VRGJvvyK8n4bOQpg874/EcafrIE9TMiM8y3geflbDH3geG8cQWI29LXJPbJNzJpCy2o6FqgiN7srHQw2K1g1+dzS2MqzDRs8VyAj54Op2fpeKCLgWWRabpolnmN0e9S65yd00Kl+UM/aOu5Yte2r6gXHEkPl1eRj9KNBvs6gXIhgQLPuGysPOrtIBMSJ941uaKDXcAq6meePp8ZK9xkE/kk1AslP7Dx49MYZeeOYKrYfdFEZXmUlHnNFMS706WP2yBzrC5iD7kN1MY5Lzqpof2gj/OsAdtmbd1xQLcfptIRyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=psENL3J2DrDqxNkmJy1Qqm+ZqMKJY1L63YjGVxuNhKM=; b=A8MBhLBr8e6exlOn6B61kjtabmLYb8VXu08NIxPb9H0gxBuR2l1PGvusVisK8nSWbWt5oFRUKIH9M3/8j93tYMCOy2GzbzAQUHimBaQh9IolmkGIPFz4NkGqIPE7D+EO/JAisUlfVFrRBGmNJ9CcvFCKsll0ps3NNUxzA6XMHDb24oCFGDAaLL+1MBEt8sGPkH7rirwvuP0O8XqB2amGzYlnQvk0nzKFZpJoFhCCoOukEaJ4i4EbKg4vjyx5cWDUDWABibTfF56Kvu/1QymoZn75qHEBnJpY3mHRTRDqmlX+jc78Q/nuFD1S4b/NEeCXfejDebztloQm/k70Hd1jSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=psENL3J2DrDqxNkmJy1Qqm+ZqMKJY1L63YjGVxuNhKM=; b=J1277G6/gzMoFhVj9vaAj+K1nc96ITOuj5DGIDu83Inmhm4xMAaQfh2tCS0BSFhaW7nUYT1wmuEAuLwI3L/zx2A74xanEIN+BGRmBqsOiHb8dKprTlT9LzNdq+Um39G0ObddKfXkfdhlVWniLrYOwfNem8rig3oiYzFHdPF96hE= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by DM6PR21MB1530.namprd21.prod.outlook.com (2603:10b6:5:256::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.10; Fri, 9 Feb 2024 18:48:11 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::38ce:7072:976c:bb15%3]) with mapi id 15.20.7292.001; Fri, 9 Feb 2024 18:48:11 +0000 From: Long Li To: Wei Hu , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Thomas Monjalon , Alan Elder CC: "dev@dpdk.org" Subject: RE: [PATCH 1/1] net/mana: add vlan tagging support Thread-Topic: [PATCH 1/1] net/mana: add vlan tagging support Thread-Index: AQHaWzVsRdX2QKTKSUeXYcBkUz9Hk7ECWF0Q Date: Fri, 9 Feb 2024 18:48:11 +0000 Message-ID: References: <20240209085211.2643148-1-weh@microsoft.com> In-Reply-To: <20240209085211.2643148-1-weh@microsoft.com> Accept-Language: en-US Content-Language: en-US X-Mentions: alan.elder@microsoft.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=2acdfd2d-4532-4882-b975-76beea55277b; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-09T18:40:02Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|DM6PR21MB1530:EE_ x-ms-office365-filtering-correlation-id: f2987889-5e67-46e4-cf76-08dc299faa4f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TQ7IPaD40sKY5U+EjKaRlI9veXJjqrOvdzUL1muyDpSbU7hJUQDJB80J/1fnhZcCEARPshdMEiYo4gRaByJv7a6yPpe3pwVAg9WOpb/L/wkUCv6mHF4U0rQKr/yR9/LUA66+oq5IP83oxrwyvmQFDPoeli+e0Ro3/tS0Ffro1AbP80bXIy8qpCWh+zPNxwXnxfCessXXUzD0pA6nFNEbV6eCGv6YYlHBY0Q+3pxrU/hGKhqVdzkwWUbAIoBcgr/Thbf2TpUFB2OlMCKKOCr+3TG92imhGkRDQirR4luDTs3l3THwuuv36Sb/PJqq4Sqf4XwDuIVccok82c1staTX8LvVpaQnkqam+nR80IWa+AhkLqADvQRCD6mG4q8QXbtgnuXZzB9FjwErVVPZdUmlIwCpRifEyTG4QfED259MxKPi9EpCwXzIfeuMaA8dzI2SVv0PtqZ9D4Fl0PfXxTvURumi94Z1hgMHKdn44o0kHCVuy+AOVSx3Bdff3JRSx5lI1ukxwSslxLCYhsO5VWfT4WgeQFnqbLrkSgqkdDJj3Z2WmU/Kr0HnU9HQiCZuIEXLFqLquKO3zhxMzrzYhoJHZROufS7EkTL+F61UQvdSIWRvgGYz/Lws2aLA4GNqjpi6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(346002)(136003)(366004)(376002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(7696005)(71200400001)(55016003)(8990500004)(2906002)(110136005)(5660300002)(41300700001)(66899024)(52536014)(316002)(9686003)(66556008)(66446008)(66946007)(66476007)(76116006)(6506007)(8676002)(478600001)(8936002)(64756008)(6636002)(10290500003)(38070700009)(86362001)(4326008)(82950400001)(38100700002)(82960400001)(122000001)(26005)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j1dToNonpqT/Y671lM6tzKpcBtJwcmyWgUNEJwXOtgKgJrzWjb71lXTq75k/?= =?us-ascii?Q?vRmjbQ34INC5SohOyeFkS3yUfPEWWGVW8wrZjP7QC/LBMxkjl2kFf4b+VK0g?= =?us-ascii?Q?04M4GlzmDVCXtYRgVaBcjjVgDr48paQVnRUO7ugp2ZIr6It+mCaesZrDh0/Z?= =?us-ascii?Q?gab5qc1TeenWG853o1Je76PLs/PfwTS16sw/D60Z/stxaqaOsv4V7PAMXa+r?= =?us-ascii?Q?FjN4Soj5TKjTghTKtrPESmak/4xK/85QESgW/I55hSGBVqnj6lExgL9fVGUr?= =?us-ascii?Q?/LwV82yrIsbQG5bJb2GEqD/Lu4h7umJoDC2amgjY/Rhf06ED8X+ncw3hkk26?= =?us-ascii?Q?IOpyRxoiXLF+beBVuDFGCPNzPimWNDaWi0YlCzXl+Nu+NJLG7MbbXi2dH5pZ?= =?us-ascii?Q?OeJu9r7zk9UOfeaIto4bOX380/Oqv5vngz0aTr4DW3AuTVbMfsaFKYiGtkKj?= =?us-ascii?Q?AnZgN3rnlPMNcN0o/o3XtnTnu04WyqJYEsF8vHekYk5xOuUh6c54JdGISofh?= =?us-ascii?Q?z4ppPv3bHxR20Nq/ufNRksUccg5bQYgt1xspaZ4Eta/ntERUkT9ciXfBkGeQ?= =?us-ascii?Q?An5PATzoI3lzUVxRHXJpX5hxr+u1bVMU/VV5wRUT58DhNo1zSuyl9GQ2Ga/b?= =?us-ascii?Q?PX/x9jv2qaTrpw5S8jW1k0BSUyHL6oGRo24ky4ItnT4TvvmDlO3a8ggH3ws/?= =?us-ascii?Q?ps4+F9k6wkpzAy2MDc02zG+SjuE4nCAKS6aC5vHLZk7s/6fgoZ6bUcJ/AofF?= =?us-ascii?Q?4E86zYLhgw/XhEf0pk1svIjc/DRodKHarbWJFpq6mmjqn0YXXDhiQE0plnpE?= =?us-ascii?Q?4O/fRJ7wZm36JsIS8UCJFuw9UlnITYm5TjCEA8/UF4g+PFpdu14IjLFph9m/?= =?us-ascii?Q?hXE5CN3JQeKcXqU1gg5z6U+WukO0VRVTyCQStse6+aU09E7PhVdATrUPtXI5?= =?us-ascii?Q?AAo0newXX/EpOYm5ePzdQn96pJ+1eYVYPLexmewN0Qr0iJ4INXkwV6KnXPvw?= =?us-ascii?Q?NycQg5H8ZMrQBt1xqW5mMXuW1Xt2cJKZ7s/mCVTTLyJv9dsy7hR3KBAiFit7?= =?us-ascii?Q?ZULUknFRpGFJk+V0+W/QxHOmaM9LCgp0cTt7NkOJFdKmq97dE4dT5ua+VEiq?= =?us-ascii?Q?y5BE/av47Tx+zZBAvJcebINNZXRp/pM9fk5LvC7aZaItWNUI2eGnNo/8Fc2y?= =?us-ascii?Q?aiVBmjzyAGIZ4erj1XMOcuD3iSPktiReGM4F8XIjagTy+xrszO0AqNqdlVnf?= =?us-ascii?Q?SsfMGgnRQVGKUaZ6fplwdqIoN1SFl/tOw2tHFnk4UG3bhq80pBECqDvJU27q?= =?us-ascii?Q?juv6BJQIJHdqPaj3SP45nBdHRbiwnJIHKDjbFL/KGXlnJokEYgI4jLYTbOL9?= =?us-ascii?Q?t2FP6lt07HnW2A+3Xe9Lej8RB1Io1qKuHndZfsULHPpLxPYfWVrCtKcv849a?= =?us-ascii?Q?oVmK7pTNkAX1qGg5FZGzFn36fG20vbGrve2FwC4FccMEjroCwoymCSPqtrlF?= =?us-ascii?Q?zIhQhhWmE3r9bvRnRo5DusTQUG18rMtoaB7myR930tC1GTczAINeIgFqu/+Z?= =?us-ascii?Q?9RmEiJd7Fl6KZ2mGlhrLSarSGnT5e1mf/54ireUU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3263.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2987889-5e67-46e4-cf76-08dc299faa4f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 18:48:11.3617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dobU6qPuRTuHfbp4BnHV1jhpzGtF1MNEV15Kp8MgseDdDWLwwaqIxDpI071t++Phex8PR+y+Lvo78oCd2P5qqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1530 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > + if (oob->rx_vlan_tag_present) { > + mbuf->ol_flags |=3D > + RTE_MBUF_F_RX_VLAN | > RTE_MBUF_F_RX_VLAN_STRIPPED; > + mbuf->vlan_tci =3D oob->rx_vlan_id; > + } > + Netvsc has the following code for dealing with vlan on RX mbufs (in hn_rxtx= .c): /* NDIS always strips tag, put it back if necessary */ if (!hv->vlan_strip && rte_vlan_insert(&m)) { It seems we should do the same? > pkts[pkt_received++] =3D mbuf; > rxq->stats.packets++; > rxq->stats.bytes +=3D mbuf->data_len; > diff --git a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c index > 58c4a1d976..f075fcb0f5 100644 > --- a/drivers/net/mana/tx.c > +++ b/drivers/net/mana/tx.c > @@ -180,6 +180,15 @@ get_vsq_frame_num(uint32_t vsq) > return v.vsq_frame; > } >=20 > +#define VLAN_PRIO_MASK 0xe000 /* Priority Code Point */ > +#define VLAN_PRIO_SHIFT 13 > +#define VLAN_CFI_MASK 0x1000 /* Canonical Format Indicator > / Drop Eligible Indicator */ > +#define VLAN_VID_MASK 0x0fff /* VLAN Identifier */ > + > +#define mana_mbuf_vlan_tag_get_id(m) ((m)->vlan_tci & > VLAN_VID_MASK) > +#define mana_mbuf_vlan_tag_get_cfi(m) (!!((m)->vlan_tci & > VLAN_CFI_MASK)) > +#define mana_mbuf_vlan_tag_get_prio(m) (((m)->vlan_tci & > VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT) > + Those definitions look like those in @Alan Elder's patch for netvsc. Can we= consolidate some of those definitions into a common place?=20 Maybe in "lib/net/rte_ether.h"? Thanks, Long