From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 761FAA0542; Wed, 7 Sep 2022 04:41:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDE8D40F19; Wed, 7 Sep 2022 04:41:22 +0200 (CEST) Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021014.outbound.protection.outlook.com [52.101.62.14]) by mails.dpdk.org (Postfix) with ESMTP id 395A3400D6 for <dev@dpdk.org>; Wed, 7 Sep 2022 04:41:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=boSnYruQ6HUk9l67o0+8qzORMpnBmZMIfuDB4hEU3pRtaRlBoHTdsnFV/v2I35G19Yu2LonRz8OLi7Aylu4t3kq6iZtVQ1KBf3HEBe5AIctbIYCzDiULdtnfrVoa+s9nHpSJK7sLucy7qTvKf4cnu7XLX4bX5WKguTHEncu5JGcJMhVNgPwM+QdLZ+jZNzivJLzmuQmFixxkRMQZC1VNJD5zkFUo87ABpmOxWRLJMf0hAnaQ6UQPkZpm50i/DcUV8vMpWCf0pYhmA/EtJSgDhoHhg1Uxs5xeGtlWi5r/irFPZNe0VkqDJuH6eulS58poeXO4bN/Wr8qttm9Yv/RiBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmhVNXAvIrZHmgUZUL8h0siooJby3/syrKWjK8NgGig=; b=KmjfiQnTx1XgvL58gGs8Nz4K/KQOndyUS9P0Sse3+LfG3CzNmGeai3PxBtv3WWVpJzmlA36/w9jWt5Df0XlMDV8KD16jj70vc6QM/hWYXjxeGwjqvgXmcykuHAsBakbdF0Rmgum/MBMc8PqWVjgje81GhQR/Hd3AGSqWXXy8xFe+bK2mUO3+L9S4tltwnzS9DqRByC8frJK9bgw8elX2wvfpyEK87OYbOmHBdmeawiWvd8CTsMdGnuzMX0Dg4FmnrH3JfGrRX3F6f056Wb7OMZHWyI+Zw6gwkAgliv0pNp5VcF2aR3ymCpVp7TnksoenNbDnqnJ+saXyKclTMJC2Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmhVNXAvIrZHmgUZUL8h0siooJby3/syrKWjK8NgGig=; b=V0fg92jngd4WUCN76zCVC3Vla7F8TRBHnsmpbT3jOuTTNkLp3HtCT88y9brQMGM/Za7nwxJU0FutVABVrOnc66+mrAQsL5vNk07Wfh5Ln1LoFnprAFEbUz72L47skNNiOuNN+uRMsPtS7llZBnBb4HN579BIoTJHYDITsMUOdoY= Received: from PH7PR21MB3263.namprd21.prod.outlook.com (2603:10b6:510:1db::16) by BY5PR21MB1522.namprd21.prod.outlook.com (2603:10b6:a03:231::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.9; Wed, 7 Sep 2022 02:41:18 +0000 Received: from PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac]) by PH7PR21MB3263.namprd21.prod.outlook.com ([fe80::c42c:5004:23c1:bcac%8]) with mapi id 15.20.5632.002; Wed, 7 Sep 2022 02:41:18 +0000 From: Long Li <longli@microsoft.com> To: Long Li <longli@microsoft.com>, Ferruh Yigit <ferruh.yigit@xilinx.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Ajay Sharma <sharmaajay@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com> Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Topic: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Thread-Index: AQHYvzZA189idMIQUU+0ipuUZahvta3SYymAgADUrgCAAA+KkA== Date: Wed, 7 Sep 2022 02:41:18 +0000 Message-ID: <PH7PR21MB3263EFBA6B4D014F0FF2231BCE419@PH7PR21MB3263.namprd21.prod.outlook.com> References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> <PH7PR21MB32638370820D346D68C2D067CE419@PH7PR21MB3263.namprd21.prod.outlook.com> In-Reply-To: <PH7PR21MB32638370820D346D68C2D067CE419@PH7PR21MB3263.namprd21.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR21MB3263:EE_|BY5PR21MB1522:EE_ x-ms-office365-filtering-correlation-id: 7183a30e-e254-4d31-1f92-08da907a70f3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: puIiVEH0E6UuxdoP1atXFK7Md1DxStCzOX7gDnEPazvlxQXFRe57OKOYFs3WWn9/xNYhGutj1oth67O5Qb/hHc4MVpTdNLVYqJhBq3MqDorPoUH8eUEAL+DkNWhClkP6bvsM+yP7tSWdDKCGbfDUAsuGm/XuGZPgeYtFEyzUMNX/VbZIpO8yL4Hq3pDS1Hp6dPWGklA6ZfQU7lcbxmB01z8etWWuOiH0RjI+q8hQJ0Wf28yyNlnliW9V3ExttWscu/KMjUgFj8IGWutnUAkHVP3EpAxZpukGTbBsryJun0BiNMZ+mtW1yfCg0bp6QlOgIXA+bFM7MFC+UIzbHklZijjz+7DWWndjNrO6XYxs9aP6vULjd/IyrUTcrhU6Y0GS0bIu/XCXUmPQn3mMyJcOkwWt7tHmlddEobIpTB9ofxtzL9nt5XnMV417Gh0Z1QQhTB9Ys2sLNbMvXC6GBFQRZ1gxJZO5ki+Kxh6+dF23XsO2aRKHbHi2hRgZ+/USK146ndDMU3TsLmaGeTzgEd9BrJEqkLH64ziiWmwIU8ccMcADrna0CA0+sO4SEmS8oaTk+QUYwuBNS61YFD5OjoxCKqbuWJ/VhLSEeWW+X6khqOBimAhwA2TjewVJEGFQMv4cTVsHRmjFPQ7cD+oYsEcMVPN/KifUcV54RrVqULS/FJLux/QH2e2jXxD/AM1ECI76x62ii7VJfwAfS/RlLEllu5A9SL9hCoE3153XnaXJdRivBZK7f4r3/lZI5R7EvkAdgqvVNx5V5OL0n9y8IGkV/7nPebOvBwCPr6sTiXeCSYqUOzS46id0meB2efdOE3iEWsBiPjjDRQ2ircR39twp5Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3263.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199009)(6506007)(38070700005)(82960400001)(122000001)(38100700002)(10290500003)(110136005)(8676002)(4326008)(66446008)(66556008)(316002)(64756008)(66476007)(76116006)(82950400001)(66946007)(54906003)(83380400001)(5660300002)(2906002)(8990500004)(52536014)(9686003)(26005)(2940100002)(8936002)(55016003)(53546011)(186003)(966005)(478600001)(107886003)(7696005)(41300700001)(71200400001)(86362001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZQ1qJC8kTnazaujNHtUyHwtyFQMXPbNbhOS8qC+xQkgg7MRUT2txkUkWEoN/?= =?us-ascii?Q?TgxkPhSdexLe/tWLScqeGdUxLIMZp3deeKA1+mXFSDkpXXKLfwrhTuA2PFWO?= =?us-ascii?Q?nPmdleQEM8JwNDfU4gFiT4JZITjjnbsk1/Y7jIp5JqVrfyxLbMMii8gYaPc0?= =?us-ascii?Q?VDERb0JZR7qqgD89KBDjl1m58inw5P7Bq9/MW2EqM/Axa1zEgEC6Rh7Rno8R?= =?us-ascii?Q?eL+AcyxyAjK2u59SpJ8+1sdRXxOz0SyytHqkWUeJZHbC1AgZhQ2IOLsiFdSs?= =?us-ascii?Q?YcSALydyqiafwpfG7gbcYgF97HQorengetAYn+cW0gfOOV1hjcbSEmv8jY90?= =?us-ascii?Q?gDFoWJFmVgXdL8DFVX+riMbHOcKTsdgsrouIYm2F6Agx8Z0QNaH3sZBNdvk+?= =?us-ascii?Q?zupiVIsTr+SpZac11QTMNMUXtWjX1RG9VEoIzcor3Dc74Yf32sug5oCtg8/A?= =?us-ascii?Q?RuBcSR5V4FyKGcQ7DlT6Vx4WkiWYWVjRCR1xW7X0+ui8K2+VScDY5YnoaRaM?= =?us-ascii?Q?e+nSzTMuIsudXBIHeIiW11I0vh92lq7IDIMiJNg/FuAqWit9yHsNWwsfivkg?= =?us-ascii?Q?f6QXDPvbAV2QSVYLzKjfYxdi/mhwZaQ854yJdWRAl8BlCmJNnySVTYkEYtuR?= =?us-ascii?Q?oKbfhyxeLYCjYKCELDzhpHyp8lg4uavVEqZU7BkMy/8jgNY4UttPAAhdwJhK?= =?us-ascii?Q?Tax6BQZZBE5i/UfBwHEEJwiuM6oIY3+s2Fwxd9cKxOhlHWprty/qUoSjrWr+?= =?us-ascii?Q?0AkTgD6PVVYp/wrGijMtXfbJdvnr7xi/aX8ci2l+NwZkBmku0Bdp1gkBJZFR?= =?us-ascii?Q?w/MzL7HgxyL9GfyAAImzfuJziWdWMPD+W0WnrYrivhkKzYEghnQxVJiQ6enQ?= =?us-ascii?Q?hk7YpPdP8UlA+zPb/oyv1ubkbxtoiSeicT9mGugzBGiV7+euW8frLM7SuCHi?= =?us-ascii?Q?ldnZBBIA52gNTiqK8XUqbK+AdrgfTnOu7cl5GzNwL/O29ItSXSj86WvEZruW?= =?us-ascii?Q?NrulP7Vebjn3lHCifyTTkt1X4p+8bTb1+c2n3bqq5x8SJrir8rjjTdCx2xsn?= =?us-ascii?Q?QcHku1XraOkm/cJ9YnTdyLMf7aB3B2EstyzzO3jnJOGcRKDM5vexqhJvo/Va?= =?us-ascii?Q?exKszv4vfAoYk2f7pq6YL0D2rpYhGMFqDGKWC47CIX3PoOQG1RAXUZ2sqLqT?= =?us-ascii?Q?6BIrtjoc40EhTO1eI2Z84yIBdU1xJsVOnXfaQkkoWkJmGuKpbjAXlPtB5FpK?= =?us-ascii?Q?+0GQbeY6f0R7izbKqHq2DedM2XJpesXRuwU8yDH0i3kNBgj1WcGcA36ynY2j?= =?us-ascii?Q?lofGMniCOsHLqPzo7zQM+wEQ448ALcVo6J7aOVmXDSaKKctkwg2Jl/hun7t1?= =?us-ascii?Q?aOY3VETHcjtLYqstQUBaWEOVRXRd3W8MBmHwuT++5rMwsodEMP4+DjJDdiwy?= =?us-ascii?Q?GjbjummuPEGpaU/PoMTAtnVKe6EGcZw+orFZkl7IffunhJNBYBf1+Cq2WJ6z?= =?us-ascii?Q?LGSMbgk+/7rth3v/kPDA3c8CoVZ5g7TSnHqN7wZGod7BsZ5KUcdeEpdvMwDB?= =?us-ascii?Q?QkTBQYVL18SI45sWrl86xVazdr6lFYvhxN1kAfLF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR21MB1522 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environme= nt > and doc >=20 > > Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build > > environment and doc > > > > On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: > > > > > > > > From: Long Li <longli@microsoft.com> > > > > > > MANA is a PCI device. It uses IB verbs to access hardware through > > > the kernel RDMA layer. This patch introduces build environment and > > > basic device probe functions. > > > > > > Signed-off-by: Long Li <longli@microsoft.com> > > > --- > > > Change log: > > > v2: > > > Fix typos. > > > Make the driver build only on x86-64 and Linux. > > > Remove unused header files. > > > Change port definition to uint16_t or uint8_t (for IB). > > > Use getline() in place of fgets() to read and truncate a line. > > > v3: > > > Add meson build check for required functions from RDMA direct verb > > > header file > > > v4: > > > Remove extra "\n" in logging code. > > > Use "r" in place of "rb" in fopen() to read text files. > > > v7: > > > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > > > > > > > Can you please check review comments on v4 [1], they seem still valid > > in this version. > > I didn't go through other patches, but can you please double check > > comments on all v4 patches? >=20 > Sorry it was an oversight. Will remove all the "\n" and double check. Are you referring to " Remove extra "\n" in logging code." In the comment? There are two places "\n" are used, DRV_LOG() and PMD_INIT_LOG() in mana.h.= I think they are okay as there is a single "\n" on each output line. Please let me know if I missed anything. >=20 > > > > > > [1] > > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Finbo > > x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa- > > > 0852317b4a72%40xilinx.com%2F&data=3D05%7C01%7Clongli%40microsoft > > .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab2d > 7c > > > d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3 > > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C3000%7C%7C%7C&sdata=3D4CHI9uw%2B0MwJtVjamECVZWvU > Yq > > BCitq7STstFNPNIN8%3D&reserved=3D0