DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Chengwen Feng <fengchengwen@huawei.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "wangchenxingyu@huawei.com" <wangchenxingyu@huawei.com>,
	"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>
Subject: Re: [PATCH] examples/eventdev: fix segment fault with generic pipeline
Date: Thu, 1 Aug 2024 12:43:55 +0000	[thread overview]
Message-ID: <PH8PR11MB6803836AD11FF619F5B36117D7B22@PH8PR11MB6803.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240801111120.5380-1-fengchengwen@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 2856 bytes --]

> From: Chengwen Feng <fengchengwen@huawei.com>
> Sent: Thursday, August 1, 2024 12:11 PM
> To: thomas@monjalon.net <thomas@monjalon.net>; dev@dpdk.org <dev@dpdk.org>
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; wangchenxingyu@huawei.com <wangchenxingyu@huawei.com>
> Subject: [PATCH] examples/eventdev: fix segment fault with generic pipeline
>
> There was a segmentation fault when executing eventdev_pipeline with
> command [1] with ConnectX-5 NIC card:
>
> 0x000000000079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev.h:6636
> txa_service_tx (txa=0x17b19d080, ev=0xffffffffe500, n=4) at ../lib/eventdev/rte_event_eth_tx_adapter.c:631
> 0x0000000000792234 in txa_service_func (args=0x17b19d080) at ../lib/eventdev/rte_event_eth_tx_adapter.c:666
> 0x00000000008b0784 in service_runner_do_callback (s=0x17fffe100, cs=0x17ffb5f80, service_idx=2) at ../lib/eal/common/rte_service.c:405
> 0x00000000008b0ad8 in service_run (i=2, cs=0x17ffb5f80, service_mask=18446744073709551615, s=0x17fffe100, serialize_mt_unsafe=0)
>     at ../lib/eal/common/rte_service.c:441
> 0x00000000008b0c68 in rte_service_run_iter_on_app_lcore (id=2, serialize_mt_unsafe=0) at ../lib/eal/common/rte_service.c:477
> 0x000000000057bcc4 in schedule_devices (lcore_id=0) at ../examples/eventdev_pipeline/pipeline_common.h:138
> 0x000000000057ca94 in worker_generic_burst (arg=0x17b131e80) at ../examples/eventdev_pipeline/pipeline_worker_generic.c:83
> 0x00000000005794a8 in main (argc=11, argv=0xfffffffff470) at ../examples/eventdev_pipeline/main.c:449
>
> The root cause is that the queue_id (11) is invalid, the queue_id comes
> from mbuf.hash.txadapter.txq which may pre-write by NIC driver when
> receiving packets (e.g. pre-write mbuf.hash.fdir.hi field).

Good bug report, thanks for the detailed info on hash.fdir.hi union-ed with txadapter fields.
I don't have the specific HW to test, so code review only.

I don't recall the TXQ quantities etc (been a number of years since I worked on this code...!)
so I'll +CC Pavan who reworked the logic around generic workers & eventdev stages, and might recall?

> Because this example only enabled one ethdev queue, so fixes it by reset
> txq to zero in the first worker stage.
>
> [1] dpdk-eventdev_pipeline -l 0-48 --vdev event_sw0 -- -r1 -t1 -e1 -w ff0 -s5 -n0 -c32 -W1000 -D
> When launch eventdev_pipeline with command [1],  event_sw
>
> Fixes: 81fb40f95c82 ("examples/eventdev: add generic worker pipeline")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Reported-by: Chenxingyu Wang <wangchenxingyu@huawei.com>

Generally the change looks fine - I'll wait a few days for Pavan's input, and otherwise review & Ack assuming no issues found.

Thanks for the patch! -Harry

[-- Attachment #2: Type: text/html, Size: 7825 bytes --]

  reply	other threads:[~2024-08-01 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 11:11 Chengwen Feng
2024-08-01 12:43 ` Van Haaren, Harry [this message]
2024-08-18  8:34   ` Pavan Nikhilesh Bhagavatula
2024-09-17 15:50 ` Jerin Jacob
2024-09-18  6:43   ` fengchengwen
2024-09-18  6:41 ` [PATCH v2] " Chengwen Feng
2024-09-19 16:00   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH8PR11MB6803836AD11FF619F5B36117D7B22@PH8PR11MB6803.namprd11.prod.outlook.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=pbhagavatula@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=wangchenxingyu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).