From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6022745AA0;
Thu, 3 Oct 2024 17:50:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A6FD24064C;
Thu, 3 Oct 2024 17:50:38 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16])
by mails.dpdk.org (Postfix) with ESMTP id C795B4014F;
Thu, 3 Oct 2024 17:50:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1727970636; x=1759506636;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:mime-version;
bh=WVrTuqLkdj7WkdrNvUR2nEH2X5b548EKCe4oDH1bovs=;
b=Vqk05ZP5QMy4qQUPXwmt5mTnFtn+TKSaa6jKqYmgC/Sw7rpkouYtQKmY
CkgJvfcXqBpJUVugYgdJ5cOOPa0d97SpMDNLrQw5nXfqZHcx4lhoAR8jU
rkLZVHop6mOalr/jJQEgnX9Q9EM6qpsxtPbLNyH/tApHOtaesYAlgca2m
tbZ98ewcC0l2LpADQpiwEXOir2pz6zn5cBvJVCWJrl2LmDJ8NaFkaWUVR
Gw0hUiVHlXnat23cXfThz9O/C/g5gZwXExccbK6bjRwf5kDRYk4P7KcN9
7tpM5ZQl99CHGaZbwhlIt3tAR+VPkhx6xPx0MDuUwj/xnLn3+jmsXmnKZ A==;
X-CSE-ConnectionGUID: rgGVjGAtSmy1vLOwZs+dlg==
X-CSE-MsgGUID: SA0HHrKRQEG7HVll73XEOg==
X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="14792210"
X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208,217";a="14792210"
Received: from fmviesa009.fm.intel.com ([10.60.135.149])
by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
03 Oct 2024 08:50:33 -0700
X-CSE-ConnectionGUID: SYDGNXbWQI2CVgm27A+Egg==
X-CSE-MsgGUID: uG7T5Er4Qi2B0aBDv9eBWA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208,217";a="74380429"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
03 Oct 2024 08:50:32 -0700
Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39; Thu, 3 Oct 2024 08:50:32 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39; Thu, 3 Oct 2024 08:50:31 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39 via Frontend Transport; Thu, 3 Oct 2024 08:50:31 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Thu, 3 Oct 2024 08:50:31 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=E+eHddaSP4R2MGxfc2n5H+IWhtaNacWB0Bhw0i7KRZhl3517SS+8AuOPANO5C1H9qAywC6wCav33cX6BAcResRs3J8AQnZAhTe3g+NF27w1hglXxVRmCspwF/pijgDrzcpJE/e1QDjuttYvc2MHSUROOzoES7EbBZaEyUMY/PwkSYdwrJTPciWuH1OaxEPEbByd1eO75Myruxpnmo5q456MOnB4mhM2ug1TaGF0fKWtqC4yS00XS+5RghYuydvgM4sZ81vwJvL8r7oZO4txo7+3psgdUmt/6wKvwtZi89u2COEEKA6SBSLciR1g5I7p6n8VOIx/bXr3tfLeen4cZBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=TcnYb88GKODJAKbC2AhTL+lXmLKtEtiLAZdMJ5X7+t4=;
b=l7T7/eQmJ0VoGDDS18qQbY92AAf90LeZImAgLOoMNrUHx+NL9DZzkxeITvjXscbxmbl2iT1M6Hc7D6T8s5yWnYEvN7l9dwVR5wgKOFJLU2uHF8dIUdtQUYo6uF0g2qPPojr+pZLEXQbUS3oAaC5RiUXy/CwXgZjst5uvbEcbsRlbvLlLJgSjwCfDmQU3rU2pDEE2ZTiQtQ7PMW1rgCAwYktXgwEwE++NA6r66/qMYQsPbYDb6INO26VbyDYSjizQdc7zLitNgIdV70rtSB7pJLTHrWmnU2zmGyVlW9vG/DcG7pdCa3mVO76r/nLQJer7meUaCV5XjIV7vHsJgLRkig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from PH8PR11MB6803.namprd11.prod.outlook.com (2603:10b6:510:1cb::12)
by DS7PR11MB6039.namprd11.prod.outlook.com (2603:10b6:8:76::6) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8026.16; Thu, 3 Oct 2024 15:50:28 +0000
Received: from PH8PR11MB6803.namprd11.prod.outlook.com
([fe80::8680:ff9f:997:18b4]) by PH8PR11MB6803.namprd11.prod.outlook.com
([fe80::8680:ff9f:997:18b4%3]) with mapi id 15.20.8026.017; Thu, 3 Oct 2024
15:50:27 +0000
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Marchand, David" <david.marchand@redhat.com>,
=?iso-8859-1?Q?Mattias_R=F6nnblom?= <mattias.ronnblom@ericsson.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org"
<stephen@networkplumber.org>, "suanmingm@nvidia.com" <suanmingm@nvidia.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, "stable@dpdk.org"
<stable@dpdk.org>, Tyler Retzlaff <roretzla@linux.microsoft.com>, "Aaron
Conole" <aconole@redhat.com>
Subject: Re: [PATCH v2] service: fix deadlock on worker lcore exit
Thread-Topic: [PATCH v2] service: fix deadlock on worker lcore exit
Thread-Index: AQHbFWGL0DvrcFcT0UmmBUIeTZwXibJ0vl6AgABkIho=
Date: Thu, 3 Oct 2024 15:50:27 +0000
Message-ID: <PH8PR11MB6803B474AE398A725C2A3583D7712@PH8PR11MB6803.namprd11.prod.outlook.com>
References: <20241001162603.793853-1-mattias.ronnblom@ericsson.com>
<20241003065702.3051158-1-david.marchand@redhat.com>
<CAJFAV8zgd_EJwbshjAWNMe4m2s=btu+6cY9ToA0vmudz89svaw@mail.gmail.com>
In-Reply-To: <CAJFAV8zgd_EJwbshjAWNMe4m2s=btu+6cY9ToA0vmudz89svaw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH8PR11MB6803:EE_|DS7PR11MB6039:EE_
x-ms-office365-filtering-correlation-id: 719ff63b-6082-4ea6-5d58-08dce3c31a4a
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018;
x-microsoft-antispam-message-info: =?iso-8859-1?Q?Bnye2y52fXea04pRgtq/cK+L+P92Mfu4kFf6nP5Lco76G6px8FulIVp6Lf?=
=?iso-8859-1?Q?49K3suon4tDzp3sC3MQ2iG4tQclUefnJltOPU2D+yrFvHDUqa+8SqWuZAs?=
=?iso-8859-1?Q?mpsofOqwRh2+BWdgRdYRyo+hWl5mUhSjjk3ltp4pX86eGhkw0YPZDFv/DH?=
=?iso-8859-1?Q?OFIDiazpNMNZTk2kdi15QrXB3ATOvpU74yUuuOTMaLEkUf/8eUaO83b5b4?=
=?iso-8859-1?Q?tj6k7xTRTVbaO4+YkzgEgtoYEZFXvXSCrFpRWvmbUb5HSE2a9NvAijqqA7?=
=?iso-8859-1?Q?rHEuahKdpPVs13E26vmGmpBeoqtWP+selSYA1R8s+b1IIXnObMtYVP6Tmp?=
=?iso-8859-1?Q?ODE0sISZU4nnSSiXCIBCwVSs+TO4k+JRE+WeJ1OI42v+uGuNVwHcIqc2fQ?=
=?iso-8859-1?Q?iPIrSOOGTgYc8w8fRN9neoisRI1IaZfzP6e2jSYkD+jK2fv5sqp1qEes2x?=
=?iso-8859-1?Q?1mtRVKa1wfD246scvESwXUGEMp6r9iKfiVIi46m86cnp066PzZzwj6uMJi?=
=?iso-8859-1?Q?yEfafFl5dGLl3twZA9/hc28Ro9Bg47O+K/i0u3ogt0QTi87o0I3g6WrQws?=
=?iso-8859-1?Q?xSkdMaHEFTaOhCm2LQxdkEemUqaGvhOFLj6hcdv8ce2QOQGxUsnHMrmBaH?=
=?iso-8859-1?Q?G5uaDvaZjLKtsHFDxkkRpGq/YqXtNZePzcCMTUk/4C5OJGkxnDwXXfZz9/?=
=?iso-8859-1?Q?Zh/O5e0yB2uCTQQVesWvO+mUVrH7jFIa0Dad/ojPaZCbevm8XkBj9RFEoB?=
=?iso-8859-1?Q?Qxv5AFYcpn1+zV8BYAFeCD8OX4XxQzEZE96x6HIe57kRIWOtpi9YZrHvBw?=
=?iso-8859-1?Q?I6ax70yG09h+d067dpBW4ZNVIR9g+rJ6Eh+MXRfn3Q2mzv+fWqSev6F2el?=
=?iso-8859-1?Q?cVTO/PG6W14fpq5m85aG7S18U82WlYE8BvC8CjzTGURdluJEs5s2sCmtIY?=
=?iso-8859-1?Q?zzoHmOMC35IQoILpuTZRzewFSJsqfOhzH0OBBLNi2k/ipOMolVB1kJYkm+?=
=?iso-8859-1?Q?XpcKVmNFdXYUAQmcnQr/68n/644bMrDl6jU+8Ii+OOk7yQM+jf1TFH54lc?=
=?iso-8859-1?Q?zPY+OM+MzhOCNduZyRqz5bsVVvU1KCrpZQWKMOA+6S7hqvo9AVYkBxAX3F?=
=?iso-8859-1?Q?RNzpcr8hhVagoPWIQEqBVStWdOVpags0O1CE4wRxTAEDgvG4XilezAmVmc?=
=?iso-8859-1?Q?ANvRiuoxLXuuILSGyEDNVdlBwHD7AP9bS5SzkuCURcGbr6kUz67AW+loEZ?=
=?iso-8859-1?Q?0KYYUtewTPrUjywrSiMdGnPLDoUK3chyfEEhfR5mDsnNKGYrvelWTxAqPy?=
=?iso-8859-1?Q?ED2LUa9ZeMmHUxt61nH8FpXE7mCkK7ND5Kuf4XBf4OhPqsdxgEGF7Byr37?=
=?iso-8859-1?Q?SIDn+37pb6EILnCWZeqLGilay9b1pF7w=3D=3D?=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH8PR11MB6803.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nxZYZIdrYL7hpagMSA91aaq4mNI3CaGqKxP1DuRS9YW5RrVuBx5kXhKZlY?=
=?iso-8859-1?Q?nRIg2oH3nMl8M8fJpLU5vMeBrUncWjAxpA5cZocw5Xv0U4o/09ZSVgeQBF?=
=?iso-8859-1?Q?WcDOjQeyBH95rzmPKnQ5DKVrSd2Mzknu0DG7pgP8qDiJtnDdNVpIdX7xPY?=
=?iso-8859-1?Q?3DUrAvIDTVpaDC+AQ+5SHD51rNwgxwCy6aiYr9VUkDfeqLFYxZWepp+ngh?=
=?iso-8859-1?Q?ZmpxQVnt9R7XgF93pxR+wFqXopUbOEysO3SMF20lmtpPBAEVnDH6bmsrzO?=
=?iso-8859-1?Q?nRFBo7kM84hY6Oa5oznHx8wVqEv8/ieiUfFZ2dWT3yJ1My/g8D2iSrXhdK?=
=?iso-8859-1?Q?2pLCt5YaiE/6Qxw7pVPpQu9Vb6m6M3n0roxxiV7WeG06/x/jSTwBpk4Fop?=
=?iso-8859-1?Q?bKfVRuzq9xpSMrdFRtXMaiDytFJca5fEdgW0B3CTeCTnWvPf53KBr4tRsK?=
=?iso-8859-1?Q?TkRAxA4mvkUCfbytIHM9aKF39bH+BTBmiA3xbgv68ScWSHmT7dLjbmVW4N?=
=?iso-8859-1?Q?FGtqBh8cXBfFYXWO8Flf9zvjHa1w8CsMIb005G4JV/70Ra5qp8ZuQOQrXm?=
=?iso-8859-1?Q?qblaOSVvIoH/iwx3Bd5yY8ZHqrsuBZP1ywYPQmGTG5SYvgC1N6WlDVjo5d?=
=?iso-8859-1?Q?lKQ0+Hfv4F+uH1Bmhtbia91jPJTU2vIYQUJ4Lf2s/jdNOUciImanIuASGP?=
=?iso-8859-1?Q?sBPfCnGHRLdVBgGBXnuveOaQf9Jjqu4qBOjoB7n3g6zSwT3XQTN6oI9YtM?=
=?iso-8859-1?Q?ePOhAMqlIHl7D5vYGfPkE9SbyIx+F1f4NHTb8qY+JosOHZgXd08UZg597B?=
=?iso-8859-1?Q?Bkj/55ZxDYir8M4FaI5SdWRDfQOElfVwxv5UI9K3VoXTNszME6erhuEgPU?=
=?iso-8859-1?Q?SR3zTnxoyfwA0iS6fwnXl/O0cMKXoxlq5jbPQS9GzyUmyfTkNQdKgCY2mK?=
=?iso-8859-1?Q?LBKgiqay06atS/L377o+6jhaR9rMLawamx+6OIHhwoqpK/ghcI6+zS63bk?=
=?iso-8859-1?Q?SD1IsJT3hXn1Qkz09SjarxA3TZ1JPgsz4hH63C4rbxIc2OXdeUEW4tJg8A?=
=?iso-8859-1?Q?QrxwOTfOgoy6ijQJCUI7qovJSKQsWZK4cJMfHmfdIBriyBBIBgqkREvoIY?=
=?iso-8859-1?Q?sFwLUJpP6g7KnFitRTMxH1lGvQmftPXmgYVZ0dvg3XJsDBIpQhbjmz4j8J?=
=?iso-8859-1?Q?q93h4mtltg06BU7fsoogTkAjcdXdLmiczZ6io93IOMDSS1tVqYHGRQFRPU?=
=?iso-8859-1?Q?S1Ntwae+DI8GhMvpsa8ENumaV2sydx5NmUAw8DYQOJbnk2tz6jvwXnwjUI?=
=?iso-8859-1?Q?sh390QAQX8sbNo9YHGIXcgYbIj38ExphBYawI7y6FkkY5CUYa74ESzwYiH?=
=?iso-8859-1?Q?9RpT8AhOGs6oHFrgduKl8q6lW6SDxGjH50+8RbUIYK//PP3cNSBnA5lcI+?=
=?iso-8859-1?Q?+AxM/p3BMKdENJ7ItzSBlQ5b0E7M5B8FrMOu0SR2SAdbRFhONQQx9CkVpk?=
=?iso-8859-1?Q?cPMxrmPinhrRm+xWVIrQ0eyxIcMVQET5AocCqgiaCxqAagyPdciPoEKui1?=
=?iso-8859-1?Q?RpM4Y+32me7fMDqqGOqIPw/F3BQ01d5gno/2Thlu4gcou1+1kVsHzqAAht?=
=?iso-8859-1?Q?A5P6//gMo+SUgXzkPeacXKRL4ptF9QLxgb?=
Content-Type: multipart/alternative;
boundary="_000_PH8PR11MB6803B474AE398A725C2A3583D7712PH8PR11MB6803namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6803.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 719ff63b-6082-4ea6-5d58-08dce3c31a4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2024 15:50:27.8580 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oy8sKU1jGV9b/ulxBQRFIvS56bEjmJSg4geZyVzmoyFgZwB0f+k871XrgZeZ8cjhFF+YCEKVSq1aaqG9ArFVyI+OJxwjetkd486V/rZxgNo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6039
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
--_000_PH8PR11MB6803B474AE398A725C2A3583D7712PH8PR11MB6803namp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, October 3, 2024 10:13 AM
> To: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>; Van Haaren, Harry=
<harry.van.haaren@intel.com>
> Cc: dev@dpdk.org <dev@dpdk.org>; stephen@networkplumber.org <stephen@netw=
orkplumber.org>; suanmingm@nvidia.com <suanmingm@nvidia.com>; thomas@monjal=
on.net <thomas@monjalon.net>; stable@dpdk.org <stable@dpdk.org>; Tyler Retz=
laff <roretzla@linux.microsoft.com>; Aaron Conole <aconole@redhat.com>
> Subject: Re: [PATCH v2] service: fix deadlock on worker lcore exit
>
> On Thu, Oct 3, 2024 at 8:57 AM David Marchand <david.marchand@redhat.com>=
wrote:
> >
> > From: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>
> >
> > Calling rte_exit() from a worker lcore thread causes a deadlock in
> > rte_service_finalize().
> >
> > This patch makes rte_service_finalize() deadlock-free by avoiding the
> > need to synchronize with service lcore threads, which in turn is
> > achieved by moving service and per-lcore state from the heap to being
> > statically allocated.
> >
> > The BSS segment increases with ~156 kB (on x86_64 with default
> > RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).
> >
> > According to the service perf autotest, this change also results in a
> > slight reduction of service framework overhead.
> >
> > Fixes: 33666b448f15 ("service: fix crash on exit")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> > Changes since v1:
> > - rebased,
>
> I can't merge this patch in its current state.
>
> At the moment, two CI report a problem with the
> eal_flags_file_prefix_autotest unit test.
>
> -------------------------------------stdout------------------------------=
-------
> RTE>>eal_flags_file_prefix_autotest
> Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test'
> '--proc-type=3Dsecondary' '-m' '18' '--file-prefix=3Dmemtest'
> Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test'
> '-m' '18' '--file-prefix=3Dmemtest1'
> Error - hugepage files for memtest1 were not deleted!
> Test Failed
> RTE>>
>
> Can you have a look?
Not sure how the code change in question is relating to the eal-flags failu=
re, but I can reproduce the failure here.
Reproducing issue on *all* of the below tags; this indicates its likely a b=
oard-config issue, and not a true issue (unless its been there since 23.11?=
?).
Tested commits were all bad:
b3485f4293 (HEAD, tag: v24.07) version: 24.07.0
a9778aad62 (HEAD, tag: v24.03) version: 24.03.0
eeb0605f11 (HEAD, tag: v23.11) version: 23.11.0
So I'm pretty sure this is a board/runner config issue, with the error outp=
ut as follows here:
RTE>>eal_flags_file_prefix_autotest
Running binary with argv[]:'./app/test/dpdk-test' '--proc-type=3Dsecondary'=
'-m' '18' '--file-prefix=3Dmemtest'
EAL: Detected CPU lcores: 64
EAL: Detected NUMA nodes: 2
EAL: Detected static linkage of DPDK
EAL: Cannot open '/var/run/dpdk/memtest/config' for rte_mem_config
EAL: FATAL: Cannot init config
EAL: Cannot init config
FAIL:
DPDK_TEST=3Deal_flags_file_prefix_autotest ./app/test/dpdk-test --no-pci
PASS:
DPDK_TEST=3Deal_flags_file_prefix_autotest ./app/test/dpdk-test
So seems like the eal-flags test is NOT able to handle args like "--no-pci"=
? I tend to run tests in no PCI mode to speed up things :)
In short, this service-cores patch is not the root cause. Perhaps some of t=
he CI folks can confirm if there's extra args passed to the runner?
Regards, -Harry
--_000_PH8PR11MB6803B474AE398A725C2A3583D7712PH8PR11MB6803namp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
> From: David Marchand <david.marchand@redhat.com></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Sent: Thursday, October 3, 2024 10:13 AM</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> To: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com>; Van Haar=
en, Harry <harry.van.haaren@intel.com></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Cc: dev@dpdk.org <dev@dpdk.org>; stephen@networkplumber.org <=
stephen@networkplumber.org>; suanmingm@nvidia.com <suanmingm@nvidia.c=
om>; thomas@monjalon.net <thomas@monjalon.net>; stable@dpdk.org &l=
t;stable@dpdk.org>; Tyler Retzlaff <roretzla@linux.microsoft.com>;
Aaron Conole <aconole@redhat.com></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Subject: Re: [PATCH v2] service: fix deadlock on worker lcore exit</di=
v>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> </div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> On Thu, Oct 3, 2024 at 8:57 AM David Marchand <david.marchand@redha=
t.com> wrote:</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > From: Mattias R=F6nnblom <mattias.ronnblom@ericsson.com></d=
iv>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Calling rte_exit() from a worker lcore thread causes a deadlock i=
n</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > rte_service_finalize().</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > This patch makes rte_service_finalize() deadlock-free by avoiding=
the</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > need to synchronize with service lcore threads, which in turn is<=
/div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > achieved by moving service and per-lcore state from the heap to b=
eing</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > statically allocated.</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > The BSS segment increases with ~156 kB (on x86_64 with default</d=
iv>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > According to the service perf autotest, this change also results =
in a</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > slight reduction of service framework overhead.</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Fixes: 33666b448f15 ("service: fix crash on exit")</div=
>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Cc: stable@dpdk.org</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> ></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Signed-off-by: Mattias R=F6nnblom <mattias.ronnblom@ericsson.c=
om></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com></di=
v>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > ---</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > Changes since v1:</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> > - rebased,</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> I can't merge this patch in its current state.</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> At the moment, two CI report a problem with the</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> eal_flags_file_prefix_autotest unit test.</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> -------------------------------------stdout---------------------------=
----------</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> RTE>>eal_flags_file_prefix_autotest</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test'=
</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> '--proc-type=3Dsecondary' '-m' '18' '--file-prefix=3Dmemtest'</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Running binary with argv[]:'/home/zhoumin/gh_dpdk/build/app/dpdk-test'=
</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> '-m' '18' '--file-prefix=3Dmemtest1'</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Error - hugepage files for memtest1 were not deleted!</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Test Failed</div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> RTE>></div>
<div style=3D"font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, =
Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
> Can you have a look?</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
Not sure how the code change in question is relating to the eal-flags failu=
re, but I can reproduce the failure here.</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
Reproducing issue on *all* of the below tags; this indicates its likely a b=
oard-config issue, and not a true issue (unless its been there since 23.11?=
?).</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
Tested commits were all bad:</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
b3485f4293 (HEAD, tag: v24.07) version: 24.07.0</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
a9778aad62 (HEAD, tag: v24.03) version: 24.03.0</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
eeb0605f11 (HEAD, tag: v23.11) version: 23.11.0</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
So I'm pretty sure this is a board/runner config issue, with the error outp=
ut as follows here:</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
RTE>>eal_flags_file_prefix_autotest</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
Running binary with argv[]:'./app/test/dpdk-test' '--proc-type=3Dsecondary'=
'-m' '18' '--file-prefix=3Dmemtest'</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
EAL: Detected CPU lcores: 64</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
EAL: Detected NUMA nodes: 2</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
EAL: Detected static linkage of DPDK</div>
<div style=3D"margin: 0in; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MS=
FontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0,=
0, 0);">
EAL: Cannot open '/var/run/dpdk/memtest/config' for rte_mem_config</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
EAL: FATAL: Cannot init config</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
EAL: Cannot init config</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
FAIL:</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
DPDK_TEST=3Deal_flags_file_prefix_autotest ./app/test/dpdk-test --no-=
pci</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
PASS:</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
DPDK_TEST=3Deal_flags_file_prefix_autotest ./app/test/dpdk-test </div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
So seems like the eal-flags test is NOT able to handle args like "--no=
-pci"? I tend to run tests in no PCI mode to speed up things :)</div>
<div class=3D"elementToProof" style=3D"margin: 0in; font-family: Aptos, Apt=
os_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-=
size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
In short, this service-cores patch is not the root cause. Perhaps some of t=
he CI folks can confirm if there's extra args passed to the runner?</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
<br>
</div>
<div class=3D"elementToProof" style=3D"font-family: Aptos, Aptos_EmbeddedFo=
nt, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; c=
olor: rgb(0, 0, 0);">
Regards, -Harry</div>
</body>
</html>
--_000_PH8PR11MB6803B474AE398A725C2A3583D7712PH8PR11MB6803namp_--