From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Arnaud Fiorini <arnaud.fiorini@polymtl.ca>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v3] eal: add tracepoints to track lcores and services
Date: Tue, 13 Jun 2023 10:00:05 +0000 [thread overview]
Message-ID: <PH8PR11MB6803D9B98A65EEEB9726D6BDD755A@PH8PR11MB6803.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wPaUZq+Yc0TFQurSB8MUHk3WHXK8xhzJbm9t8Big2OYg@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, June 13, 2023 9:39 AM
> To: Arnaud Fiorini <arnaud.fiorini@polymtl.ca>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> <jerinj@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; dev@dpdk.org
> Subject: Re: [PATCH v3] eal: add tracepoints to track lcores and services
>
> Hello,
Hi David,
> On Fri, May 12, 2023 at 4:30 PM Arnaud Fiorini
> <arnaud.fiorini@polymtl.ca> wrote:
> >
> > The tracepoints added are used to track lcore role and status,
> > as well as service mapping and service runstates. These
> > tracepoints are then used in analyses in Trace Compass.
> >
> > Signed-off-by: Arnaud Fiorini <arnaud.fiorini@polymtl.ca>
>
> Harry, the majority of trace points added by this patch are in the service code.
> Could you review please?
Performance wise, this patch is the same as V1 comments, no concerns here just noting that enabling tracing impacts perf.
http://patches.dpdk.org/project/dpdk/patch/20230424152412.3784016-2-arnaud.fiorini@polymtl.ca/#159839
Docs look good, thanks for adding the --trace= example, it will help users in future!
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2023-06-13 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 20:16 [PATCH v2] " Arnaud Fiorini
2023-05-11 20:50 ` Stephen Hemminger
2023-05-11 21:01 ` Arnaud Fiorini
2023-05-11 22:18 ` Stephen Hemminger
2023-05-12 14:30 ` [PATCH v3] " Arnaud Fiorini
2023-06-05 14:48 ` Arnaud Fiorini
2023-06-13 8:38 ` David Marchand
2023-06-13 10:00 ` Van Haaren, Harry [this message]
2023-06-21 8:25 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH8PR11MB6803D9B98A65EEEB9726D6BDD755A@PH8PR11MB6803.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=arnaud.fiorini@polymtl.ca \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).