From: Phil Yang <Phil.Yang@arm.com>
To: Lijun Ou <oulijun@huawei.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine
Date: Thu, 2 Jul 2020 15:03:24 +0000 [thread overview]
Message-ID: <PR2PR08MB46351EEC6E456A86BF1F1C02E96D0@PR2PR08MB4635.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1593589406-12868-1-git-send-email-oulijun@huawei.com>
Hi Lijun,
Some comments inline.
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
> Sent: Wednesday, July 1, 2020 3:43 PM
> To: wenzhuo.lu@intel.com; beilei.xing@intel.com;
> bernard.iremonger@intel.com; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; linuxarm@huawei.com
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current
> forward engine
>
> When set the forwarding mode of the pkt, it needs to update
> the fwd_eng that it is the member of cur_fwd_config. Otherwise,
> an error will occur when executing the set command and show
> confg fwd.
> the flows as follows:
> 1. ./tespmd -w xxx -l xx -n 4 -- i
> 2. set fwd mac
> testpmd> set fwd mac
> Set mac packet forwarding mode
>
> 3. show config fwd
> testpmd> show config fwd
> io packet forwarding - ports=1 - cores=1 - streams=8 -...
> Logical Core 1 (socket 0) forwards packets on 8 streams:
I think we need to stop the running engine then start the new engine to make the configuration work.
The Testpmd can't switch forward engine on runtime. When it is forwarding packets, the standing operating procedures should be:
1. testpmd> set fwd mac
2. testpmd> stop
3. testpmd> start
We can add a patch to document this standing operating procedure.
Or we can refactor the set_pkt_forwarding_mode API to support this feature. I prefer this approach.
>
> When run the 1 ~ 3 step, it should show the packet forwarding is
> mac.
>
> Fixes: af75078fece3 ("first public release")
> Cc: wenzhuo.lu@intel.com
> Cc: beilei.xing@intel.com
> Cc: bernard.iremonger@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> v2:
> -- fix the title
> -- add fixes and Cc
> ---
> app/test-pmd/config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index a7112c9..ee0e904 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char
> *fwd_mode_name)
> fwd_mode_name,
> retry_enabled == 0 ? "" : " with retry");
> cur_fwd_eng = fwd_eng;
> +cur_fwd_config.fwd_eng = fwd_eng;
When you stop and restart the forwarding engine, it overwrites by the old engine.
Thanks,
Phil
> return;
> }
> i++;
> --
> 2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2020-07-02 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 7:43 Lijun Ou
2020-07-02 8:11 ` Wisam Monther
2020-07-02 15:03 ` Phil Yang [this message]
2020-07-03 1:31 ` Phil Yang
2020-07-15 10:35 ` Phil Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR2PR08MB46351EEC6E456A86BF1F1C02E96D0@PR2PR08MB4635.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@huawei.com \
--cc=oulijun@huawei.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).