DPDK patches and discussions
 help / color / mirror / Atom feed
From: Carlos de Souza Moraes Neto <carlosmn@weg.net>
To: David Marchand <david.marchand@redhat.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"mingjinx.ye@intel.com" <mingjinx.ye@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RES: [PATCH] net/ice: fix vlan stripping in double VLAN mode
Date: Wed, 3 Apr 2024 14:03:22 +0000	[thread overview]
Message-ID: <RO2P152MB6008E7DB77BE5B29845EB064DD3D2@RO2P152MB6008.LAMP152.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAJFAV8xagbxrARVC_Y-NH3-B7O=SCkTdYMAOMM_gaJuPP-t=Dg@mail.gmail.com>

Hi David,

I verified using testpmd and my application and worked fine.
Thank you for your help,

Sincerely
Carlos Moraes.

-----Mensagem original-----
De: David Marchand <david.marchand@redhat.com> 
Enviada em: quinta-feira, 28 de março de 2024 08:16
Para: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org; Carlos de Souza Moraes Neto <carlosmn@weg.net>; mingjinx.ye@intel.com; stable@dpdk.org
Assunto: Re: [PATCH] net/ice: fix vlan stripping in double VLAN mode

ATENÇÃO:  Esta mensagem é de REMETENTE EXTERNO - Tenha cuidado ao abrir links e anexos.
*** NOVO *** NÃO digite sua SENHA WEG quando solicitada por E-MAIL EXTERNO


On Wed, Mar 27, 2024 at 7:44 PM Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
>
> The ICE hardware can operate in two modes - single vlan mode or double 
> vlan mode. Depending on the operating mode the hardware handles vlan 
> header with single vlan tag differently.
> When double vlan enabled, a packet with a single VLAN is treated as a 
> packet with outer VLAN only. Otherwise, a single VLAN in a packet is 
> treated as inner VLAN.
>
> This patch fixes the logic of how vlan stripping is programmed.
>
> Bugzilla ID: 1402

Nit: no need for an empty line here, the Bugzilla ID: tag goes with the Fixes: and Cc: block.

>
> Fixes: de5da9d16430 ("net/ice: support double VLAN")
> Cc: mingjinx.ye@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Thanks Vladimir.
It looks to fix the issue I observed.
I'll let Carlos confirm the fix is good for him too.


--
David Marchand


  reply	other threads:[~2024-04-03 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 18:44 Vladimir Medvedkin
2024-03-28 11:16 ` David Marchand
2024-04-03 14:03   ` Carlos de Souza Moraes Neto [this message]
2024-04-04 10:43 ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=RO2P152MB6008E7DB77BE5B29845EB064DD3D2@RO2P152MB6008.LAMP152.PROD.OUTLOOK.COM \
    --to=carlosmn@weg.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mingjinx.ye@intel.com \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).