DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Wenjun1" <wenjun1.wu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time
Date: Thu, 29 Apr 2021 02:26:57 +0000
Message-ID: <SA0PR11MB4575AD5BFB5DE4C055EC7B9CDF5F9@SA0PR11MB4575.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8977359b-c937-6660-c876-10cc7e3e3892@intel.com>

Hi Ferruh,

I realized there were some ambiguities. I will modify commit in the new patch.


-----Original Message-----
From: Yigit, Ferruh <ferruh.yigit@intel.com> 
Sent: Wednesday, April 28, 2021 5:30 PM
To: Wu, Wenjun1 <wenjun1.wu@intel.com>; dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time

On 4/25/2021 3:02 AM, Wenjun Wu wrote:
> When resetting VF, VF will issue reset command to PF, wait a fixed 
> amount of time, and assume VF reset is done. However, due to the 
> change of dpdk related library content, the original delay is not 
> enough. When we use DPDK PF instead of kernel PF, it may cause VF 
> start error.

Hi Wenjun,

Can you please give details of the "the change of dpdk related library content"?
This can help to document the root cause of the problem.
And you can also add fixes tag for that change if it is appropriate.

> This patch extend VF reset waiting time from 200ms to 500ms so that VF 
> can start normally when using DPDK PF and DPDK VF in most cases.
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 3c258ba7cf..aeb6816b9f 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1236,7 +1236,7 @@ i40evf_reset_vf(struct rte_eth_dev *dev)
>  	  * it to ACTIVE. In this duration, vf may not catch the moment that
>  	  * COMPLETE is set. So, for vf, we'll try to wait a long time.
>  	  */
> -	rte_delay_ms(200);
> +	rte_delay_ms(500);
>  	ret = i40evf_check_vf_reset_done(dev);
>  	if (ret) {

  reply	other threads:[~2021-04-29  2:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  5:34 [dpdk-dev] [PATCH v1] " Wenjun Wu
2021-04-25  2:02 ` [dpdk-dev] [PATCH v2] " Wenjun Wu
2021-04-25  2:25   ` Zhang, Qi Z
2021-04-25  7:44   ` Zhou, JunX W
2021-04-28  9:30   ` Ferruh Yigit
2021-04-29  2:26     ` Wu, Wenjun1 [this message]
2021-04-29  3:05   ` [dpdk-dev] [PATCH v3] " Wenjun Wu
2021-04-29  3:10     ` [dpdk-dev] [PATCH v4] " Wenjun Wu
2021-04-29  8:27       ` [dpdk-dev] [PATCH v5] " Wenjun Wu
2021-04-29 11:04         ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA0PR11MB4575AD5BFB5DE4C055EC7B9CDF5F9@SA0PR11MB4575.namprd11.prod.outlook.com \
    --to=wenjun1.wu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git