DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ajmera, Megha" <megha.ajmera@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	 "Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Thakur, Sham Singh" <sham.singh.thakur@intel.com>
Subject: RE: [PATCH v1] sched: enable/disable TC OV at runtime
Date: Fri, 11 Mar 2022 06:24:35 +0000	[thread overview]
Message-ID: <SA0PR11MB46705CD550246FCF07EDAB32970C9@SA0PR11MB4670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220310122325.2e928c7d@hermes.local>

> 
> > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> > ec74bee939..1d05089d00 100644
> > --- a/lib/sched/rte_sched.c
> > +++ b/lib/sched/rte_sched.c
> > @@ -155,6 +155,7 @@ struct rte_sched_subport {
> >  	uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
> >
> >  	/* TC oversubscription */
> > +	uint8_t is_tc_ov_enabled;
> >  	uint64_t tc_ov_wm;
> >  	uint64_t tc_ov_wm_min;
> >  	uint64_t tc_ov_wm_max;
> 
> Putting the field there creates a hole in the structure.
> Put it after tc_ov and fill an existing hole.
> 
> This is pahole of current code, looks like this struct could use some work to be
> better packed and aligned.
>

Thanks Stephen for pointing this out. I agree there is some work needed to pack this structure better.
Can we take this up in a separate patch in later release as it requires more performance test runs to see the impact ?
 

  reply	other threads:[~2022-03-11  6:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 19:54 Megha Ajmera
2022-03-10 20:23 ` Stephen Hemminger
2022-03-11  6:24   ` Ajmera, Megha [this message]
2022-03-11 17:13     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA0PR11MB46705CD550246FCF07EDAB32970C9@SA0PR11MB4670.namprd11.prod.outlook.com \
    --to=megha.ajmera@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jasvinder.singh@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=sham.singh.thakur@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).