From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93F6EA00C2; Fri, 11 Mar 2022 07:24:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34C5640140; Fri, 11 Mar 2022 07:24:41 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9AD1F40042 for ; Fri, 11 Mar 2022 07:24:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646979879; x=1678515879; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P9OCvfXFQYYGJ5Dc/tGjAWQPVYXGw6LSZkDGR2pMLjs=; b=Il/iEVxs71I/zESMyCBW9BTERAOQo59E6WxIhNTunH8VZ18GSpr3O9Vh oKs7jKCQvJgSP9QdFi5mXAW3PjicIFWPxRn1l3jHtsZdr2jMyR53rpPsu z72s2cJW8OOkR7ex4nX5HYkvXEFusvDROWSxf5PjjXR/itR8IZJc3UZUo WBctFtYMUocS6/lEVyoTneCzqi3k/GQo+Oide3Zq21HWWq+LyNbqI5w1q mN8WpWhkZZ3cZ4hq6l4Cc3gDDIR7suC0z63H0jQJp/mRKjg/AnPcgk56b BjB5gWTSXwn9+mHst7UlHFxeCXamWWxEF8gTbt4s12FYv5cLdp6vGnYzY Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="253075140" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="253075140" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 22:24:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="644834426" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 10 Mar 2022 22:24:38 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 22:24:38 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 22:24:37 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 10 Mar 2022 22:24:37 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 10 Mar 2022 22:24:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLgUpmhrG/op800g0FL+k6FDUW+wIl0hZWEtVC9a6DXJKMubUzEGnRWp5iyI8vT10xYknPtLkZPJa3RMtg8+PDUoCQkeSH+V0Zf7KlaYKkRfRugcMFgg9w+bA2TYb0OZBAMniDiHFuf8UtnmQ8mp78sB2dgugBxETLjgHeywYUYa12WjzN7uuf7oZHzF5dDpmOiz46NOqGclWqRiOGf5sh/FN9YypXwFfQ8ZbEOhTg6L+M+Ymu64jNJCTNGFTe2qijAFItzrEE61iCruSI3c79ROMrgPOV/Ribrs+f1O9B+u9+1PD3xMOhM+z4z92UKwc6RgDeE9Fn/ItSOvE23QaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xqi+ydD3B8yOaf24sFV0fpMmUtXrKLg5ycFOWfw31fE=; b=DGqUUxCEFBgDeGIl5abrnsos0L1dHsCpMfq3MzSyet4ofEotuu5In/CiOZZ+czIPoK4NsZhNiScVRiYEKjsOoQpbUe3szWnkhDOGAPTIW2VwMuV9xt44/5BMIvqG3gvcpAosPHA3Rak+O7QTE0/YZ37zpFknsHdp6Rq+CDRcmlmcFLmN28s62zV7HiBElt4xPrRDMq4O5O3YFm6sXNExm9s5/aclJgeyD1a9xUK6zrLZkTPlIA2zUBt0n/0Dp45qbTlQiY6nqo01nguDqqaYw7ex173ASwwA1P3Xqu/YHmsCJ+09Hh3r7COT4tHs+Wx1IKgo+h+D3rMpT4+/eAe7QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA0PR11MB4670.namprd11.prod.outlook.com (2603:10b6:806:9a::8) by SA0PR11MB4687.namprd11.prod.outlook.com (2603:10b6:806:96::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 06:24:35 +0000 Received: from SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::401f:f9dc:f7e2:c347]) by SA0PR11MB4670.namprd11.prod.outlook.com ([fe80::401f:f9dc:f7e2:c347%7]) with mapi id 15.20.5061.021; Fri, 11 Mar 2022 06:24:35 +0000 From: "Ajmera, Megha" To: Stephen Hemminger CC: "dev@dpdk.org" , "Mcnamara, John" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Yigit, Ferruh" , "Thakur, Sham Singh" Subject: RE: [PATCH v1] sched: enable/disable TC OV at runtime Thread-Topic: [PATCH v1] sched: enable/disable TC OV at runtime Thread-Index: AQHYNLz/wHdsUuHBrEGNn1mvgkrEb6y5tuYg Date: Fri, 11 Mar 2022 06:24:35 +0000 Message-ID: References: <20220310195426.4121953-1-megha.ajmera@intel.com> <20220310122325.2e928c7d@hermes.local> In-Reply-To: <20220310122325.2e928c7d@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d58323c-fb16-47d2-0657-08da0327cff6 x-ms-traffictypediagnostic: SA0PR11MB4687:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QrAra8erh9YhT189921mULCJM4XyG1dTMQHbjuDPNo0R7OCTtCQWr2gj9S1cJ/M45LLwh6ShERnzaBOtfLMLDrjJKsu9r10+mGVB5bK60qOVKMbaqDpMCHfNU2maWKFxipFGec2u2Bu7l2ZHQaTcJxzL0SIbwEqCOfPorLxyqRrNDftFRGRrBjEZ3Wet7HdR+Przw8Ua85sr6vO2AMoN/ihgYxc5qe7QZaXwQhw2F1FWeSIyqLZLPa3AZZ7ZJKbk2NXqtFu2DJV4kt5GaCcpP0wd6/PMqKk0FlgMyOTV/lg+FM66NIE3ZVM8WJcwubU6zq6DwjmT7EuZ7QCRCZW173oOe4ISCqo/x+r3LRPnlImRj19iN0/nTNByHdSuwqnP7oeJyff3oK3SQ+yr1lh7vqJwYCF05otvWDiQB65YtAfkaS7GXaLwamr4DJ+hAAfgsfaYkKQcDbRfU3rMYSC0Mk9OkDxHo0VDZwF5Yt5zuLltPm0Cshvoz2cqgtT61tw9L5V7371gf/WYj2NIuJAqEOxvtF/hg4rele5HgH2NB+bC8xRkUjkVGu8XzY7jOu9aiun4tPloux2QeBYODjZwWqf/KjU/nt1qlCOrXRPC4IRZ0nQja34S3xTVU7CQT+W1DmVWblitxdhN5WJl3aUy9fB2pXSTxbaDXpI8z2oj5IzVQAOQEtZq4beUPJC9yp0SuQVv91F6UlaYhZOVqpeSOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA0PR11MB4670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(64756008)(66476007)(71200400001)(66556008)(8676002)(4326008)(26005)(107886003)(186003)(66946007)(66446008)(76116006)(54906003)(316002)(5660300002)(6916009)(2906002)(6506007)(9686003)(7696005)(86362001)(55016003)(33656002)(82960400001)(38070700005)(508600001)(8936002)(4744005)(52536014)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7miNt+fp1KTKGcto0D8YAdhum+zelqgX+gCP1pJCp7cigw8c5ECL8NH3ZRny?= =?us-ascii?Q?0yx03LHO0Y3TyFTEeEB2/65G+ht+gX/qgmm8Iic387d50amX+bH7vaYVIyy7?= =?us-ascii?Q?wit8fZehwsNW2YcrIfLuOploho5aLXV1wYew3lSrMCa+Szhcv0MPL71/24L6?= =?us-ascii?Q?L3/1AHVfjIATJSRAlMgXfF7YFf++ugn/U/ZGJu+P6CK2Buj88TYfZrqc752q?= =?us-ascii?Q?OExk1aDTBcwX7aN2kTexASrmSQ/ichEssmp44bBwRlghy341WAHZLs+AzcXC?= =?us-ascii?Q?tHD2LH9C6QjUXSp4P32FJi1bnQnysQfNCaKPBfHpvpc8tUx3xz6ndK593Jzs?= =?us-ascii?Q?sInINjOVQQc/3yVq0a2f4qgCvV0pSfXKhFN63+8cL7hYGmH+Vrh0lVH5wmuu?= =?us-ascii?Q?Xx8Wx1damtx3czfHYJk/7SOKT7hRtyP1GF9eXFN8EMFytcp4j64yHW9pBg/4?= =?us-ascii?Q?f6/shBW67RocYaXQnQBACDk5g+fFCgtonwTbmUqc5I0nojt3A7l70bsZlMuQ?= =?us-ascii?Q?wCwANRmrHqPIxZC4ALw847Z4nHESp4EfbQ45kf1sAqYtS4GACwGiPAahGWCU?= =?us-ascii?Q?NAMk55sc7qcjCDRICDs9jeMZa3H18GqbWhcD7NxQ3q4ifpLPZbm0quwyfHPQ?= =?us-ascii?Q?lh/0VXTw776EVqHpBcpqRkoOKY8PtOQuEfd5EUdWohDw040fxSyx3TXoUEq4?= =?us-ascii?Q?J+coZ6+4mvmXCxxde8spBP2RbwVVSElXaq7kzkWMpcH0AE0kr5ZGc+88f5Oe?= =?us-ascii?Q?7FNYDfDUuaJAhZWxxXXGffEeY/LGDZXQLno03To1wheeuRH2d0MVb/40kJZE?= =?us-ascii?Q?JJ3P6wV6N5uHM8BE0+CMyNL4lOEKS1Rf0HIMxe5tPEMamcPDO4JCs2S8Sngc?= =?us-ascii?Q?sA7bpyLJj2Z6TAeMZX7qaNdhtrPTB3jg4Rv4SMk/xJGii1UjrwCDPuSLiLHO?= =?us-ascii?Q?pVAMVn/c4DLFHWwNB7E82HtZyCmVBuFGy+NbnzByjDuWizbCt7RnO+MtJ1lx?= =?us-ascii?Q?N6IiL0UB9IkGjKBkF+om+1HwF/Wa4ug3CYR74DEeQNkhvx+OvDOgVYk18ZHd?= =?us-ascii?Q?4rhZRQW/JtV/ckTnxtjYgqxXhzY8YHyq67mcR7pBrh/VNL8HfDXMoKFqFlhM?= =?us-ascii?Q?bVsT/auqeEhrXXxsJgG583GOly+gyOs7Is0mm/rahStukgevgk6eMerTz3dS?= =?us-ascii?Q?s7HP8wZ5CsvEx52YAgGmNlic1WfnZZoJb3XpFl62gEZazObqij4afeF9fgHf?= =?us-ascii?Q?98aItS4Z1NG8+qoUIbL4YOvlbSqwOUGEWjFic/pRM/v65vD6sRarcqZKCI60?= =?us-ascii?Q?hzPvA6YrRLGpWOpNMpsJbjyan93b6I/rrC7oQqVNkxOOedNu3+LIvf8qvjQx?= =?us-ascii?Q?X9ORl6yczitNmwKKea5Hb0uVyJ+dsn6MkOUPxazOqgFqhPJgyx832LNZsHBk?= =?us-ascii?Q?X7YW/0TgsMvrSME8OJlVv7N+d63ensKH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR11MB4670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d58323c-fb16-47d2-0657-08da0327cff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 06:24:35.2711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hi04xZJ7MJWQ6C/gqw41dBr5vHldXQEkixkKYB2mKPWMRH9ATlg2GLRLAUo6PZQhFyEOf8f8gown7SSaxK1rbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4687 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > ec74bee939..1d05089d00 100644 > > --- a/lib/sched/rte_sched.c > > +++ b/lib/sched/rte_sched.c > > @@ -155,6 +155,7 @@ struct rte_sched_subport { > > uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; > > > > /* TC oversubscription */ > > + uint8_t is_tc_ov_enabled; > > uint64_t tc_ov_wm; > > uint64_t tc_ov_wm_min; > > uint64_t tc_ov_wm_max; >=20 > Putting the field there creates a hole in the structure. > Put it after tc_ov and fill an existing hole. >=20 > This is pahole of current code, looks like this struct could use some wor= k to be > better packed and aligned. > Thanks Stephen for pointing this out. I agree there is some work needed to = pack this structure better. Can we take this up in a separate patch in later release as it requires mor= e performance test runs to see the impact ? =20