From: "Ajmera, Megha" <megha.ajmera@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Thakur, Sham Singh" <sham.singh.thakur@intel.com>
Subject: RE: [PATCH v1 0/4] sched: HQoS Library cleanup.
Date: Fri, 18 Feb 2022 09:41:03 +0000 [thread overview]
Message-ID: <SA0PR11MB4670C6808A613442B595552B97379@SA0PR11MB4670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xRhhSSTJ=A1yYPcbs1KNyC9cWRwHg8Jc1y35G7yzWFUA@mail.gmail.com>
Hi David,
I have rebased patch-set with latest main branch code resolving the conflicts. Also updated cover letter.
Regards,
Megha
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Friday, February 18, 2022 1:42 PM
To: Ajmera, Megha <megha.ajmera@intel.com>
Cc: dev <dev@dpdk.org>; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 0/4] sched: HQoS Library cleanup.
On Fri, Feb 18, 2022 at 8:42 AM Megha Ajmera <megha.ajmera@intel.com> wrote:
>
> v1:
> * Removed unused HQoS #defines from rte_config.
> * Enabled stats in HQoS by default.
> * TC subscription for best effort queues is always enabled in HQoS library.
> * VECTOR defines are removed from HQoS library.
This series does not apply on main, so we won't get tests from CI.
Is this a followup of patches?
https://patchwork.dpdk.org/project/dpdk/patch/20220121181459.1599739-1-megha.ajmera@intel.com/
(<-- which should be marked superseded..) https://patchwork.dpdk.org/project/dpdk/patch/20220125102105.1719667-1-megha.ajmera@intel.com/
I prefer to ask because I did not see much public discussion.
Commitlogs are poor/nonexistent and the cover letter does not explain the rationale.
--
David Marchand
prev parent reply other threads:[~2022-02-18 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 7:41 Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 16:23 ` Stephen Hemminger
2022-02-18 7:41 ` [PATCH v1 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 7:41 ` [PATCH v1 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 8:11 ` [PATCH v1 0/4] sched: HQoS Library cleanup David Marchand
2022-02-18 9:41 ` Ajmera, Megha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA0PR11MB4670C6808A613442B595552B97379@SA0PR11MB4670.namprd11.prod.outlook.com \
--to=megha.ajmera@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=sham.singh.thakur@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).