From: Shani Peretz <shperetz@nvidia.com>
To: Tanzeel Ahmed <tanzeelahmed713@gmail.com>,
Ori Kam <orika@nvidia.com>,
Thomas Monjalon <tmonjalon@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] examples/flow_filtering: fix make clean
Date: Thu, 3 Apr 2025 07:01:19 +0000 [thread overview]
Message-ID: <SA1PR12MB94916D6069CBED1D815FA460BFAE2@SA1PR12MB9491.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250329195333.324178-1-tanzeelahmed713@gmail.com>
> -----Original Message-----
> From: Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> Sent: Saturday, 29 March 2025 22:54
> To: Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> Subject: [PATCH] examples/flow_filtering: fix make clean
>
> External email: Use caution opening links or attachments
>
>
> make clean is unable to delete build directory because *.o files are not
> removed.
>
> The other way to fix this would be to add all the c files into SRCS-y.
>
> Signed-off-by: Tanzeel Ahmed <tanzeelahmed713@gmail.com>
> ---
> examples/flow_filtering/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/flow_filtering/Makefile
> b/examples/flow_filtering/Makefile
> index 9998ed10b5..653e3319a2 100644
> --- a/examples/flow_filtering/Makefile
> +++ b/examples/flow_filtering/Makefile
> @@ -50,5 +50,5 @@ build:
>
> .PHONY: clean
> clean:
> - rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
> + rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
> + build/*.o
> test -d build && rmdir -p build || true
> --
> 2.25.1
I checked and looks good on my side
prev parent reply other threads:[~2025-04-03 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 19:53 Tanzeel Ahmed
2025-03-31 8:45 ` Thomas Monjalon
2025-03-31 21:56 ` Tanzeel Ahmed
2025-04-03 7:01 ` Shani Peretz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR12MB94916D6069CBED1D815FA460BFAE2@SA1PR12MB9491.namprd12.prod.outlook.com \
--to=shperetz@nvidia.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=tanzeelahmed713@gmail.com \
--cc=tmonjalon@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).