DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Shijith Thotton <shijith.thotton@gmail.com>
Cc: Shijith Thotton <sthotton@marvell.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode
Date: Thu, 11 Mar 2021 20:47:48 +0000	[thread overview]
Message-ID: <SA2PR11MB5196D3D8F39BD5F713E4401DB9909@SA2PR11MB5196.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210310091431.GA21@BG-LT7405.marvell.com>

Hi Shijith,

> -----Original Message-----
> From: Shijith Thotton <shijith.thotton@gmail.com>
> Sent: Wednesday, March 10, 2021 3:15 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; Pavan Nikhilesh
> <pbhagavatula@marvell.com>; Jerin Jacob <jerinj@marvell.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for
> periodic mode
> 
> Hi Erik,
> 
> On Tue, Mar 09, 2021 at 08:04:32PM +0000, Carrillo, Erik G wrote:
> > > A timer adapter in periodic mode can be used to arm periodic timers.
> > > This patch adds flags used to advertise capability and configure
> > > timer adapter in periodic mode. Capability flag should be set for
> > > adapters which support periodic mode.
> > >
> > > Below is a programming sequence on the usage:
> > > 	/* check for periodic mode support by reading capability. */
> > > 	rte_event_timer_adapter_caps_get(...);
> > >
> > > 	/* create adapter in periodic mode by setting periodic flag
> > > 	   (RTE_EVENT_TIMER_ADAPTER_F_PERIODIC) and resolution. */
> > > 	rte_event_timer_adapter_create_ext(...);
> >
> > It looks like periodic support is an operating mode of the adapter
> > itself, and that all timers created with a periodic adapter instance
> > will be periodic timers.
> >
> > Is it possible to instead have "periodic/single-shot" be an attribute
> > of an event timer itself, such that a single adapter instance could
> > support either type of timer?
> >
> 
> With single type of timer per adapter, application can decide to create
> multiple adapters of required type/mode and use as needed.
> 
> For an adapter to support both type of timers, driver ops implementation has
> to follow different paths based on timer type and new capability flag should
> be introduced to expose this feature. Our HW only supports single type of
> timer per adapter.
> 
> Please let me know the approach you are aligned with.

Having a single type of timer per adapter is surprising initially, in my opinion,
but I think it does make using periodic timers simple.  Unless there are any
other comments to the contrary, I think we can proceed with this approach.

I'll respond in a separate post with comments on the patches.

Thanks,
Erik

> 
> Thanks,
> Shijith

  reply	other threads:[~2021-03-11 20:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:45 [dpdk-dev] [PATCH 0/3] periodic mode for event timer adapter Shijith Thotton
2021-03-08 20:45 ` [dpdk-dev] [PATCH 1/3] eventdev: introduce adapter flags for periodic mode Shijith Thotton
2021-03-09 20:04   ` Carrillo, Erik G
2021-03-10  9:14     ` Shijith Thotton
2021-03-11 20:47       ` Carrillo, Erik G [this message]
2021-03-12 15:30   ` Carrillo, Erik G
2021-03-14 16:49     ` Shijith Thotton
2021-03-08 20:45 ` [dpdk-dev] [PATCH 2/3] test/event: add unit tests for periodic timer Shijith Thotton
2021-03-08 20:45 ` [dpdk-dev] [PATCH 3/3] event/octeontx2: add timer periodic mode support Shijith Thotton
2021-03-14 16:45 ` [dpdk-dev] [PATCH v2 0/3] periodic mode for event timer adapter Shijith Thotton
2021-03-14 16:45   ` [dpdk-dev] [PATCH v2 1/3] eventdev: introduce adapter flags for periodic mode Shijith Thotton
2021-03-16 19:04     ` Carrillo, Erik G
2021-03-17  6:10       ` Shijith Thotton
2021-03-14 16:45   ` [dpdk-dev] [PATCH v2 2/3] test/event: add unit tests for periodic timer Shijith Thotton
2021-03-14 16:45   ` [dpdk-dev] [PATCH v2 3/3] event/octeontx2: add timer periodic mode support Shijith Thotton
2021-03-17  8:04   ` [dpdk-dev] [PATCH v3 0/3] periodic mode for event timer adapter Shijith Thotton
2021-03-17  8:04     ` [dpdk-dev] [PATCH v3 1/3] eventdev: introduce adapter flags for periodic mode Shijith Thotton
2021-03-17 18:07       ` Carrillo, Erik G
2021-03-22  9:50         ` Jerin Jacob
2021-03-17  8:04     ` [dpdk-dev] [PATCH v3 2/3] test/event: add unit tests for periodic timer Shijith Thotton
2021-03-17 18:11       ` Carrillo, Erik G
2021-03-17  8:04     ` [dpdk-dev] [PATCH v3 3/3] event/octeontx2: add timer periodic mode support Shijith Thotton
2021-03-21 14:43       ` Pavan Nikhilesh Bhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA2PR11MB5196D3D8F39BD5F713E4401DB9909@SA2PR11MB5196.namprd11.prod.outlook.com \
    --to=erik.g.carrillo@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=shijith.thotton@gmail.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).