From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A4AA0C45; Mon, 22 Nov 2021 09:54:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E5E940395; Mon, 22 Nov 2021 09:54:53 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6790A4014E for ; Mon, 22 Nov 2021 09:54:51 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="214777848" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="214777848" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:54:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="739118185" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 22 Nov 2021 00:54:49 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 22 Nov 2021 00:54:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 22 Nov 2021 00:54:49 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 22 Nov 2021 00:54:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LSSTKzzNLaF1u8SEb5NKISFoE9yWT8UuA8I/fzsti4+AcNhJ1JiYmJu/DI1JYwzco0ZZ0bhGJK/nBduWCW4HzisUqJ2Udy+y4qVr+gQhpvRbYx5IaH0eUy7LBsfsr+VAij0jedPWItt5yGbqlSsWh5VaLUJgI8XZkk0d1+GmgmK6NwhwLez2JMj6PNUnaXivYO0AfYMgxODr7z0TOVIqyN+x52OTQKsrL+wHa6WMoNgKtXH1zYZ3CT/bcE79l0ZwQxoBuT9h9lRSp9WvHPz0zvQ2rvLvUELjEszIvWKuyj38Uqx54k17EhCalUjt0m/vG3i3vZ9/hEoIxbnJoYgc8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cVP4ys86i2EtTd3OQMtA55z6a31lm1ta6rYlGKnRDTY=; b=cjHqOrdRq3mE+bgkFdZQTTU/pbspaS+vrwhqfNB3zHuaJsQ7XE0ofmyVZ83BeZc2WHCSmnuuZWLEuc8mCYlmKY4ux/y+AAoxs76ZATAo2z83+hN5xNZDPRM6UXRwc/4vCDZeWHNaULBhDOcecPPfTbyIQZivj/i5C/tvgpP6rO6+G4/bWuucCoErMFVIofoltfGzmO0Kaw+vzqtedE7oyYRAmdX5tTTAE3kg7c3So0LwKpBBrv3vXk95ORX4LhRDLO3IzFyTPnA+FVp0txjXuCu7lEqoXMu1A+llu4sjnyPR1broSJjfAievSq+SUoh7TDnHxZnP7l5qe9ELcyTqtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cVP4ys86i2EtTd3OQMtA55z6a31lm1ta6rYlGKnRDTY=; b=txLiV/fkK0xm84tL8IrbL6MdRx7Wbp8BVYwENdl/DZJKy892egpYOAATv4cjBarsAe7cbkcbFDPrhDp255dWdQ40QoXt85TkqBML9nCY0Wkb3lq/pSmKBG/RJWFZjE7TiYS2m9/2bzTQumSF6cLUi2H7QImjYgXhlVxTQtt4+Q8= Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SN6PR11MB2576.namprd11.prod.outlook.com (2603:10b6:805:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 22 Nov 2021 08:54:45 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::b0e2:edb7:5f09:bc57]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::b0e2:edb7:5f09:bc57%9]) with mapi id 15.20.4690.027; Mon, 22 Nov 2021 08:54:45 +0000 From: "Walsh, Conor" To: "Morrissey, Sean" , "Li, Xiaoyun" , "Chautru, Nicolas" , "Jay Zhou" , "Loftus, Ciara" , "Zhang, Qi Z" , Steven Webster , "Peters, Matt" , Apeksha Gupta , Sachin Saxena , "Wang, Xiao W" , "Wang, Haiyue" , "Xing, Beilei" , "Stephen Hemminger" , Long Li , Heinrich Kuhn , Jerin Jacob , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Ananyev, Konstantin" , Andrew Rybchenko , "Trahe, Fiona" , Ashish Gupta , "Griffin, John" , "Jain, Deepak K" , "Ziyang Xuan" , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , "Xu, Rosen" , "Zhang, Tianfei" , Akhil Goyal , "Doherty, Declan" , Chengwen Feng , "Laatz, Kevin" , "Richardson, Bruce" , Thomas Monjalon , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Morrissey, Sean" , Conor Fogarty , "Mcnamara, John" Subject: RE: [PATCH v1 1/3] fix PMD wording typo Thread-Topic: [PATCH v1 1/3] fix PMD wording typo Thread-Index: AQHX3ItUf5JD//zJIUqEserjA2j9FKwOLVDg Date: Mon, 22 Nov 2021 08:54:44 +0000 Message-ID: References: <20211118144645.2903463-1-sean.morrissey@intel.com> <20211118144645.2903463-2-sean.morrissey@intel.com> In-Reply-To: <20211118144645.2903463-2-sean.morrissey@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 705abdd5-f195-4f7a-4aa1-08d9ad95bb22 x-ms-traffictypediagnostic: SN6PR11MB2576: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CCUEQt0dcKprcJdPQRH7kl2tteP+HXIG6Q1yXVm3QZ4WSFk3jHzR6JC206+AO6rGiXozCgZmweALRNUNHZwiEcBpHomlkwf5JYI+7uYqbAJvA72taY8uodr2cPbAEiZ0P4LELCckkv5nVIIdDAMKRlqTAdueLhNJbkJsQumAe10Ugh5TDoi9KcjgQQb/Sl+CZwiWq+28GrEtUUHZqSjWJZN3mBtrZnpTuxh4+myTjtVZYwmeC+3wGoThSkUHu41gn0+zcPOXkr4UYjI+PiQTBPWLTD9XM9JikDF+ZwvzAjdhh8rqujhfLLrfErfF2Dv00KPswk0f03voHann93AC9QR5/+GGH6Dq+PQ1HGZuRHZYed0SNWLVtoHB7VnjlaKEFroh81gh+WUX1GQhOTSSXxahUg8N5+YlZo4/CzFViJ2sQDrZxBTq/Kwki4yomdHDaeRihq+pEb1Ep9k+12uPWm7GEwfMvNPAq2jCfUunbGj9EcxcQMl0guwjM7VJLQf+Yo3r+/9I6PLcKCWKXlfuGh5iIMMUEjCummVJw8UDvTfSg6D29bxY6T4nqXEzEynsuWa8jM31zpVENdTMllfRnedBhsOcoFbBvh5PO7pVKt6OZQTaMaYM//M09zHKSRDPPCQ42jr1/Z7z3/MlDgx4mRtnNdpp3YmHq6v5SHUhgj05leEYYCOBoiI+qICXdgfpcmEYc0MRup4bgZfIxpHY1iCTHnS8LllFu0IoYKAcAXM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(122000001)(4326008)(316002)(6636002)(5660300002)(7696005)(26005)(66446008)(33656002)(1191002)(83380400001)(76116006)(64756008)(66946007)(7416002)(86362001)(186003)(9686003)(54906003)(107886003)(110136005)(38070700005)(8676002)(71200400001)(52536014)(55016002)(921005)(82960400001)(66556008)(66476007)(508600001)(38100700002)(6506007)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TkdLMjsw8jbheMxHcMATyMowvUbshzv2ymgO8vzbfDilCWKblk4UZelCB739?= =?us-ascii?Q?Fg5Id3Ro0ohaTFW3aCT04NaIATSZsyC57tYoRoynKBFG1jrkyk4c9BCuVw3h?= =?us-ascii?Q?WXzsz3RiOs9EolOcWMVxHEVEmLj87WpzKFEu5Z68tst7KynCqaqS35JjCfHG?= =?us-ascii?Q?O/5lkwhiQpKy06vFVkfE7NGhqj1VRNcx7qU4tqBPkREw6EE8YF9F7rB8NxDr?= =?us-ascii?Q?Kn0mPx4VcLUqf58Z3Ul9BURFRcprVwXNF33wDEO6EK3IMZt99WAfF4EQphWY?= =?us-ascii?Q?OKarOadvSvbZRYl0ZkjT0QAf+Ecf8tr0PMMc1TUTOf5Aj2ozQCC29AUPO4+v?= =?us-ascii?Q?BiY+3N7CTTww4MDr9IDBAKyoRUoltHjf6J3D8yHy3chB8OS2BKZWNc/bUKdB?= =?us-ascii?Q?NBiv5MQl7Xn3J70zkCYv+tsOs2T8VpLAQriExO2OffGijMVjsn0Eaq17jezN?= =?us-ascii?Q?UuwjePu8wxPtBD4mAi6KtQip//oZA5Rl7y4wWJ7+SWincp53SqTOLlOxJjzr?= =?us-ascii?Q?jWdeH3sbba0r5Cj9kKEZ565RDemSKnVD0q9s5Onmtq9n+sPL8DEZmNGOSvUL?= =?us-ascii?Q?wXd5en+enyDcqpur97mVBrQL+Xf9ZAl8wpoIj0ADQdbFLLkzBthLWRZtVdk9?= =?us-ascii?Q?Pmlnqrf3GDAkiU8Ivs5XArMqjhdsy1xmxLjRGxWDQrmM8dRkA4d1nNUhIu8L?= =?us-ascii?Q?vztPye0aurEiYPaKcgZcLFTY/EZDuu2Ln0coJEAqA9+ClLr9HicASkJNxFi5?= =?us-ascii?Q?jGrvDQ+2reGOmRhJCDDx8+bCl9ArT5gBYz2Ih5Zc0EOOvelcA7aPy20YBNRg?= =?us-ascii?Q?S5ZHla8fOwHx+zpQ6ybfZTf7akOtDzKI9T+nVrHzChVp5UEhL3jzMaTCmwa1?= =?us-ascii?Q?BTN1b6+NG07WT+Y2Z0YXzfNYak0FzOHwhkMFD0JU0ejVr44uITMQbuoP5akS?= =?us-ascii?Q?aODDHa+Z7nalJ/xXojkBt3Zr/wiIYtEd56YA26/yYF4+kKz8hGAxtcprjQPB?= =?us-ascii?Q?dk1E/mu9q2qEcMKBJ2uDic8ConkL0JP3nBAfucpybIHTkunpBaXg3iT4ndT0?= =?us-ascii?Q?8webCW/yOjk480+Tc3bz1P+wdXPkbjZA2h30KASgIzaxoiQF0OVG7quNXkjM?= =?us-ascii?Q?orASf5kQSlRZTQcevposkCTyl7CajUIb/7AZu/d/x7pJ797g9iXICWOdhzXQ?= =?us-ascii?Q?mRHNkoAPpgBXoyueGg4Onc2R/0YoAiEgwMCgqJCLYbDhS5NvxD9h3FTHnANj?= =?us-ascii?Q?7MM1jjMODKcfdCVnxXWF3VLcMVPccOEC5V4iQzZp5LGXjdlGA/Vcw+SlQv8m?= =?us-ascii?Q?O3EmEUiGEHDcqrFimkROqlDtwP09pTcR29oXvx9djZk2AJOIQUXWrXjSZHo7?= =?us-ascii?Q?wrjUARkblRuxk0iCN/H01NX/aa1mQ9wKCx8jO4EK1vEUMES0clEcGSIST0pJ?= =?us-ascii?Q?RHdvIIZUZMliks2QImT4k1qUcP9ZBm7poun8MFCGL3kc/m/2tzPBrIXrD4PJ?= =?us-ascii?Q?5ZrA8kc5YoGYs2DdAYCrqIr7gg7zhM6+Z2y5bGlPXl+PxgzVuuiOfyBbq9Xm?= =?us-ascii?Q?FEHzjAOMQWxKQ50gKVJ75wXijt8W7usKCDptGDUflo3xyabMp32PN9nZ4HFR?= =?us-ascii?Q?WTcwxOvFK8o9OZaJ2PX7vRI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 705abdd5-f195-4f7a-4aa1-08d9ad95bb22 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2021 08:54:44.8943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5iYkUXr61ZBh+F9clb4QtJaRLyU+joyKYrQXEOLst/hJmrA6175oO5gQBlMcEAyOQVUM9ERa7qPSE80bbqwDrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2576 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Sean, A few minor nits, TBH not sure if they should be changed in this patch as t= his patch is just removing "driver" and correcting capitalisation of PMD. > diff --git a/drivers/net/hns3/hns3_ethdev.h > b/drivers/net/hns3/hns3_ethdev.h > index 6d30125dcc..488fe8dbbc 100644 > --- a/drivers/net/hns3/hns3_ethdev.h > +++ b/drivers/net/hns3/hns3_ethdev.h > @@ -465,7 +465,7 @@ struct hns3_queue_intr { > * enable Rx interrupt. > * > * - HNS3_INTR_MAPPING_VEC_ALL > - * PMD driver can map/unmmap all interrupt vectors with queues > When > + * PMD can map/unmmap all interrupt vectors with queues When "When" shouldn't be capitalised here. > * Rx interrupt in enabled. in =3D> is > */ > uint8_t mapping_mode; > diff --git a/drivers/net/hns3/hns3_ethdev_vf.c > b/drivers/net/hns3/hns3_ethdev_vf.c > index d8a99693e0..7d6e251bbe 100644 > --- a/drivers/net/hns3/hns3_ethdev_vf.c > +++ b/drivers/net/hns3/hns3_ethdev_vf.c > @@ -232,7 +232,7 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev > *dev, > HNS3_TWO_ETHER_ADDR_LEN, true, NULL, > 0); > if (ret) { > /* > - * The hns3 VF PMD driver depends on the hns3 PF kernel > ethdev > + * The hns3 VF PMD depends on the hns3 PF kernel ethdev > * driver. When user has configured a MAC address for VF > device > * by "ip link set ..." command based on the PF device, the > hns3 > * PF kernel ethdev driver does not allow VF driver to request > @@ -312,9 +312,9 @@ hns3vf_set_promisc_mode(struct hns3_hw *hw, > bool en_bc_pmc, > req =3D (struct hns3_mbx_vf_to_pf_cmd *)desc.data; >=20 > /* > - * The hns3 VF PMD driver depends on the hns3 PF kernel ethdev > driver, > + * The hns3 VF PMD depends on the hns3 PF kernel ethdev driver, > * so there are some features for promiscuous/allmulticast mode in > hns3 > - * VF PMD driver as below: > + * VF PMD as below: > * 1. The promiscuous/allmulticast mode can be configured > successfully > * only based on the trusted VF device. If based on the non trusted > * VF device, configuring promiscuous/allmulticast mode will fail. > @@ -322,14 +322,14 @@ hns3vf_set_promisc_mode(struct hns3_hw *hw, > bool en_bc_pmc, > * kernel ethdev driver on the host by the following command: > * "ip link set vf turst on" > * 2. After the promiscuous mode is configured successfully, hns3 VF > PMD > - * driver can receive the ingress and outgoing traffic. In the words= , > + * can receive the ingress and outgoing traffic. In the words, "In the words" doesn't make any sense here even, "In other words," doesn't = really work either. > * all the ingress packets, all the packets sent from the PF and > * other VFs on the same physical port. > * 3. Note: Because of the hardware constraints, By default vlan filter > * is enabled and couldn't be turned off based on VF device, so vlan > * filter is still effective even in promiscuous mode. If upper > * applications don't call rte_eth_dev_vlan_filter API function to > - * set vlan based on VF device, hns3 VF PMD driver will can't receiv= e > + * set vlan based on VF device, hns3 VF PMD will can't receive > * the packets with vlan tag in promiscuoue mode. > */ > hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_MBX_VF_TO_PF, > false); With or without these changes: Reviewed-by: Conor Walsh Thanks, Conor.