From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB5294325F; Wed, 1 Nov 2023 10:33:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80B3040151; Wed, 1 Nov 2023 10:33:16 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 34A26400EF; Wed, 1 Nov 2023 10:33:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698831194; x=1730367194; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7dgnijv78f8eR2VBWxARlQIZ8JuSKQ2i+8blNxyyJug=; b=HOMwrMMPrBJan6zfOt+oqniojrGF5cQzo74JDQRh0dIUFQYoV7oTLRTz v2PLay4ao0eqTk9pVhHajdO/4Zqb9ZmPOiM+62TcvXGkdhbCMojV+xCfE wyeDi6y+gGMThHQZkiUc/LSPtdqXLaSRfxm6CZAtFqaOwBW2q6KdbpEpf JgXMkomPc/PVwOyenbVspWfyEQ6GnAgr+69mM4MLsE1HoXkGDvj7C/Jpq MWcIzp9bW09Auoq374V2ex09C8sfJVnSnPWo0Hu+Rz08bIyh1FfoG67vg gZBCHdwiPDj8iAYAdQ03V/UVDuY9tARcsT+MGNtVA4nIDJPWXCf1SIU/c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="368674958" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="368674958" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:33:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="8611774" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Nov 2023 02:33:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 1 Nov 2023 02:33:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 1 Nov 2023 02:33:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 1 Nov 2023 02:33:11 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 1 Nov 2023 02:33:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqzpmrZV3kpNm3aqvSNHhyUBaXdMG2YiusN0rUY2uGTjegu1Q0XziEr5gPdkLCNkZj8xwWVx0+89bRx8z5lkib6RkWNrns9rWt2F57KFExlm2KBCzdwnuRgZTBJZbfHkCGwFIT+rhwcCJzq0npl5Xwz2uCCbuso9iJzfxr8SiI2FrQNR/bBGaohoSspna0USiDDUs9f3IpU2gPpTZ2Iwljpo3LtpPS9SmlJl2mb0d8DzNe3AYpseYC8zugsmvKx+4UE7WyqvxC1Q5NHBOAUGF4r3DkHzqBrO/ZcuCN+Rer0TuIJhDijB/X5kLasJn2pqrO3lAxSjayVHi83JQ4VEBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XWCsb+JPNu+aMPHlaavw5VDc/1MKriGWgjeqNcBfyTA=; b=Zdqa6d5zKnseoQnl9qI+HT//Ppcx/vTEyTFJOY066o5j1ze5nXH3CBq6ULVGf0ZdfLcfUT/2wwIL3tLycoY3/zDyGeSJhy0v5oOOD6tMyehMltLMU51WOrGh3jqhJuHMdgmqwLRvY9zVyBZyXNXCEdyzIenips5HTnNCVCoVojzL95A9jsds+zmiInvCVBzjBGGA0fNaDZ/eJ415xMX1oAWmPhv/pNiw58WKNuj1CSKiAOLoNL8wytLVwL9Divz001H/dt7D6uMbHZumlv8P48HBIGRitw/lJWlYrUt6fmyrv2HNxXPXNuklqCR6ya67/GCLL8FtrLvtCL+fxp6QZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA3PR11MB8003.namprd11.prod.outlook.com (2603:10b6:806:2f7::17) by SA2PR11MB4892.namprd11.prod.outlook.com (2603:10b6:806:f9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Wed, 1 Nov 2023 09:32:58 +0000 Received: from SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cfb:ebd5:d0fb:37b6]) by SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cfb:ebd5:d0fb:37b6%3]) with mapi id 15.20.6933.029; Wed, 1 Nov 2023 09:32:58 +0000 From: "Deng, KaiwenX" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Wu, Jingjing" , "Xing, Beilei" , "Zeng, ZhichaoX" Subject: RE: [PATCH v2] net/iavf: fix coredump when exiting testpmd Thread-Topic: [PATCH v2] net/iavf: fix coredump when exiting testpmd Thread-Index: AQHaDGkUyb9thHBRRka+b/049p+k67BlGA4AgAAY7gA= Date: Wed, 1 Nov 2023 09:32:58 +0000 Message-ID: References: <20231026085444.497296-1-kaiwenx.deng@intel.com> <20231101013433.534399-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA3PR11MB8003:EE_|SA2PR11MB4892:EE_ x-ms-office365-filtering-correlation-id: 32f6223e-7c2a-4209-0b7f-08dbdabd88e4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ISb23NsbvsOPol0n1P6p+aZGMeBlHmxlYo3v297EJGXg19Cb4JzKaf4IXv6WwUGf4TUY1Ia6g+OyjStfSwhnSsiJ22E/z7O2+GXF9z+F0z+YTvT7jL1ndaWWRzQuAiQjxa0xaPPVqDQ9T7u5/LvppZdAXaC0mM6sc3/2EwGkLmzOZ3xJQqrt+mbM6CA2N+MRC7EYiH+gxL1gr68l8CI8C7EpYlDpC2g92DTibb4Wo+JfwQSa0g1vrBRyR8WeMXLNQ9t/bmG2UqffnM9OIW6rA23eC4BbcuzDueRpAYYEbbPaWxI+aj2vrZ0HoWw2ZbpadsDx9rwvv7BNAFh8ZLiW82kogvmbGdsV5NxuHK8gk3G2RQ5GdNKxLswU/Ouqi7Eau0Llzy47gOXXCDAR5QsNOQz02OePJltIns58S25Ft093emD2OIpekr0jz+zEAtqW/gvD9t6AMeEzD3ay+FF4sh1dR46sUlLn6EYlOmODWEugFazntkVcrkl045wJ/xtMiG36SoyOx/zf4WRzuFoQy8TwnG+Cs5bu0QqrE5YzB2pH/PNeZMHtDNL18er++zIVep3DG2Zeyiw3iWWr2nTbw5zayeqcTtLLDKf6t+gzJBXZ7o1eKefaUTVoLP6P8oob x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA3PR11MB8003.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(366004)(376002)(346002)(396003)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(122000001)(478600001)(450100002)(5660300002)(82960400001)(26005)(83380400001)(38070700009)(33656002)(4326008)(52536014)(55016003)(107886003)(316002)(71200400001)(8676002)(86362001)(2906002)(38100700002)(41300700001)(8936002)(110136005)(66556008)(66476007)(66946007)(54906003)(66446008)(76116006)(64756008)(6506007)(7696005)(9686003)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?APs3h5P2geKfEkDnpaTIN7Qbfs/oiv9vnW/PIIlyuclmBRpQBOWKuje5jXe3?= =?us-ascii?Q?+3CtoevHR+OBy17GOCZiG3/yVaSoxdRw4MitcUabrUt2LlxBH9xc+L77Dmkx?= =?us-ascii?Q?xWyKaQTPWxuDzcqoqudkNmZvZq+kQBgujs3cjhoNKrYoHTs3SPB24Vix1OAY?= =?us-ascii?Q?iLgPZGbSMhiDHqirhbj6lUQNw4eKdpRNHFGqdUtw3GVc0pUD8zrWgLJpSmxf?= =?us-ascii?Q?te+qeGn8nqR8fyrncpZiTSb8sI05grOqzzy3uZRprbnpWBseiuN/Fm3ved2M?= =?us-ascii?Q?cpbECXhYiEcrZTvNSF28hI+XieXGsAo9PXbqTPUGGDpO1Y1FekujLQVucy69?= =?us-ascii?Q?qOPGE6rSNEUZ35gSTp3Pkk8+J3XcMItZQNTEF8vnj2ZmEPbHfhzIq3H9poXD?= =?us-ascii?Q?VEjTmK5aNUgwgg4IDb8L8agJIF8RJMTSc4wPMdqF56J23gUN5eZhCTo0Njqe?= =?us-ascii?Q?ZyxAMk1MVowQPBCA9MIUM0MHsk9xxVkMvevLwadiI6Gh/PEfcq/1LAD16iQV?= =?us-ascii?Q?JpVXV44TYYz+d4mMc+R6Moznlt8Xb9RC43cxSEF/TFLJ95VAtglcjYRxF9ua?= =?us-ascii?Q?sH0ojTUMi6s6rcI3oblxLwUvf+4n/r/OADUa36a/Nsnc3jdylt5NZEtkwA8n?= =?us-ascii?Q?t4b6nctT3zqzy5w42F4xf3nabVwDHGT4e2eWQx2fxb30WHG1zuSrBs2b6ThM?= =?us-ascii?Q?qnUxBmzHG4q2ztzwqglIIKWk9f3Inj9qbbRuSjhVr+gYPswf7xdg5oWJX454?= =?us-ascii?Q?yWrZZVzxFWqU7XPQpQd1E2EbvdXYUHg/p9YRGmYWs8U1OaaK2/X5FgqSgYZr?= =?us-ascii?Q?hiPWsTWbn3oRuzEj4PiRYWMBTUo1sIUWFMBKtY4MB8vXsFY5Z3Wz8baQn/Pw?= =?us-ascii?Q?5oNv7XHOUQq/t8/E3dK3TIR39ilE7CUdyvonWmUXGMWpY6kk7uR05C6Qy2BG?= =?us-ascii?Q?aasdrKTOcD9BS+kHIdk52FoTJ3pS+q6zcZyQ7CiiterD0Qpak2BIsQrWSgwn?= =?us-ascii?Q?h6updJQde0928tT7dwQv2ExYxTVP0nVuN/9+7cyFlQBwvQZTut8LE2cpmNPt?= =?us-ascii?Q?XKy5Fd5LqILPAW9G07xee+YXahGgqS7t6xi6IIOuAKVK+ywkP1rmQBRnpMcc?= =?us-ascii?Q?vEd+9lK+SbNfOyuvA7Wno0ajX8DwUCvUGyR8sdySnQkbF21BJkEuVkw2v+P/?= =?us-ascii?Q?YCFHjh0rfBpxtasq2KHEfk1cYpkqR7zBmX5FsNqR1uBkaH+uW0/rqTk1aRUJ?= =?us-ascii?Q?An445yfSJAayDnj6nogSys+TvuGL+g4bZHIOlZxReqfuEJQeuYLNpwI+25wX?= =?us-ascii?Q?h/wT4xak60C92tPXwHYrQPvBNzYuAiJ1ncGshFZlTLfTxbzBDBFV2X8EEU3U?= =?us-ascii?Q?52ESE8aKFoh5ewU4mLLV9Yii49fqg+K/PD3kVyY6oxQ30mVFHgq1zhI55lk+?= =?us-ascii?Q?d6oSDFM+f5Csb/ImGDidqDHp3Q3UD0Fylm/Mpi5Bev5VKq6N559X/U6jjKw+?= =?us-ascii?Q?R7sPk/w52w4j96uLGQWeYBlNts+tj6PgU6EUDBuMPIwCTa5h+jvtSnkU93h9?= =?us-ascii?Q?QKgsC0cW97M0T/QbJg9sEwIrdYWGziVSBodr+Tbm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8003.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32f6223e-7c2a-4209-0b7f-08dbdabd88e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2023 09:32:58.3179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kaRYU0lbflU0rdbzvxAq6x9caQyT7pv49Nqzi+c+nxTCYEKuZn41rXCuvakatLYZv7MvVW604ZbmuUbwyX5g5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4892 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, November 1, 2023 3:53 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Z= eng, > ZhichaoX > Subject: RE: [PATCH v2] net/iavf: fix coredump when exiting testpmd >=20 > Hi Kaiwen, >=20 > > -----Original Message----- > > From: Kaiwen Deng > > Sent: Wednesday, November 1, 2023 9:35 AM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, > > YidingX ; Deng, KaiwenX > > ; Wu, Jingjing ; Xing, > > Beilei ; Zeng, ZhichaoX > > > > Subject: [PATCH v2] net/iavf: fix coredump when exiting testpmd > > > > Avf releasing mbuf using the vector path release API causes a coredump > > when the basic Tx path is selected. > > This commit changes to use the basic path release API when selecting > > the basic Tx path. > Sorry, don't catch the point. > I see you changed the code when selecting AVX2 non-offload path. Confused > about what's " the vector path release API " and what's " the basic path > release API ". >=20 Hi Wenzhuo: Thanks for your review. According to the code below. "the vector path release API" is iavf_tx_queue_release_mbufs_sse. "the basic path release API" is release_txq_mbufs. static const struct iavf_txq_ops iavf_txq_release_mbufs_ops[] =3D { [IAVF_REL_MBUFS_DEFAULT].release_mbufs =3D release_txq_mbufs, #ifdef RTE_ARCH_X86 [IAVF_REL_MBUFS_SSE_VEC].release_mbufs =3D iavf_tx_queue_release_mbufs_sse= , #ifdef CC_AVX512_SUPPORT [IAVF_REL_MBUFS_AVX512_VEC].release_mbufs =3D iavf_tx_queue_release_mbufs_= avx512, #endif > > > > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kaiwen Deng > > --- > > drivers/net/iavf/iavf_rxtx.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > b/drivers/net/iavf/iavf_rxtx.c index 610912f635..a16e03d88c 100644 > > --- a/drivers/net/iavf/iavf_rxtx.c > > +++ b/drivers/net/iavf/iavf_rxtx.c > > @@ -4022,6 +4022,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev) > > PMD_DRV_LOG(DEBUG, > > "AVX2 does not support outer > checksum offload, using Basic Tx > > (port %d).", > > dev->data->port_id); > > + return; > > } else { > > dev->tx_pkt_burst =3D > iavf_xmit_pkts_vec_avx2_offload; > > dev->tx_pkt_prepare =3D iavf_prep_pkts; > > -- > > 2.34.1