From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF90742500; Tue, 5 Sep 2023 10:14:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 550F340270; Tue, 5 Sep 2023 10:14:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DBD024026A; Tue, 5 Sep 2023 10:14:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693901663; x=1725437663; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cjthVmsdWbfTfmFQiM5Y71dqau94qD/M/J8qoD1uG8U=; b=Os/RX4zG6xz1/Tlwo7tmHTHgso1RKCHAFIYNc5JzY9vS1i/vwfcGJtfQ 4uinOZK3DLSqvpFO3SKOAqIpwCdGp7Fb99hYc4wUcgAROrLVDkPFAFaaB k0USq08vOigxHOkh3DjFiqLofnYB3nW0hyomVgLKa1KetVGix0DgfA/Bg xBr3D/JkTev0J7s+8mniak73BhlXfnq+Xi5nSYdHQg8EJxoH2AiCTprXA hXn4l6l7pcWJuQZz84DBb9x+1uusXUoDbYBQxJ3kAyJJH0d82oDwLKYrO LolW0ev3xuU0eKmIGBQFiNGqt/9lrYA3EPBuISEC9gr4cDoOPQRqpH7kT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="356231547" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="356231547" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 01:14:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="770254936" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="770254936" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Sep 2023 01:14:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 01:14:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 5 Sep 2023 01:14:17 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 5 Sep 2023 01:14:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JO1tI/rRPCDdhyEFgblbLkwOjGVOc/A2qNhHsUUghljtN0BKOEOc+rteGuYddx23bjC3mnUlw2uSOEQI4gRMgSShjXNI5EwhPBbQiMolbJmlj9bRgzMBTIAW5sT8UbnBwEcZPcRp66w+5mGP8r8Q/rERObHSg6FyV5NPAA4nkhnRUWmtaX5kfHB+BO7XSVql+qNn+jcltlMIYwl9Fp49MdIbrj522OQ53d3JlPbuV2QRvAN8L7dCl4gAlm8xAQezSfvK+SXs3AVbesNciZgxqrWgdF8TLvP0ubdIexXRKR4zuhuMbDi0PD1Qwg3XRnIdk/BcKZzrXPGpXERAkGXpWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cjthVmsdWbfTfmFQiM5Y71dqau94qD/M/J8qoD1uG8U=; b=Y3kd0jgeuCURyuorlrbm/WWcG4rJLoSBmWEjZ4z2bCLOIHQN/yp+LC8vkNU5XCv94I9iTdcOEMQAYSis2zSgNQP9SEo7VCNV52p4tJ8ABrEdOp3oqSHai4QyK7eTJmLG8KkdSr5UL+oLft7zfVAwVpSc6tRzb/6xrGBk1cP5iVUuOsqcaE3IcOXDoR2WzCRRrBXUM+Z75UmAwETjYlE1k4lJIrkiI6VtlufxzcUTC983/Ng4K//o5cv5bk8Ts8U7AEkSODT9FjjQ1XbCwDHRw9as/0qKTJQkUvidUmlMUhb3dAm7xZSQ5nMPE+0J1enh6BWvGeM7jlO3/6FTqSRk8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA3PR11MB8003.namprd11.prod.outlook.com (2603:10b6:806:2f7::17) by DM8PR11MB5703.namprd11.prod.outlook.com (2603:10b6:8:22::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 08:14:15 +0000 Received: from SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cd5:b000:ac59:2480]) by SA3PR11MB8003.namprd11.prod.outlook.com ([fe80::cd5:b000:ac59:2480%4]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 08:14:14 +0000 From: "Deng, KaiwenX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Xu, Ting" Subject: RE: [PATCH] net/ice: fix tm configuration cannot be clear Thread-Topic: [PATCH] net/ice: fix tm configuration cannot be clear Thread-Index: AQHZ2kQ88LYw+7HarEi4OqQpwK5YkrAFeJ2AgAZxxOA= Date: Tue, 5 Sep 2023 08:14:14 +0000 Message-ID: References: <20230829062348.647999-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA3PR11MB8003:EE_|DM8PR11MB5703:EE_ x-ms-office365-filtering-correlation-id: 815a2304-d735-4b2a-e0f6-08dbade817bb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lAXEyt/8GQs1IWxUVnjWFeQlGjLlBFPzepxSRikYDHVLDlKqf7T8P7xVLTbYpL3iYQtziEYAvIcU1ngAxXwb43SmGQfl/5OiGEsx4Vbka7VW4tjBfPC01E/INi3vkSsYrZ3uFtQHtnNVcWAEYsc4inPvBjN+XIw4WV5z6/FXZYvQCkvljf2I2sx45Xg8V4jgVPnRa2iL3PRd0bRBHqXXxzh6WsR8y5qgUdSHdeqMp6mYSukd041WDhPjbml9FNXcISdHnqJgLMDf7fZKTww0AkIl0HBJOjo7n7IO2bin21oI6pUGH9krYwOnFYUv26yLfoyfqE09bp1qKyxnm+qBrTYxsyXRILltuuwEzGBlduMPbIACU52Y62SR9tSSDCFtKJfFZPamREKFhCK3VndRQjGo7brYHyY60SuZEFmTA4YWNSPWJRQQlIo4vGOc/UqreD3abJBwqWC0VVF+1zZKpf+n3aAUwPWKD9L/JaFitP+3+hiuOOOorfMSWaCp0sF5aIsYE3lJybDAtvaEwW92Cvk17TnZ41xpazNDOQPn+wqOc4n12UsU/XUP1I3DP1fkb7+sgcaS639WFpfcWmfyGP8nhlLUUdCXUP4Bb9V25dKN5P/0yIb8nfQCh/Qtvwhp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA3PR11MB8003.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(346002)(366004)(136003)(39860400002)(1800799009)(451199024)(186009)(9686003)(7696005)(6506007)(53546011)(38100700002)(38070700005)(107886003)(82960400001)(110136005)(71200400001)(86362001)(478600001)(122000001)(83380400001)(76116006)(66446008)(52536014)(5660300002)(4326008)(8676002)(8936002)(316002)(66946007)(54906003)(66556008)(66476007)(64756008)(450100002)(55016003)(33656002)(41300700001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ldXmhN9ezyuZb28xiCi/8Q86e//bBNkzo9LZoANDxhmIpWIwoUwAWbv0ykAY?= =?us-ascii?Q?41cI/6O46G/bDv6YkUGdZHM3VJQE1NWhlPuDGoSrN9pHT9KxlSK30HOb1tGY?= =?us-ascii?Q?hGOeb9qQ6JSWYeEgBHjZawiKTc+RyP0vxrhNtJ7yLIztcxlDixOgnfIc3anX?= =?us-ascii?Q?rEOJ3wIQNL06eRdKdr3zQ5mCNI0XpN8u9imhE+XJy2qEYq/ir5N48DophcMu?= =?us-ascii?Q?qUcPA3dtBnbYBAeSw2O0ny0wzKikZbGsmb2A8EVUqw35/CUDgNcxo2deihpj?= =?us-ascii?Q?3DFvFCmyDz5gD5E1on/3QXDhFf4tph9kzdjh1sexOZHQsD3yK4zAm3PhnMGu?= =?us-ascii?Q?WEfH+gv1IAxJVvSKDrn1RP0lqyg4MhY0N47hTewRJlZO59O6i/8bp3d1OTOM?= =?us-ascii?Q?OCWHF5BDi1H2FPrajXPoJt9h8zN+US3otrq/fXA9wGAKzMOfzefOwvsL2dLP?= =?us-ascii?Q?/WGY+6DARWgiBTDQ3bD8z2xHWyWq3KTrj/vSxU6mZDsbWdlvSzl6Y1g6b00p?= =?us-ascii?Q?l5mfkFU6fyOWU4ijTSDeFq3QcFiznavrfqBed2qwp+UcxoqE4oLfLnj1xIZM?= =?us-ascii?Q?JzLK+QMe+vmQXDDvU8huVMsIZJJssAj9Q0wOoS3Ae/MU2aNhxTKDhkyL0U6X?= =?us-ascii?Q?wdpkAZSvWPdxiuTMki2dheirU8Id24jVeO0CvdPVz1flh4oWaeUF3AUFUgS1?= =?us-ascii?Q?WtQHfxD7Ct40jDUTLe3Lh4q96ZFLpoxE4usvIpvhKG1Be9UPjNFJZAz47/kM?= =?us-ascii?Q?XFuuGzKYUGbFBworCv+OkDnGFmNn6aPgcxy4znSndlKtXjraOOTvmqH+A3TZ?= =?us-ascii?Q?S7usTrwGrtwZ5dWp5erTGhpW1AXwluZE1Zdv/MOv5G4Nbic36Oo9QseH9KpW?= =?us-ascii?Q?CpZzVq3X1FuQSeY4JJNmagJOZHkXKO5EztHDYmIEcwVHplVqcgZTTjBnr7JR?= =?us-ascii?Q?Ma+aXSlOAYIqCZf2jvKVbjQAQ0EOeRnvw98tWAMUJVl79Nf24xLrK+6yZ0gM?= =?us-ascii?Q?R/bnZUSaXRZ9TLXIajjNj4DZkBZWCAW8Sebq0EZfy3yRg2Yui5SV6/jiuBwy?= =?us-ascii?Q?+7/x4dcRugmW4BNmxWwBz2R5E6yU3W2m7/Y7YTQ3f96QQc5bixshJsM3OttK?= =?us-ascii?Q?GNQee8dEzcqml3Cp5T8p2bQv8mrwodip5AXd0NM3w1zSm1eV9n8ksLciitu5?= =?us-ascii?Q?gvxRT0KIC/uhfnNWDXONwZQkwkU/L3A3dBWyywIC4TOiJRW8fGU7jpefssEl?= =?us-ascii?Q?C0BEs/FWvMZGA8qAudCWayGroJdTII/ivGcuHkXhXIqzotnWXJwiwaKG99xj?= =?us-ascii?Q?Ei2lkKWJxtbEmoUFVCs+vwRkfU7n8S3Sh5SrbUFSRIZBUTdpzErTFQkYHnxA?= =?us-ascii?Q?AMX80zBcrytxlJyQbsQhkhLQmNf/dFQnGc/hM6Ipqns7t9mff24jFmf57iu9?= =?us-ascii?Q?B/H0mxypLK1h03sLFif+8nPGti4kNlVit/BRJfQRHZGmtdo7B5g6Y2mfo3ka?= =?us-ascii?Q?86D327+sDTApTzoqjrH9sK1LKQ4rkeVsgI4VGccv/sD7WK1mBvcmpDv+oEOR?= =?us-ascii?Q?n7Z2kwcQ3ZzTEpo2DDk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB8003.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 815a2304-d735-4b2a-e0f6-08dbade817bb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2023 08:14:14.4676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +SRLVWlkyiawVnFAmYaisPlsIS+JqZBmXE4DalAnE+qBlDvOprsvFy6bMu4dEn4dIDlPE6HBbccP5ilLht94Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5703 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, September 1, 2023 1:39 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Xu, Ting > Subject: RE: [PATCH] net/ice: fix tm configuration cannot be clear >=20 >=20 >=20 > > -----Original Message----- > > From: Deng, KaiwenX > > Sent: Tuesday, August 29, 2023 2:24 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, > > YidingX ; Deng, KaiwenX > > ; Zhang, Qi Z ; Xu, Ting > > > > Subject: [PATCH] net/ice: fix tm configuration cannot be clear > > > > When the device is stopped, DPDK resets the commit flag so that we can > > update the hierarchy configuration. >=20 > Why we need to reset commit flag when device is stopped? > If the commit flag indicate all tm configure has been committed, stop dev= ice > does not change the status, its confusing to reset it. >=20 > Can we simply prevent additional commit when device is running by only > checking the stop flag? And why we reject a commit if its already committ= ed? >>Thanks for your review, I submitted a new patch that changes DPDK to not >>reset the commit flag when the device is stopped. And we prevent addition= al=20 >>commit when device is running by only checking the stop flag. >=20 > > The commit flag is also used to determine if the hierarchy > > configuration needs to be cleared. > > When DPDK exits, it always stops the device first and also resets the > > commit flag result in the hierarchy configuration is not cleared. > > > > This patch adds a new flag "need_clear" to determine if the hierarchy > > configuration needs to be cleared. > > > > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in > > DCF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kaiwen Deng > > ---