From: Long Li <longli@microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"longli@linuxonhyperv.com" <longli@linuxonhyperv.com>
Cc: Wei Hu <weh@microsoft.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [Patch v3] net/mana: use mana_local_data for tracking usage data for primary process
Date: Fri, 21 Feb 2025 20:31:48 +0000 [thread overview]
Message-ID: <SA6PR21MB42311170DC4057B9D20C6427CEC72@SA6PR21MB4231.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20250221121114.41e3e8d8@hermes.local>
> Subject: [EXTERNAL] Re: [Patch v3] net/mana: use mana_local_data for tracking
> usage data for primary process
>
> On Thu, 20 Feb 2025 15:32:02 -0800
> longli@linuxonhyperv.com wrote:
>
> > From: Long Li <longli@microsoft.com>
> >
> > The driver uses mana_shared_data for tracking usage count for primary
> > process. This is not correct as the mana_shared_data is allocated by
> > the primary and is meant to track usage of secondary process by the
> > primary process. And it creates a race condition when the device is
> > removed because the counter is no longer available if this shared
> > memory is freed.
> >
> > Move the usage count tracking to mana_local_data and fix the race
> > condition in mana_pci_remove().
> >
> > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build
> > environment")
> > Signed-off-by: Long Li <longli@microsoft.com>
>
> Ok, mind if I break the long lines when merging?
Yes, please do.
Sorry I didn't catch this earlier. Will do next time.
Long
prev parent reply other threads:[~2025-02-21 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 23:32 longli
2025-02-21 20:11 ` Stephen Hemminger
2025-02-21 20:31 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA6PR21MB42311170DC4057B9D20C6427CEC72@SA6PR21MB4231.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=stephen@networkplumber.org \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).