RE: [EXTERNAL] Re: [PATCH 6/6] bus/vmbus: set event for channel without monitoring support

[Long Li <longli@microsoft.com>]

> Subject: [EXTERNAL] Re: [PATCH 6/6] bus/vmbus: set event for channel
> without monitoring support
> 
> On Thu, 27 Feb 2025 17:09:01 -0800
> longli@linuxonhyperv.com wrote:
> 
> > From: Long Li <longli@microsoft.com>
> >
> > For vmbus channels without monitoring support, use kernel UIO
> > interface to indicate packet through interrupt page and UIO file handle.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
> 
> Will consider for 25.07 release.
> Please fix the build issue

 I have sent v2. 

Thanks,

Long

> 
> -------------------------------BEGIN LOGS----------------------------
> ###################################################################
> #################
> #### [Begin job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test
> ###################################################################
> #################
> [703/3227] Generating symbol file
> drivers/librte_bus_pci.so.25.1.p/librte_bus_pci.so.25.1.symbols
> [704/3227] Linking target drivers/librte_bus_vdev.so.25.1 [705/3227]
> Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_common.c.o
> [706/3227] Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_bufring.c.o
> [707/3227] Generating symbol file
> drivers/librte_bus_vdev.so.25.1.p/librte_bus_vdev.so.25.1.symbols
> [708/3227] Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_channel.c.o
> FAILED: drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_channel.c.o
> ccache gcc -Idrivers/libtmp_rte_bus_vmbus.a.p -Idrivers -I../drivers -
> Idrivers/bus/vmbus -I../drivers/bus/vmbus -I../drivers/bus/vmbus/linux -I. -
> I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include
> -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -
> I../kernel/linux -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -
> Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -
> Ilib/telemetry -I../lib/telemetry -fdiagnostics-color=always -pipe -
> D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 -g
> -include rte_config.h -Wvla -Wcast-qual -Wdeprecated -Wformat -Wformat-
> nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -
> Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -
> Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-
> missing-field-initializers -D_GNU_SOURCE -fPIC -march=corei7 -mrtm -
> DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-
> truncation -Wno-address-of-packed-member -
> DRTE_LOG_DEFAULT_LOGTYPE=bus.vmbus -MD -MQ
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_channel.c.o -MF
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_channel.c.o.d -o
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_channel.c.o -
> c ../drivers/bus/vmbus/vmbus_channel.c
> ../drivers/bus/vmbus/vmbus_channel.c: In function ‘vmbus_send_interrupt’:
> ../drivers/bus/vmbus/vmbus_channel.c:35:28: error: passing argument 1 of
> ‘vmbus_sync_set_bit’ from incompatible pointer type [-Werror=incompatible-
> pointer-types]
>    35 |         vmbus_sync_set_bit(int_addr, int_mask);
>       |                            ^~~~~~~~
>       |                            |
>       |                            uint32_t * {aka unsigned int *}
> ../drivers/bus/vmbus/vmbus_channel.c:22:51: note: expected ‘_Atomic
> volatile uint32_t *’ {aka ‘_Atomic volatile unsigned int *’} but argument is of
> type ‘uint32_t *’ {aka ‘unsigned int *’}
>    22 | vmbus_sync_set_bit(volatile RTE_ATOMIC(uint32_t) *addr, uint32_t
> mask)
>       |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> cc1: all warnings being treated as errors [709/3227] Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_linux_vmbus_bus.c.o
> [710/3227] Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_vmbus_common_uio.c.o
> [711/3227] Compiling C object
> drivers/libtmp_rte_bus_vmbus.a.p/bus_vmbus_linux_vmbus_uio.c.o
> [712/3227] Compiling C object
> drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_aes.c.o
> [713/3227] Compiling C object
> lib/librte_pipeline.a.p/pipeline_rte_table_action.c.o
> ninja: build stopped: subcommand failed.
> ##[error]Process completed with exit code 1.
> ###################################################################
> #################
> #### [End job log] "ubuntu-22.04-gcc-stdatomic" at step Build and test
> ###################################################################
> #################