* [PATCH] net/netvsc: add stats counters from VF
@ 2025-02-18 21:13 longli
2025-02-19 6:12 ` [EXTERNAL] " Wei Hu
0 siblings, 1 reply; 3+ messages in thread
From: longli @ 2025-02-18 21:13 UTC (permalink / raw)
To: Stephen Hemminger, Wei Hu; +Cc: dev, Long Li, stable
From: Long Li <longli@microsoft.com>
The netvsc driver should add per-queue and rx_nombuf counters from VF.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_ethdev.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 988c51928d..069d603d90 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -824,8 +824,8 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
stats->oerrors += txq->stats.errors;
if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
- stats->q_opackets[i] = txq->stats.packets;
- stats->q_obytes[i] = txq->stats.bytes;
+ stats->q_opackets[i] += txq->stats.packets;
+ stats->q_obytes[i] += txq->stats.bytes;
}
}
@@ -841,12 +841,12 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
stats->imissed += rxq->stats.ring_full;
if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
- stats->q_ipackets[i] = rxq->stats.packets;
- stats->q_ibytes[i] = rxq->stats.bytes;
+ stats->q_ipackets[i] += rxq->stats.packets;
+ stats->q_ibytes[i] += rxq->stats.bytes;
}
}
- stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
+ stats->rx_nombuf += dev->data->rx_mbuf_alloc_failed;
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
2025-02-18 21:13 [PATCH] net/netvsc: add stats counters from VF longli
@ 2025-02-19 6:12 ` Wei Hu
2025-03-07 17:22 ` Long Li
0 siblings, 1 reply; 3+ messages in thread
From: Wei Hu @ 2025-02-19 6:12 UTC (permalink / raw)
To: longli, Stephen Hemminger; +Cc: dev, Long Li, stable
> -----Original Message-----
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> Sent: Wednesday, February 19, 2025 5:13 AM
> To: Stephen Hemminger <stephen@networkplumber.org>; Wei Hu
> <weh@microsoft.com>
> Cc: dev@dpdk.org; Long Li <longli@microsoft.com>; stable@dpdk.org
> Subject: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
>
> From: Long Li <longli@microsoft.com>
>
> The netvsc driver should add per-queue and rx_nombuf counters from VF.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/hn_ethdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 988c51928d..069d603d90 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -824,8 +824,8 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
> stats->oerrors += txq->stats.errors;
>
> if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> - stats->q_opackets[i] = txq->stats.packets;
> - stats->q_obytes[i] = txq->stats.bytes;
> + stats->q_opackets[i] += txq->stats.packets;
> + stats->q_obytes[i] += txq->stats.bytes;
> }
> }
>
> @@ -841,12 +841,12 @@ static int hn_dev_stats_get(struct rte_eth_dev
> *dev,
> stats->imissed += rxq->stats.ring_full;
>
> if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> - stats->q_ipackets[i] = rxq->stats.packets;
> - stats->q_ibytes[i] = rxq->stats.bytes;
> + stats->q_ipackets[i] += rxq->stats.packets;
> + stats->q_ibytes[i] += rxq->stats.bytes;
> }
> }
>
> - stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
> + stats->rx_nombuf += dev->data->rx_mbuf_alloc_failed;
> return 0;
> }
>
> --
> 2.34.1
Reviewed-by: Wei Hu <weh@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
2025-02-19 6:12 ` [EXTERNAL] " Wei Hu
@ 2025-03-07 17:22 ` Long Li
0 siblings, 0 replies; 3+ messages in thread
From: Long Li @ 2025-03-07 17:22 UTC (permalink / raw)
To: Wei Hu, longli, Stephen Hemminger; +Cc: dev, stable
> -----Original Message-----
> From: Wei Hu <weh@microsoft.com>
> Sent: Tuesday, February 18, 2025 10:12 PM
> To: longli@linuxonhyperv.com; Stephen Hemminger
> <stephen@networkplumber.org>
> Cc: dev@dpdk.org; Long Li <longli@microsoft.com>; stable@dpdk.org
> Subject: RE: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
>
>
>
> > -----Original Message-----
> > From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> > Sent: Wednesday, February 19, 2025 5:13 AM
> > To: Stephen Hemminger <stephen@networkplumber.org>; Wei Hu
> > <weh@microsoft.com>
> > Cc: dev@dpdk.org; Long Li <longli@microsoft.com>; stable@dpdk.org
> > Subject: [EXTERNAL] [PATCH] net/netvsc: add stats counters from VF
> >
> > From: Long Li <longli@microsoft.com>
> >
> > The netvsc driver should add per-queue and rx_nombuf counters from VF.
> >
> > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> > Cc: stable@dpdk.org
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > drivers/net/netvsc/hn_ethdev.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/netvsc/hn_ethdev.c
> > b/drivers/net/netvsc/hn_ethdev.c index 988c51928d..069d603d90 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -824,8 +824,8 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
> > stats->oerrors += txq->stats.errors;
> >
> > if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> > - stats->q_opackets[i] = txq->stats.packets;
> > - stats->q_obytes[i] = txq->stats.bytes;
> > + stats->q_opackets[i] += txq->stats.packets;
> > + stats->q_obytes[i] += txq->stats.bytes;
> > }
> > }
> >
> > @@ -841,12 +841,12 @@ static int hn_dev_stats_get(struct rte_eth_dev
> > *dev,
> > stats->imissed += rxq->stats.ring_full;
> >
> > if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> > - stats->q_ipackets[i] = rxq->stats.packets;
> > - stats->q_ibytes[i] = rxq->stats.bytes;
> > + stats->q_ipackets[i] += rxq->stats.packets;
> > + stats->q_ibytes[i] += rxq->stats.bytes;
> > }
> > }
> >
> > - stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
> > + stats->rx_nombuf += dev->data->rx_mbuf_alloc_failed;
> > return 0;
> > }
> >
> > --
> > 2.34.1
>
> Reviewed-by: Wei Hu <weh@linux.microsoft.com>
Hi Stephen,
Is it okay to merge this patch?
Thanks,
Long
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-07 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-18 21:13 [PATCH] net/netvsc: add stats counters from VF longli
2025-02-19 6:12 ` [EXTERNAL] " Wei Hu
2025-03-07 17:22 ` Long Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).