From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC1843B2D; Tue, 20 Feb 2024 06:48:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96DFD402CB; Tue, 20 Feb 2024 06:48:06 +0100 (CET) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2108.outbound.protection.outlook.com [40.107.255.108]) by mails.dpdk.org (Postfix) with ESMTP id 0C2AE4029B for ; Tue, 20 Feb 2024 06:48:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlhSqglDFeYGrz0dhus1RZtgRd5XwwNRn1LJxhD+npFrhdE0rsbEJvmpL6Q7UcZi8g+a6DI0KTeokh9AKIBMRKSMN+WzsmKAKz6lm/Djrya1eqr63SV6pWYrkjCdYSUHTAAtHXxQ4/UJrdDJzEQVbzI0Zm2hOAiTt9L5Zn2u0cJI+h1VJUGVP/jGvvOtAxms/oLEAWX76LQYtECVb6GuMZS6VwWFUeP2VnLZcPTX5gAvTIJqMOVqQEJLRE/y22MDLT/m+nN26ImM5k1hZnyVsSJWwGebnzq00BJQmlWr4YzxqaNxJIhctqvNkZNPBhbz119XUfnUEoK0yjnEOiE7XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaO/PqIifAWA7KwJV9RvV0qUfEvUG85khUv5dYLhTW0=; b=kIcnGn3WOyWZbgieTfReWsasO/eeK4aIeK7bM8gXa9RxJSMvdhX5WlVp+MSSinoKr2F0DA8Hwilb1g4o1hd2/VbFDQTii4eGRP9BYOedg3EzILSR7twQW3jzF+GR2+cxZmr3BD8xQLfyCvQWmyX0kNnp4lL0pihmgh/kPv5pWzV3JNRhwJ5wb8WX/ZdABZUoSWMEKs+7qeqM6CvAv/yxMg5SMIWE8yDAEmWligiNAVBWwU4s378XJE8yJgYcPOOeI193u5XmMnr0OZgiuvcKv51C+4QquXs9dURnbTURbN1+Htxxt1zcy21P2Qpb4+s0LZCx3Lg3oWb4cHLWShGKqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OaO/PqIifAWA7KwJV9RvV0qUfEvUG85khUv5dYLhTW0=; b=CDbzNfPuk4H1UKbaU32DdzAy2Chhb0grQcomqEQwdi3sZiJZMjtnpWJNnJpP6YVnv/md1wAhR0gDa4FOOTADW0nF1zhNShgia6/gKq0KIUJr2a6xPEDUVyZ+8hl6hU3bou3dOFYN0R/Is7Ukuf/5EbXm0xQ9hnIE2by2LgLEMpo= Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM (2603:1096:4:fc::7) by TYZP153MB1020.APCP153.PROD.OUTLOOK.COM (2603:1096:405:42::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.0; Tue, 20 Feb 2024 05:48:01 +0000 Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::55c4:538c:b721:7d73]) by SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::55c4:538c:b721:7d73%4]) with mapi id 15.20.7292.013; Tue, 20 Feb 2024 05:48:01 +0000 From: Wei Hu To: Long Li , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Thomas Monjalon , Alan Elder CC: "dev@dpdk.org" Subject: RE: [PATCH 1/1] net/mana: add vlan tagging support Thread-Topic: [PATCH 1/1] net/mana: add vlan tagging support Thread-Index: AQHaWzVvp97uzvSFOkuw95vL7FwG2bECWqSAgBBZyhA= Date: Tue, 20 Feb 2024 05:48:01 +0000 Message-ID: References: <20240209085211.2643148-1-weh@microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=2acdfd2d-4532-4882-b975-76beea55277b; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-09T18:40:02Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SI2P153MB0441:EE_|TYZP153MB1020:EE_ x-ms-office365-filtering-correlation-id: d37aadd3-a572-41fe-d04c-08dc31d77fc4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hMPgiuN0Ek6ge22KMfvkObYJlIAuUzjUZLxwWFM8owK0rdRzMyisNkmQUFCoCITugf5y/xEHKNd6aUQ3fe4E+z0ef+jxzKlz6iNiqjHEsqi8RnBwOIgSlQJ4MtafMAXtKfgAfovYoCCvUW5WTFvVoJ+BNANxW1Imkl9pcHICllew8w3ynWrE9HCXzwuZX2QDZ2vbHZkwnXzqnLiflbp75WHeYDqUqMGf1c0a9gOZbSdPx+fXiv8tH0HoIXILSBc4A/U6u2nqgfwYijBzYMx5zRtj0RE+YvBpMY+I8fkCq9S1JWbBMTjGGPBpEU2LpJw3Vgdh6aB2d5MGTCvqaqq4UnNlkKAH6au/MBlQKvHOs6gtQQKyMwJuC7ow43HkPc+PuF+K9jlfkeTKXte6xoJcIP5m50B1n1IEmbEo3WJVOgY+uAG0cmQsGHAVlVQmAABqVAJCGdh4aZPviK/3u/GMVRaxGPsrKdt3sw6SIUNDpAefbwl1ZFBhh1n0LxbwEfR14DfsQxTOtlj3gSL8m5/Pry9jmsUg+9P2WukiWNKHtmCNj4GAW2FUTWl1dfqvWORFiB0WNyYI2vW6h4A5HDVuBKnocaIwlEspWIZrRDLYhrj0cbDfwvStHWh2dIt+bzuw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SI2P153MB0441.APCP153.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/O0xgMBu3EPyGO333kaFWeIq8g8ugpftOTXroLUnYSun7pMMnhgp8ZxQRGFK?= =?us-ascii?Q?IP+0h3oHOkJwhIz4YCVXq+MusAtX4YOAd2WBdrCE1zsdytQa91I5ZUETp/6H?= =?us-ascii?Q?VCQuRGZ4E/vKC8FKI+aXRkEmKAXXmm82LZWVQckegK5KUilbmcLx+ePkjp6a?= =?us-ascii?Q?V0Ova23mAbSDp2mJhwp1Th4sKeBbxRsKz2OeqH6zXXx7drD5QpYwpbqWm1I2?= =?us-ascii?Q?OneoKn6iZOzJcsCRvH/wbS0EzNqkYD1CV+i1zbNfMnu/Oa13RfcluQ+aNSum?= =?us-ascii?Q?Slqzcy4zsu82hmrEBbVwBHADezduFW4xVyITX8NXRLDA5F7ydN9cauOaLSqG?= =?us-ascii?Q?XsT2nhAdZIv38Vei3fIUaMIQL7azECxI+ivpZE0TS+Kt7n+PMufNumjmwzbj?= =?us-ascii?Q?+Ds6rqMJ3wOI2xakVN1XHA/5uOLmNAC+ykc4+sGRL46kn30CnPrVuWwQPk1/?= =?us-ascii?Q?XgaCGX1cpQZ9gM4NTdRWp8uDY9cBI8GXlBd/pq3HQnVecu2vXEkInBkOtzMC?= =?us-ascii?Q?kKv8pnox8uX5Rh3WtNtr4OSuI6pVjmdDqyAkx35k27XFZU9XZAC4feCr0S+q?= =?us-ascii?Q?zlBqLbUQqj6CUcTHLdXqOov7CkHWux+K2kZcGtFFUvE2lfC+mRQCo5Mhdaih?= =?us-ascii?Q?mbsn1m59D4M9r110pqncIFJN5cUee4b1H+wXo9y0tLBudaNHkFSVgmrXQbbb?= =?us-ascii?Q?9XM86K+0aXj99/+hdgk2wCZ3edy6IoyIpn2l5fUsKsqK/2qX5GVSOAvqi0ES?= =?us-ascii?Q?1YxVDMFQW5Ag72JS/1+0Nbvk7MhDjz61f1gPXKQ1/OC+NXWHcIVsedfgTWPl?= =?us-ascii?Q?BOAnZ7VHC4Y31xsbfbiejr60UYyI5BlMrKzxgWBzFs/+wi4+PXl3oEtr2iIA?= =?us-ascii?Q?RR84POH9ivEMptW2kdR1iJwJiSidyTG0JSQsj1683lxu7BQaeXtE7cougwaw?= =?us-ascii?Q?byx6UJK2rDEBzlqPw/5hPRJ6t6GAtSx2sYKI2Xl8ZnfRDczFZN38wAfUq/qD?= =?us-ascii?Q?JcBY0Lj7HNXuJBfbmZRx3LdIxG4I+krU7poqPDMwUwKbObcLa6nl+z59O4eq?= =?us-ascii?Q?xGhpjXW+yH7dgeOEAG66PCW8lNekVqS7sPzk440sZKlJqeyO0omyJGVHfobY?= =?us-ascii?Q?9523mIp0dTtyZhPAbtdttI+OQi/LMWFcHarniI/7+XXn+0g4fq5Ft1ocyKh1?= =?us-ascii?Q?nlZYwNb4DO4HmKSd45mbeskROO8K5m3cB/f+Ux3zbhY0HHc01QySHekWdhSv?= =?us-ascii?Q?7pKZ5t8UVLHQ57zBMp6ggk+1MrKDtTKnM5m30zDnCcBgpScmCjkpiZOlMDjZ?= =?us-ascii?Q?hQLH3gj+ja96oCvsos00tKyKmMGKOnjTh2cBmO/7BEg84JNc4DyhhvwWPKye?= =?us-ascii?Q?GSFQmTj2sGs6Zq9umY0DhM2UOS1JuQxfEvhswraXkRS4Qf8crl5ExJ+3wd/w?= =?us-ascii?Q?QggzrFVE2XqDeQevmPYp9XZ94sejPqteZ+1erFVsVMx1H+LBEEF8A4dNK3m5?= =?us-ascii?Q?CltwSnKFoAx9+JGWhTFUV1CPeiRzMc076VQ1aRo8bZsG0GS7jIaAE+MuMSwi?= =?us-ascii?Q?wPynTJ/D+ZpRGB0xWas=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SI2P153MB0441.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d37aadd3-a572-41fe-d04c-08dc31d77fc4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 05:48:01.0858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9nAAqfXf+EIx7EbYHPUJ5BXIRSp/nE/ylkbrIUwDMi7AeBBtEhoc7ZFUqXXkhEay2SE7Au+3ID+13v8FTQ49sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZP153MB1020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Long Li > Sent: Saturday, February 10, 2024 2:48 AM > To: Wei Hu ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Thomas Monjalon > ; Alan Elder > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/1] net/mana: add vlan tagging support >=20 > > + if (oob->rx_vlan_tag_present) { > > + mbuf->ol_flags |=3D > > + RTE_MBUF_F_RX_VLAN | > > RTE_MBUF_F_RX_VLAN_STRIPPED; > > + mbuf->vlan_tci =3D oob->rx_vlan_id; > > + } > > + >=20 > Netvsc has the following code for dealing with vlan on RX mbufs (in hn_rx= tx.c): > /* NDIS always strips tag, put it back if necessary */ > if (!hv->vlan_strip && rte_vlan_insert(&m)) { >=20 > It seems we should do the same? Not sure if we want to do the same. Two reasons.=20 1. Searching the netvsc source, I don't see a place that it set hv->vlan_st= rip to false. It means !hv->vlan_string is always false, and rte_vlan_insert(&m) never run.=20 2. Usually vlan_strip can be set to true or false if the hardware supports = this feature. In the mana case, the hardware strips off the vlan tag anyway. There is no way to tell = the mana hardware to=20 keep the tag. Adding the tag back by software not only slows things down, b= ut it also complicates the=20 code and test. Not sure if there is any real application needs it.=20 I am open to add it. But in my opinion, we don't need it. Let me know what= you think. >=20 > > pkts[pkt_received++] =3D mbuf; > > rxq->stats.packets++; > > rxq->stats.bytes +=3D mbuf->data_len; diff --git > > a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c index > > 58c4a1d976..f075fcb0f5 100644 > > --- a/drivers/net/mana/tx.c > > +++ b/drivers/net/mana/tx.c > > @@ -180,6 +180,15 @@ get_vsq_frame_num(uint32_t vsq) > > return v.vsq_frame; > > } > > > > +#define VLAN_PRIO_MASK 0xe000 /* Priority Code Point */ > > +#define VLAN_PRIO_SHIFT 13 > > +#define VLAN_CFI_MASK 0x1000 /* Canonical Format Indicator > > / Drop Eligible Indicator */ > > +#define VLAN_VID_MASK 0x0fff /* VLAN Identifier */ > > + > > +#define mana_mbuf_vlan_tag_get_id(m) ((m)->vlan_tci & > > VLAN_VID_MASK) > > +#define mana_mbuf_vlan_tag_get_cfi(m) (!!((m)->vlan_tci & > > VLAN_CFI_MASK)) > > +#define mana_mbuf_vlan_tag_get_prio(m) (((m)->vlan_tci & > > VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT) > > + >=20 > Those definitions look like those in @Alan Elder's patch for netvsc. Can = we > consolidate some of those definitions into a common place? >=20 > Maybe in "lib/net/rte_ether.h"? >=20 Ok. Will add it to rte_ether.h. Thanks, Wei > Thanks, >=20 > Long