From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] raw/ioat: fix ring space checks
Date: Wed, 12 May 2021 16:11:46 +0000 [thread overview]
Message-ID: <SJ0PR11MB5055E1A21B2F4D3651614BC5FC529@SJ0PR11MB5055.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210512145000.249215-1-bruce.richardson@intel.com>
> When enqueuing a descriptor, when checking that there is at least one
> slot free for the current descriptor and a later batch descriptor, we
> need to test for both two free and one free, in case the last write
> was a batch descriptor which is allowed to use the "spare" slot.
>
> Similarly, when computing the free space in the ring to return to the
> user, we need to take account of the same condition, so that we do not
> return a "-1" ring space value, by blindly subtracting "2".
>
> Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")
>
> Reported-by: Jiayu Hu <jiayu.hu@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
<...>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
prev parent reply other threads:[~2021-05-12 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 14:49 Bruce Richardson
2021-05-12 14:50 ` [dpdk-dev] [PATCH 2/2] raw/ioat: remove special case for no status reporting Bruce Richardson
2021-05-12 16:11 ` Laatz, Kevin
2021-05-12 18:49 ` Thomas Monjalon
2021-05-12 16:11 ` Laatz, Kevin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5055E1A21B2F4D3651614BC5FC529@SJ0PR11MB5055.namprd11.prod.outlook.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).