From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79299429DB; Mon, 24 Apr 2023 15:50:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ACA1410D0; Mon, 24 Apr 2023 15:50:13 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 74EF040FAE for ; Mon, 24 Apr 2023 15:50:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682344211; x=1713880211; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3s74L/GO8p7+SP5Pb1bCj5EVCLn1xMlXh5aqRUNjc38=; b=Tg9sE41dmI5Jmqz9y5zemtJGCwoZ5arPUWgXoxolCdmNlpo1TvLiJ0uS Z8XYu8AYHWhfRA1Q2dzPjTKWtGz22RJPdjnUY8IOn9U8XnM7bMgtcUDID Q2fphmIIn3T4ntvgBCzNJDAzqN+uHGI0E14WtmlPqakSAd+Og5rrHzBld EXqc9ZEAEB2VRLM92MkbZXaVBSCj9dlPYPix4aV6e4QYaJOnotiZqjVA7 7xYcholGEVJJ0hs8hhVnIa2Ck5RVS1puO7U+1n1tOa0svXoY1fzFBDy6l SkdGIzFzh2+jxFfFDJsPBt8f+fu6B9wbWR5gg+PakAYbq3JCOSio/1EU8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="374403811" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="374403811" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 06:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="939333737" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="939333737" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 24 Apr 2023 06:49:18 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 06:49:18 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 06:49:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 24 Apr 2023 06:49:18 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 24 Apr 2023 06:49:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKml6bnG7O2GGWP+l+JrRKpja2opSmtMLl7khY8JLbIr/PiYjBdBE/wDZDYIsWuyQQBqQb4U+yYYuNWQC7baR+s1V5UUbOj9QmDnTGIAFQPhQ1PoXuom2WoaAAr/9uncxj2Yz3GXwfwea05wmrSJTksEwm/qH/Te4JD4cy49JxYkoMhPHM3Cemzo4pJWfyWBdCYBaFBTQ/GatJ8c/5njPZUgVLflQRGfPKCcuRn4sNm9ygd+Hpc3kkV5cIuW1lFB5aveGC1qM5rvIzyWD1s92e7gDPeWnJXFe1B4QgXJGsRoK+VYiFn+8x9AYqInhK1UxjNVbvrHx0i1uhc7zncfBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PHxfLTuXT2vYG0WYVM4T0KHX0lMTAlsvnSHXfiM0s+s=; b=Rya8c8Yh7keFV0vYbupKF3TqAPjbFpUAKepV8cnPF2RSFwSc6CA8w82vEo5hX95b0qZmM0CAAh4f1QpSrzOT7N5fKaFtYUy+4G8fyHDt2yJYH9uqOUkJTbxwhDHa4rJIRlnjQr0U3m9nn4JOHMsszdHoCWocJrUFefDI2F7aSSGnils5rOJKp5jdvfK8grfzosrJLNC08hfVjANnFZ/hNUNaDutAq1C2nNOGaJZFWV9PvdlsngkdcB0p3kJtUuiGjpa/kHzjMiudfOXRjH6n8ehF3s/tYwBSzc+77EpikwtOITEvrAIV1oHNCnFQ0WQao3nZabJaOxxr+jTjaNk1LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5056.namprd11.prod.outlook.com (2603:10b6:a03:2d5::6) by PH0PR11MB5032.namprd11.prod.outlook.com (2603:10b6:510:3a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 13:49:15 +0000 Received: from SJ0PR11MB5056.namprd11.prod.outlook.com ([fe80::21e8:6de3:4f83:fb80]) by SJ0PR11MB5056.namprd11.prod.outlook.com ([fe80::21e8:6de3:4f83:fb80%5]) with mapi id 15.20.6319.033; Mon, 24 Apr 2023 13:49:15 +0000 From: "Dooley, Brian" To: Akhil Goyal , "Ji, Kai" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted feature in AESNI_MB Thread-Topic: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted feature in AESNI_MB Thread-Index: AQHZdDnmgt+1eLxhH0WCG8TAWBFeZ68597MAgACGYjA= Date: Mon, 24 Apr 2023 13:49:15 +0000 Message-ID: References: <20230421101310.420593-1-brian.dooley@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5056:EE_|PH0PR11MB5032:EE_ x-ms-office365-filtering-correlation-id: d2cf2b1a-047f-41e8-1fe3-08db44cab19c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: swU8LLgYIDgiLdOjVYeov1UcRtBZ9tAku60ssUwD8owcl1Lx1WzemSWbc13ZRIj4rDFCEMfkgsb1fH8+EDE5ZjKbMEL0Mg8cNOm27CMrF7bRUAY6K7h+kMFGy+hib1hrNhqmSp0Pm5zvV0f/ykgexa3pvWJSvogxLknU9X91THjHdLVu543SrnUZ4E5x0RqqaT45L5FiKZTThkpSqwQci1VLm4tU7IEAt2uaKIeSlCHKXz9TzJqv3T6SnoXhh6UsT0qOUbZtGcu4hjLz3zFM1at243J051EXUdJfqrVqqSzWBK2R8nzRpqm7Nf0BSBKTflHoUfUcgQ/0ej+H03FjnjbmGr1EkaILV/fyVNQbEEC3vBpNUk/87D68/Lw2KJj37DtUSiiyFwV/91gih4QgRN9+YVBZmW6UkcsL0M3eUQz5FHY4j4VXkgXebIb4T8toBRw+A6O2VWYaNHShOBsyuSHVy8iHUam7v8029xvmGODvYMUUhokvra99WS3c3cHXVAMCUwnNvwm172XKVb7urEKqttBjBwVmLUC63kB9UivRYdk6SNzXUre6OjuJPFp1U9HVGZE0+f+9a3DyWaoLANOmf0lq//b9QuAdqt74915Art3pPavkJ2WmgEKPJldm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(376002)(346002)(39860400002)(136003)(396003)(451199021)(478600001)(110136005)(6636002)(86362001)(186003)(53546011)(7696005)(26005)(9686003)(6506007)(55016003)(33656002)(71200400001)(4326008)(64756008)(66446008)(66476007)(66556008)(316002)(82960400001)(83380400001)(66946007)(76116006)(2906002)(38100700002)(122000001)(41300700001)(8676002)(8936002)(38070700005)(5660300002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YuD3zi1TEu+g4BPiuGs9nIfOtosX+X/L1XfdqAyYDhUf0eNT26+B9ML7j6L7?= =?us-ascii?Q?BM4QI/anneuYF6Xs2J+d07kD4wOS8VTPPuhmGn6Jnpq//XPwVB2LuR5sFP1R?= =?us-ascii?Q?7oxGJBH8iLa70jUY0AZX6tJGArhmvPl5I0bQ+L05OCgFlBiQKEs+NL8AbueW?= =?us-ascii?Q?KroT4IgCUq13U8a65GSekYjAbrPcGnmAkH0qEAjK1VbGroot1uTbZl/ZlI4e?= =?us-ascii?Q?btuIuqWhhuhvDSr5kUdF6m6s7k7aKuQLcpQ+6/aQgK/SDOaQE9FKE1d1aIkE?= =?us-ascii?Q?PQs350PWoGRYcrK4ZCdjEQRecuSTj/1Sw9VkYImx3PxOT4FuhmZmc8rU3t31?= =?us-ascii?Q?DIvVUWBqZXZOReVHH8CWs2zgk35yoTkzmGQrwFRnBHBKdq+q7fv7Ho5st5e7?= =?us-ascii?Q?+mqcy7EQrrH0IvmVxIZChasjCsYUgXBR7/T5Yi8k5znquP2KajuLB94PcM7x?= =?us-ascii?Q?5aZhR1Xas9xzYmZhAIGDBXS7dJsmtq55Q+fsl3Iut8cSOJJuG/KIvNCqXD+I?= =?us-ascii?Q?602dTPSEGlnVysm8HFRQ5sjwxTlvENxHDPDLeuDyAoSJNa5SuslQ5T2kvWrP?= =?us-ascii?Q?Y7GMcAHm59s39xBfJ9QyzwtvXPw3ulyu0CYIW+/LOjm0fbXPrq7CjV9aT6T0?= =?us-ascii?Q?batb/Z9EclpKy2s7EYQpNu194P2QBw29S/vnAWo2n4lx6CwJoLhAxpp0l+U6?= =?us-ascii?Q?gb7UIP9Vh/iX85d12MTs6Wmwo1B3pF3CHuENjhVeUrmN2ulroB+rS6DzdbXv?= =?us-ascii?Q?GpZP4DwA/wgT2oJNbgF/TlxngdPoV6glzgSpUzMMNGYScXcv1z0fKJLxwoqX?= =?us-ascii?Q?09ktVRBvC/Y+acIolg/0C7h7ainlrUhloLs8qZd7lv0jiyBuFIv2YNt16Uya?= =?us-ascii?Q?oJiIRP5FYXuIZFeoPDHTrmq0pdUoWmyR+TKLJAdeYsPRWLWsOZOHg07X+zaQ?= =?us-ascii?Q?9ZzkL+XJKm4OR/suqF0aS1QTD7XNqRkpjT1GfXawSNMorcUBsZC/dGLq5LDb?= =?us-ascii?Q?lr8y7XNjYjqJ9tpQjKECthuC5yZQi87ImN8+9S3Fed+4x0NKok91CTJU23hJ?= =?us-ascii?Q?PaqiALlVmONVDHavOIGxDCON8cY2pcj3rxgbfrxZ1XDEzj0jVobUd6IoIaVH?= =?us-ascii?Q?cQu65EjIKUd2uJdKA6UnMeS0+FsvPYa/YezKTetw60P4lHIA1n2bhZdjn/Zy?= =?us-ascii?Q?8JAT1CYhrWO3efr3wYu9gofDgTHwnqGfw+fPIVUdZ0m/NxgpKYvOTN+5qdrQ?= =?us-ascii?Q?EqbnUriy6oXOkDagosxbLHvEWK5YEpvXXWfYAGmACXzKXhET0pKCwT26ricg?= =?us-ascii?Q?0EXH8H2pwbh/ztnAEJCTwqjiAxF/zTH4xpNkgVEAJP4ZbWZA1Jsxi4igXenF?= =?us-ascii?Q?aesIGkTKWDenm7/LVTbJhRFV8fYNg78badcWIKQr8eVy0qgWnBIfV7fLPh2H?= =?us-ascii?Q?jT84s5SxIXVKzbY1X93KmfkweBfwunDLuY7il5PYWNpK62lLAKVIKDyNzK+r?= =?us-ascii?Q?A9TYzoHk8oVdSzXkiWCAufsZIatOz+0ZLEKY0EDOF0QkI39kiutoysT0H2zp?= =?us-ascii?Q?787S7mRzIMxpgb6cwH1JfHdyrpyCDmpjYys1V83P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2cf2b1a-047f-41e8-1fe3-08db44cab19c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 13:49:15.6450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zAFVJgbXZV6Qj7Eq++zOm/SKXl9wtmfsVc8U2Xq9pKMU9n79hp5j0naihF0k73aQ9hVwFaN1SMfPBDPx03Y51g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Monday 24 April 2023 06:46 > To: Dooley, Brian ; Ji, Kai ; D= e > Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted featu= re > in AESNI_MB >=20 > > Subject: [EXT] [PATCH v1] crypto/ipsec_mb: add digest encrypted > > feature in AESNI_MB AESNI_MB PMD does not support Digest Encrypted. > > This patch adds partial support for this feature. >=20 > I do not get it, what is the point of adding partial support. > It should be added when it is supported. > Also whenever, you add, add in documentation as well. Apologies for this, This patch has a bit more work to do and should have be= en an RFC. Confident that it can be completed for the release. >=20 >=20 > > > > Signed-off-by: Brian Dooley > > --- > > Some out-of-place tests are still failing. > > Only some in-place tests are passing. > > Working on adding support for this feature in v2. >=20 > You cannot just send half cooked patches. >=20 > > --- > > app/test/1.diff | 0 > > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 3 ++- > > 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 > > app/test/1.diff > > > > diff --git a/app/test/1.diff b/app/test/1.diff new file mode 100644 > > index 0000000000..e69de29bb2 > This file is accidently added. Thanks, Brian