RE: [PATCH v2] common/qat: enable QAT 2.0c devices

["Dooley, Brian" <brian.dooley@intel.com>]

Hi Ciara,

> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Monday, August 21, 2023 10:34 AM
> To: dev@dpdk.org
> Cc: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>;
> david.marchand@redhat.com; Power, Ciara <ciara.power@intel.com>; Ji, Kai
> <kai.ji@intel.com>
> Subject: [PATCH v2] common/qat: enable QAT 2.0c devices
> 
> This commit enables QAT 2.0c devices in the Intel QuickAssist Technology
> PMD.
> These are 4th Generation QAT, 402xx devices.
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> 
> ---
> v2:
>   - Fixed kernel module.
>   - Modified commit to align naming of new QAT device.
> ---
>  doc/guides/cryptodevs/qat.rst          | 4 ++++
>  doc/guides/rel_notes/release_23_11.rst | 4 ++++
>  drivers/common/qat/qat_device.c        | 4 ++++
>  3 files changed, 12 insertions(+)
> 
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index afdfb0bd22..730113da33 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -457,6 +457,10 @@ to see the full table)
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+-------
> -+------+--------+--------+
>     | Yes | No  | No  | 4   | 401xxx   | IDZ/ N/A      | qat_401xxx    | 4xxx       |
> 4942   | 2    | 4943   | 16     |
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+-------
> -+------+--------+--------+
> +   | Yes | Yes | Yes | 4   | 402xx    | linux/6.4+    | qat_4xxx      | 4xxx       | 4944
> | 2    | 4945   | 16     |
> +   +-----+-----+-----+-----+----------+---------------+---------------+------------+------
> --+------+--------+--------+
> +   | Yes | No  | No  | 4   | 402xx    | IDZ/ N/A      | qat_4xxx      | 4xxx       | 4944
> | 2    | 4945   | 16     |
> +
> + +-----+-----+-----+-----+----------+---------------+---------------+--
> + ----------+--------+------+--------+--------+
> 
>  * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with
> IDZ driver version 4.9.0+
> 
> diff --git a/doc/guides/rel_notes/release_23_11.rst
> b/doc/guides/rel_notes/release_23_11.rst
> index 4411bb32c1..72dfb3fbf0 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -72,6 +72,10 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
> 
> +* **Added support for QAT 2.0c devices to Intel QuickAssist Technology
> +PMD.**
> +
> +  * QAT 2.0c (4944) devices are now enabled for QAT.
> +
> 
>  Removed Items
>  -------------
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c index 2675f0d9d1..cbf1e6a988 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -50,6 +50,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
>  		{
>  			RTE_PCI_DEVICE(0x8086, 0x4943),
>  		},
> +		{
> +			RTE_PCI_DEVICE(0x8086, 0x4945),
> +		},
>  		{.device_id = 0},
>  };
> 
> @@ -202,6 +205,7 @@ qat_pci_device_allocate(struct rte_pci_device
> *pci_dev,
>  		break;
>  	case 0x4941:
>  	case 0x4943:
> +	case 0x4945:
>  		qat_dev_gen = QAT_GEN4;
>  		break;
>  	default:
> --
> 2.25.1

Acked-by: Brian Dooley <brian.dooley@intel.com>