Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

["Jiang, YuX" <yux.jiang@intel.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jim Harris
> Sent: Friday, November 5, 2021 11:54 PM
> To: dev@dpdk.org; Hunt, David <david.hunt@intel.com>;
> david.marchand@redhat.com
> Cc: Harris, James R <james.r.harris@intel.com>
> Subject: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error
> 
> clang-13 rightfully complains that the tot_ppi variable in update_stats is set
> but not used, since the final accumulated tot_ppi results isn't used anywhere.
> 
> Original idea was to just remove the tot_ppi variable, but feedback from
> David Marchand on mailing list was that the related ppi_av array in struct
> priority_worker wasn't useful and should be removed. This allows us to also
> remove num_dequeue_pkts_prev and pc from struct priority_worker since
> they are only used in conjunction with the ppi_av array.
> 
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
> ---
Hi Jim and David,
We verify this patch http://patches.dpdk.org/project/dpdk/patch/20211105155351.350403-1-james.r.harris@intel.com/ based on dpdk21.11-rc2 main branch(f4801fdb7828f45ddc4ada148b1b0a230a226570), still verify failed.
Could you pls have a look again?

Verified OS details:
Tested Failed on OS Fedora35/Kernel 5.14.16-301.fc35.x86_64/gcc version11.2.1/clang version 13.0.0/ninja version 1.10.2

Failed log details:
[root@dpdk-Fedora34-64-gcc dpdk]# ninja -C x86_64-native-linuxapp-clang/
ninja: Entering directory `x86_64-native-linuxapp-clang/'
[686/3119] Compiling C object drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o
FAILED: drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o
clang -Idrivers/libtmp_rte_bus_fslmc.a.p -Idrivers -I../drivers -Idrivers/bus/fslmc -I../drivers/bus/fslmc -I../drivers/bus/fslmc/mc -I../drivers/bus/fslmc/qbman/include -I../drivers/bus/fslmc/portal -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Idrivers/common/dpaax -I../drivers/common/dpaax -I../drivers/common/dpaax/caamflib -Ilib/eventdev -I../lib/eventdev -Ilib/ring -I../lib/ring -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/timer -I../lib/timer -Ilib/cryptodev -I../lib/cryptodev -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE=bus.fslmc -MD -MQ drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o -MF drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o.d -o drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o -c ../drivers/bus/fslmc/fslmc_bus.c
../drivers/bus/fslmc/fslmc_bus.c:318:6: error: variable 'device_count' set but not used [-Werror,-Wunused-but-set-variable]
        int device_count = 0;
            ^
1 error generated.
[691/3119] Generating rte_bus_dpaa.sym_chk with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o