From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBE80A034F; Tue, 30 Mar 2021 06:31:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 612AF140F9A; Tue, 30 Mar 2021 06:31:58 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id ABE6B140F99 for ; Tue, 30 Mar 2021 06:31:56 +0200 (CEST) IronPort-SDR: PdrAG0HYJiR7dUQWQ9LF7UoN1klFxG8jtNVlQoRCnJ+8K0KGGBC7RBuTj8IOQV0oMc/rTjkSMQ +CKrQteQ7dMA== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="178818162" X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="178818162" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 21:31:53 -0700 IronPort-SDR: JFhH/5IOA1vUa+M7bzj+Ts0VuAK0gM2vHV+EddxHXBr27sotVeVNVUZCap9JA2Z2Zm3LrxohX/ CQLzM14wpm+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="393464278" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 29 Mar 2021 21:31:53 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 29 Mar 2021 21:31:52 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 29 Mar 2021 21:31:52 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 29 Mar 2021 21:31:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SP8vnkeOTxw1Q/Jt4sdgnLCdFUfyWskoLHz6zPSGcRNWHbkZkcphYveMMIIu60bNdbEDr4jeuE2pp3ckeq/wDGh3V+4GwNrteLaT5q/+bigIl6AnfDPdL9rmYhS1SHMRI2nOyu6XxEdgnPChzq9PVgakb+md+oQyvmegNOPVTMc8+7VKni3rG/sI5iDEe65t1+Ib6V687aqrR9w/XrlENX+XruLfzjt6W/GHCKeETtVJVRvLN228661iOGVqRecSdzvhmSXKVI7V1wTJnl2UJcv7uAedxR0hf9OqFCRniSG5605raA6fvaUWOYidbUE+fXz+nLf4ZFXYGOZZdoKrUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcYhoWpjiwqPtd4doHx/3zSPH4vrHUqYQdqkRl9iPV0=; b=JhZffJNU2nSa3m4c9yLnDlRjelxj6ltolImn7vwnE8WLYEQuS9UsVvaIePb7RuN3hERApXsQ49bc3z4/kq4SBFfPI4q2KmqddVB77rr8GhxXN3IMuFnwjkXoXx5XIt/MAoH+xDkQ8t7nV/S+2PFV3xo8VlpRtw58rR3mCQOS3FP0MgMDLc6pKb+sUbYN4CcVaYv8XEKiLBkhzBuP8Ia/WfEjupu3w3cbtKvHHatmrz1nn92hGtqC63atBi4JGbs6TAvJ+AN2lb4G/o4ZgZO8icEyDI1NQv/C4hcYvx445BM1yWRz/2hyDhTLNVUPHpAqOcqPf+utMLAec7PeDBjYLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcYhoWpjiwqPtd4doHx/3zSPH4vrHUqYQdqkRl9iPV0=; b=tRb5nent1HyuOMn+P7rG1anqmjI9qqBYuQu4MVt8J/yn+yslWniHYYknewHPo2PD2NJoMhhVgUpntk5ZyORwfSub3sMdTLN6S/kC1i3K6Kfx5qD8xlU3AFHCa28KS5j93IllI71YIkCU4s/VGuQrB2X0KqVhQ3W3QPnUM/I8hC4= Received: from SJ0PR11MB5216.namprd11.prod.outlook.com (2603:10b6:a03:2db::23) by BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.30; Tue, 30 Mar 2021 04:31:24 +0000 Received: from SJ0PR11MB5216.namprd11.prod.outlook.com ([fe80::a0a4:9b48:660:b0e7]) by SJ0PR11MB5216.namprd11.prod.outlook.com ([fe80::a0a4:9b48:660:b0e7%4]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 04:31:24 +0000 From: "Ding, Xuan" To: "Zhang, Qi Z" , "Guo, Jia" CC: "dev@dpdk.org" , "Yang, Qiming" , "Noonan, Gordon" , "Varshney, Shashank1" Thread-Topic: [PATCH] net/ice: refine RSS configure Thread-Index: AQHXIXPX59yEpk2dZEqwxkZO/dIvY6qb0kbwgAAUswCAABAiwA== Date: Tue, 30 Mar 2021 04:31:24 +0000 Message-ID: References: <20210325124241.2357850-1-qi.z.zhang@intel.com> <0f2f65c090a84a4088f306dfc78b1916@intel.com> In-Reply-To: <0f2f65c090a84a4088f306dfc78b1916@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.56] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5166b211-12ee-4f5f-b7d9-08d8f334ad49 x-ms-traffictypediagnostic: BYAPR11MB3143: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mq99mPz+Yd847Rkr5SoLhM6nr1R5oi6taEZUrBkSvOihxQK/nVIEVEbC0jsh+MHsuWMDxCtdhCV4aCS/PQ/kRztEXZ4S2ERhCuyfQC2S62uSepkyNOx8eoe2JzJQNPGDro4LwCjeg78qeBzdnZWLvpCi/JJg7L6kAz37hpVSGy45URFOP+saNaehoHP4nSt/lKNwDKj1bhATLthCiCQiTSCF9Z8BpudIwBhGzODnuJ6sntnMv+98gkvjYyMDYoLBi4DH3Ia40FLmDu1AQbfqA06waoXyeLEkgS5UNOf/sOSs3fGNJxrCZkCV6u54ESbqn2GDHRX+NomaKYcqomrjKA919kTtF80TyEPtKX+IulvL9haMf9vnEeC8YehHIXz9RN8Lm1bPqu82HoZrgEY/j5CEYMc1YsVlxkX18pNuZM5lOQ1Pg9zLW0t0x2wQC8QmgkXA34B5G1UgYp5NN8bk8wnGZ9l5u72BufcKc2y0zM7Zx1fxygLddlSeeVv6mZgsSyc0F9cUjWLJzTBB9oFoOGA4z7N6XUUsbNKMrXujgEk0uZWMPxBp+m0BOBz164uTxPG18Y/ChaHDCiwyTQlLW4JTWdiZ9cP/RwhQLz+49W+xQrCeRI8D6nkeKt46DlHqflWnDs/FvDdHujUZOA1j+NDkbhJPG+qiFS8sCoozn4c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5216.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(396003)(376002)(366004)(346002)(136003)(2906002)(66946007)(76116006)(66556008)(66476007)(64756008)(66446008)(26005)(54906003)(33656002)(52536014)(83380400001)(107886003)(478600001)(8936002)(6506007)(6636002)(71200400001)(4326008)(110136005)(316002)(9686003)(55016002)(7696005)(38100700001)(86362001)(186003)(53546011)(5660300002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?5VpKzmcbJcNs4EaqUm0oJzM0pItaMixOoyTEyzY6JdCo0WsvBeTqPbX5?= =?Windows-1252?Q?8a2JiK/3YlC1RcIUORMy4olstxe8U+BcKovH2yGBi6TNh8WA5NWv+Y14?= =?Windows-1252?Q?A9dIF+4ik27SU6uX8XG9ZDpyi0d7aLnmxxxKfMuY4nVmYTFfT6WSD58j?= =?Windows-1252?Q?UCjfKjJ2fNOrbq4x/ofyztGYJg2PgtTD/4KH6EytCWES0KNEbjugoewV?= =?Windows-1252?Q?XHnn4WnDVwdjbUHXMnm78LKjXslwhWw6R5E0w0OY2Mb+uUXg7fgKYYj7?= =?Windows-1252?Q?FOib5ABMBa1g3rEYjHIguauSY+u3ubfYEZt5PcUuTdIuhjaYC+iLEN2S?= =?Windows-1252?Q?u7UUGkJ9rMAPZvsKwVKkohS7mUZ03Qs4im/XAyyyUZ5xP18kF+/RUWIf?= =?Windows-1252?Q?KGgpXd3FDtlgWrQ8U+2DdgqRGetZUJuRm1vAHgk3dqNjeJa0Ohxa9x0R?= =?Windows-1252?Q?vMY7Akb4DNX49dw16jauHYbArcb8/cCb9l+x+iogEvoD9WG81/Fyyg9j?= =?Windows-1252?Q?6rEAGGWusqoktcXbuQtEyUhinYzakoyJ1DKqIR8QMSZQyvYP3SUXi1oo?= =?Windows-1252?Q?lRjHrLKyLfEuj/sK85nycRR3KaGEWHMMdD6ED6YMv4O5RKzcalWxC5YO?= =?Windows-1252?Q?Z1eiwTNtWgdhu2WazkbQLjuytjO7T787/H1erBdOn5T22ykRqbQHlGH2?= =?Windows-1252?Q?3XoKplQ+nTrRpAQasgOkUP6NjgxwbYuyYhegtaoi1iG2PZ7h4S8/zeYC?= =?Windows-1252?Q?+Ck99IkKkTtUgO0joaJ9NNAEu5s/uShI7flfCaObqQ0rEcpYAUc+joNK?= =?Windows-1252?Q?XkW7BvrUINTKYDtwiDbKexPn3bGGQdbfz1wEa4iTzGWB7odirvzx4sJR?= =?Windows-1252?Q?en0J7F4wPvXzJloCMN/hqTpLrr6dSWZE5PNfMEXh1x1oKGHI6uUmIuM9?= =?Windows-1252?Q?5fH3+IEuTKdsEzpgpPNH+SHylKyqYiTRlJRpGKxqVZJBKyOfzOKdWi6O?= =?Windows-1252?Q?pgwWYrPhsGBpSQ/HtHEwHuYGiNu4jx6MGF8AS3q7XVE21rSh0CTgHr+g?= =?Windows-1252?Q?z6+OZcdzgUd1CqrWXiGSrOvCH7NWPyk52Pc1ue+a1kCbtyqSVhcmTryb?= =?Windows-1252?Q?ygsJIJln+LO8KUrxMg2hp0Kv7Sa5W5HTj/XYlogm+a1E4LGLxYoc4Sd9?= =?Windows-1252?Q?ID09suu1Rb3RBcVHawmJwAKwlamWmw4LuzX9WxRf7MwSJFjhvL1/nrWY?= =?Windows-1252?Q?7IjcsUwI1zS4ZhLQ4UM8eh0dz2I/peOoBahQz+ZXj90kUObULm3lMBNV?= =?Windows-1252?Q?qH7zBXBpXwoUZKanmhHVc1RB98Ilg1JoniITP1aMbbpzd0c2+yBfJoOr?= =?Windows-1252?Q?t4dB0Bz+zi9Epu4IZYXaMFtOeqUyToUp/B4=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5216.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5166b211-12ee-4f5f-b7d9-08d8f334ad49 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 04:31:24.2231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GpxjvrnGE08znbth3f8pUcFa3INAQvDhJ4IP7tvUOvA1eEnfyrSUjabioe6FyZZ/nxrMhUEkAKsZaT6UHjORkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3143 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: refine RSS configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, March 30, 2021 11:30 AM > To: Ding, Xuan ; Guo, Jia > Cc: dev@dpdk.org; Yang, Qiming ; Noonan, Gordon > ; Varshney, Shashank1 > > Subject: RE: [PATCH] net/ice: refine RSS configure >=20 >=20 >=20 > > -----Original Message----- > > From: Ding, Xuan > > Sent: Tuesday, March 30, 2021 11:00 AM > > To: Zhang, Qi Z ; Guo, Jia > > Cc: dev@dpdk.org; Yang, Qiming ; Noonan, Gordon > > ; Varshney, Shashank1 > > > > Subject: RE: [PATCH] net/ice: refine RSS configure > > > > Hi Qi, > > > > Replies inline. > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, March 25, 2021 8:43 PM > > > To: Guo, Jia ; Ding, Xuan > > > Cc: dev@dpdk.org; Yang, Qiming ; Noonan, > > Gordon > > > ; Varshney, Shashank1 > > > ; Zhang, Qi Z > > > Subject: [PATCH] net/ice: refine RSS configure > > > > > > The ICE_RSS_ANY_HEADERS will try to enable outer RSS for non-tunnel > > > case and inner RSS for tunnel case. This confuse user. > > > > > > As we already have ICE_RSS_INNER_HEADER for tunnel case, So, replace > > > ICE_RSS_ANY_HEADERS with ICE_RSS_OUTER_HEADERS for all exist flow > > > which only specified the outer pattern. > > > > > > To enable inner RSS for any tunnel cases, a separated rule should be > > > enabled. > > > > > > The patch also remove some unncessary condition check for GTPU > > > > Here ' unncessary ' is a typo, should be 'unnecessary'. > > > > > in base code, as we already can support outer RSS for GTPU. > > > > > > Signed-off-by: Qi Zhang > > > --- > > > drivers/net/ice/base/ice_flow.c | 14 ------------ > > > drivers/net/ice/ice_ethdev.c | 4 ++-- > > > drivers/net/ice/ice_hash.c | 38 ++++++++++++++++---------------= -- > > > 3 files changed, 21 insertions(+), 35 deletions(-) > > > > > > diff --git a/drivers/net/ice/base/ice_flow.c > > > b/drivers/net/ice/base/ice_flow.c index d123206fc6..bceb257d61 100644 > > > --- a/drivers/net/ice/base/ice_flow.c > > > +++ b/drivers/net/ice/base/ice_flow.c > > > @@ -3678,13 +3678,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 > > > vsi_handle, if (status) goto exit; > > > > > > -/* Don't do RSS for GTPU Outer */ > > > -if (segs_cnt =3D=3D ICE_FLOW_SEG_SINGLE && > > > - segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU) { > > > -status =3D ICE_SUCCESS; > > > -goto exit; > > > -} > > > - > > > /* Search for a flow profile that has matching headers, hash fields > > > * and has the input VSI associated to it. If found, no further > > > * operations required and exit. > > > @@ -3847,13 +3840,6 @@ ice_rem_rss_cfg_sync(struct ice_hw *hw, u16 > > > vsi_handle, if (status) goto out; > > > > > > -/* Don't do RSS for GTPU Outer */ > > > -if (segs_cnt =3D=3D ICE_FLOW_SEG_SINGLE && > > > - segs[segs_cnt - 1].hdrs & ICE_FLOW_SEG_HDR_GTPU) { > > > -status =3D ICE_SUCCESS; > > > -goto out; > > > -} > > > - > > > prof =3D ice_flow_find_prof_conds(hw, blk, ICE_FLOW_RX, segs, segs_c= nt, > > > vsi_handle, ICE_FLOW_FIND_PROF_CHK_FLDS); diff --git > > > a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index > > > 3e85e5f629..4ccf31cb41 100644 > > > --- a/drivers/net/ice/ice_ethdev.c > > > +++ b/drivers/net/ice/ice_ethdev.c > > > @@ -2348,7 +2348,7 @@ hash_cfg_reset(struct ice_rss_hash_cfg *cfg) > > > cfg->hash_flds =3D 0; cfg->addl_hdrs =3D 0; cfg->symm =3D 0; > > > -cfg->hdr_type =3D ICE_RSS_ANY_HEADERS; > > > +cfg->hdr_type =3D ICE_RSS_OUTER_HEADERS; > > > } > > > > > > static int > > > @@ -2833,7 +2833,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t > > rss_hf) > > > __func__, ret); > > > > > > cfg.symm =3D 0; > > > -cfg.hdr_type =3D ICE_RSS_ANY_HEADERS; > > > +cfg.hdr_type =3D ICE_RSS_OUTER_HEADERS; > > > /* Configure RSS for IPv4 with src/dst addr as input set */ if > > > (rss_hf & ETH_RSS_IPV4) { cfg.addl_hdrs =3D ICE_FLOW_SEG_HDR_IPV4 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER; diff --git a/drivers/net/ice/ice_hash.c > > > b/drivers/net/ice/ice_hash.c index 58a0c18d09..7d7e7052da 100644 > > > --- a/drivers/net/ice/ice_hash.c > > > +++ b/drivers/net/ice/ice_hash.c > > > @@ -110,7 +110,7 @@ struct ice_rss_hash_cfg ipv4_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV4 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER, ICE_FLOW_HASH_ETH | > > ICE_FLOW_HASH_IPV4, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -118,7 +118,7 @@ struct ice_rss_hash_cfg ipv4_udp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV4 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_UDP_IPV4 | ICE_IPV4_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -126,7 +126,7 @@ struct ice_rss_hash_cfg ipv4_tcp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV4 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_TCP_IPV4 | ICE_IPV4_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -134,7 +134,7 @@ struct ice_rss_hash_cfg ipv4_sctp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV4 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_SCTP_IPV4 | ICE_IPV4_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -142,7 +142,7 @@ struct ice_rss_hash_cfg ipv6_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV6 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER, ICE_FLOW_HASH_ETH | > > ICE_FLOW_HASH_IPV6, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -150,7 +150,7 @@ struct ice_rss_hash_cfg ipv6_udp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV6 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_UDP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_UDP_IPV6 | ICE_IPV6_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -158,7 +158,7 @@ struct ice_rss_hash_cfg ipv6_tcp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV6 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_TCP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_TCP_IPV6 | ICE_IPV6_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -166,7 +166,7 @@ struct ice_rss_hash_cfg ipv6_sctp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_ETH | ICE_FLOW_SEG_HDR_IPV6 | > > > ICE_FLOW_SEG_HDR_IPV_OTHER | ICE_FLOW_SEG_HDR_SCTP, > > ICE_FLOW_HASH_ETH > > > | ICE_HASH_SCTP_IPV6 | ICE_IPV6_PROT, -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -262,7 +262,7 @@ struct ice_rss_hash_cfg eth_ipv4_esp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_ESP, ICE_FLOW_HASH_ESP_SPI, > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -270,7 +270,7 @@ struct ice_rss_hash_cfg eth_ipv4_udp_esp_tmplt = =3D { > > > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_NAT_T_ESP, ICE_FLOW_HASH_NAT_T_ESP_SPI, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -278,7 +278,7 @@ struct ice_rss_hash_cfg eth_ipv4_ah_tmplt =3D { > > > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_AH, ICE_FLOW_HASH_AH_SPI, > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -286,7 +286,7 @@ struct ice_rss_hash_cfg eth_ipv4_l2tpv3_tmplt =3D= { > > > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_L2TPV3, ICE_FLOW_HASH_L2TPV3_SESS_ID, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -294,7 +294,7 @@ struct ice_rss_hash_cfg eth_ipv4_pfcp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_PFCP_SESSION, ICE_FLOW_HASH_PFCP_SEID, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -302,7 +302,7 @@ struct ice_rss_hash_cfg eth_ipv6_esp_tmplt =3D { > > > ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_ESP, ICE_FLOW_HASH_ESP_SPI, > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -310,7 +310,7 @@ struct ice_rss_hash_cfg eth_ipv6_udp_esp_tmplt = =3D { > > > ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_NAT_T_ESP, ICE_FLOW_HASH_NAT_T_ESP_SPI, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -318,7 +318,7 @@ struct ice_rss_hash_cfg eth_ipv6_ah_tmplt =3D { > > > ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_AH, ICE_FLOW_HASH_AH_SPI, > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -326,7 +326,7 @@ struct ice_rss_hash_cfg eth_ipv6_l2tpv3_tmplt =3D= { > > > ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_L2TPV3, ICE_FLOW_HASH_L2TPV3_SESS_ID, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > @@ -334,14 +334,14 @@ struct ice_rss_hash_cfg eth_ipv6_pfcp_tmplt =3D= { > > > ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER | > > > ICE_FLOW_SEG_HDR_PFCP_SESSION, ICE_FLOW_HASH_PFCP_SEID, > > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > struct ice_rss_hash_cfg pppoe_tmplt =3D { ICE_FLOW_SEG_HDR_ETH, > > > ICE_FLOW_HASH_ETH | ICE_FLOW_HASH_PPPOE_SESS_ID, > > -ICE_RSS_ANY_HEADERS, > > > +ICE_RSS_OUTER_HEADERS, > > > 0 > > > }; > > > > > > -- > > > 2.26.2 > > > > Since PPPOE protocol is a encapsulating network protocol. > > For IP/UDP or IP/TCP cases, is it right to treat it as outer cases? > > Here are some doubts. >=20 > PPPOE don't have outer l3/l4, it belongs to the same layer with inner l3/= l4, for > single layer, we just take outer header > Typically , inner header will only be used for gtpu/vxlan/gre >=20 >=20 > > > > Thanks, > > Xuan > > >=20 Acked-by: Xuan Ding Thanks, Xuan