From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
Long Wu <Long.Wu@nephogine.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Nole Zhang <peng.zhang@corigine.com>
Subject: RE: [PATCH 2/3] net/nfp: fix free resource problem
Date: Mon, 18 Dec 2023 01:50:01 +0000 [thread overview]
Message-ID: <SJ0PR13MB554509F2CFA9550E01C2A0FB9E90A@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <0a5a69d7-2d2e-4a0e-9d29-18ec856b5be2@amd.com>
> On 12/14/2023 10:24 AM, Chaoyong He wrote:
> > From: Long Wu <long.wu@corigine.com>
> >
> > Set the representor array to NULL to avoid that close interface does
> > not free some resource.
> >
> > Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware")
> > Cc: chaoyong.he@corigine.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> > ---
> > drivers/net/nfp/flower/nfp_flower_representor.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c
> > b/drivers/net/nfp/flower/nfp_flower_representor.c
> > index 27ea3891bd..5f7c1fa737 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> > @@ -294,17 +294,30 @@ nfp_flower_repr_tx_burst(void *tx_queue, static
> > int nfp_flower_repr_uninit(struct rte_eth_dev *eth_dev) {
> > + uint16_t index;
> > struct nfp_flower_representor *repr;
> >
> > repr = eth_dev->data->dev_private;
> > rte_ring_free(repr->ring);
> >
> > + if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
> > + index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr-
> >port_id);
> > + repr->app_fw_flower->phy_reprs[index] = NULL;
> > + } else {
> > + index = repr->vf_id;
> > + repr->app_fw_flower->vf_reprs[index] = NULL;
> > + }
> > +
> > return 0;
> > }
> >
> > static int
> > -nfp_flower_pf_repr_uninit(__rte_unused struct rte_eth_dev *eth_dev)
> > +nfp_flower_pf_repr_uninit(struct rte_eth_dev *eth_dev)
> > {
> > + struct nfp_flower_representor *repr = eth_dev->data->dev_private;
> > +
> > + repr->app_fw_flower->pf_repr = NULL;
> >
>
> Here it is assigned to NULL but is it freed? If freed, why not set to NULL where
> it is freed?
>
> Same for above phy_reprs & vf_reprs.
The whole invoke view:
rte_eth_dev_close()
--> nfp_flower_repr_dev_close()
--> nfp_flower_repr_free()
--> nfp_flower_pf_repr_uninit()
--> nfp_flower_repr_uninit()
// In these two functions, we just assigned to NULL but not freed yet.
// It is still refer by the `eth_dev->data->dev_private`.
--> rte_eth_dev_release_port()
--> rte_free(eth_dev->data->dev_private);
// And here it is really freed (by the rte framework).
next prev parent reply other threads:[~2023-12-18 1:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 10:24 [PATCH 0/3] fix some problems of flower firmware Chaoyong He
2023-12-14 10:24 ` [PATCH 1/3] net/nfp: fix close representor problem Chaoyong He
2023-12-14 10:24 ` [PATCH 2/3] net/nfp: fix free resource problem Chaoyong He
2023-12-15 12:54 ` Ferruh Yigit
2023-12-18 1:50 ` Chaoyong He [this message]
2024-01-08 15:42 ` Ferruh Yigit
2024-01-09 7:56 ` Chaoyong He
2024-01-09 17:48 ` Ferruh Yigit
2024-01-11 2:02 ` Chaoyong He
2024-01-11 12:32 ` Ferruh Yigit
2024-01-12 1:19 ` Chaoyong He
2024-01-12 10:06 ` Ferruh Yigit
2023-12-14 10:24 ` [PATCH 3/3] net/nfp: free domain ID in close interface Chaoyong He
2024-01-12 12:05 ` [PATCH 0/3] fix some problems of flower firmware Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB554509F2CFA9550E01C2A0FB9E90A@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=Long.Wu@nephogine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).