From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A3A4236A; Thu, 12 Oct 2023 03:40:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AED9402BA; Thu, 12 Oct 2023 03:40:57 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2096.outbound.protection.outlook.com [40.107.100.96]) by mails.dpdk.org (Postfix) with ESMTP id B956440279 for ; Thu, 12 Oct 2023 03:40:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUiw4D1K30CrqPqWWKGWWeGR1eDkOkQUZpiH8BpXYfLcg8n+CVLS5TY6D9DsjN1+O5GbjIYfPc7oDHpoJ+bZO+qq2Fta1y4JWwMqUjsygUrhRFLCs38IG5r7TRGgTmEUEEF/xoYCnt+hnT+77pWOXT7vrDijylVLomJgbcv57rVXrsUUMFTY4+khtBls+XdXJEhdwNId6ztgW14bjYoMI1nPIH8fR+1HAdmt2dUlqFgZ6PtHkg6OHbY5QrFJ8NvE4Ghf6znhfRnf1vnbWEr5tRJVfPwC5Tt9vqwrvmxIFz6Kt7UppRySxLSvway50V4g3mfhHd4WT5vgDrJa57UlAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zY/vFxUgPaIf1Ce9IZ6dRibHw4CikecGIQU67U5Ad6k=; b=bqjH0oydwCXE0LpERkIa/1a4XyKBT+MeADJQB9j9Qn9rmM3cGUduEKZPNwyE6vrI7emjscE0pileoMb6MLjHehsrZxvxukchGrltMSQIjgb83f0n3pQ0u+DKcMWGfuHC/qQg40chr9SRJRCPqgPlV6C6aXubMGEtV5Kb12MoaXlv1JDKs/NI1+iZjEl34DdM3vmjsaFiZAh0JTCdhcGdqR8Lf54GyV35QBOJq0f3jrBBNbj9BMZXG7Qka5oJmBe+KH3I4+2pmdJz2vb2mbbsIyJg96H/t4n5WZUwKTQAQVoxZOiWGlgjhI4f41XA447IuvtrrSBNVDZWt6oD40Gi0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zY/vFxUgPaIf1Ce9IZ6dRibHw4CikecGIQU67U5Ad6k=; b=V0vjX4XO7cpii0+6o7rMB0FIq0bBX3XEmCbT00pA1WgeqXc0mrGh5T+76L1xjF2J9FE1aVJTm75K21jy6gZC5QuZRVo/C1lnjsu96RwDfGVvFGtSNgttfoGReYqmPce2wnVBdczpz+fIcCyAvVxeN5hrFLNVtdqBAO8N+6xj/eI= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO1PR13MB5031.namprd13.prod.outlook.com (2603:10b6:303:f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Thu, 12 Oct 2023 01:40:52 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 01:40:52 +0000 From: Chaoyong He To: Stephen Hemminger CC: "dev@dpdk.org" , oss-drivers , Long Wu , Nole Zhang Subject: RE: [PATCH v2 05/11] net/nfp: adjust the log statement Thread-Topic: [PATCH v2 05/11] net/nfp: adjust the log statement Thread-Index: AQHZ/KtS+0RGhPuBnEeEuPUff20PkLBFYGKAgAAAXgA= Date: Thu, 12 Oct 2023 01:40:52 +0000 Message-ID: References: <20231007023339.1546659-1-chaoyong.he@corigine.com> <20231012012704.483828-1-chaoyong.he@corigine.com> <20231012012704.483828-6-chaoyong.he@corigine.com> <20231011183855.2d97c582@hermes.local> In-Reply-To: <20231011183855.2d97c582@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|CO1PR13MB5031:EE_ x-ms-office365-filtering-correlation-id: 5cc0fbfc-8796-4615-f8d6-08dbcac444fd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qx1KMIXavcUJWG2S/KwVH5iMIu8L1udwiQ2wnebkJ8QKQkyoZd0NcoaK98thylFu6ltxoc73qz9pnb8pupU5iMwwyvUZhXLRsXwFs8qyhHfGdZKIl3eV/oGebRtuWjj2X5NSJtCBjJeB7VgKcZsZRKX4fX9Rqbogmz19ONFgOGBvqP2/fBpnH+SEhfteX3o5R6wjuwGZ5xRYkcN8TFLYUkaTQagYVIzcpfr/YQd8WPIcC+C8zwZbIsxN3Jpn5BMR44ai9BoF9/5b0q78J+VVmVTMV7WgvtO1+qNp3+P0f3gzeEpsQsN0Pu34Pilua/IVMJx3RGaXcE45d+DiGANP1fsQW5qlb1KMSjEczdIvDpJiFGyIm1jYll0HS/ERuH2ZSyo4WGYz3l9bW4dQfjzxrUeoW+e9k1Ye0JuX2Vbvh+M/XZstQVLbnNccdU/rnOLO5OwhVsLLCVfG5GnJ+02+QY/lrb+juWU81qoNpOCD1UuhKh3IBKR/ZI3edo3CNG8l/aUM0wJ8nzK5SaLH33AoAmEd6pnSk6KINrBy32fIWCUWmv8iBfLRV/d+CjCb//e4j3nOf0J0oEMNLmHogiz+WeVchZ28SU5TkvXY0hNkpyG3RY+AgrgAWAXEtdgmJzpoEO1HcvJbAKVQTXBwOjmREZA7qYCSs2A91Nez2L4kzXQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(396003)(376002)(366004)(39830400003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(26005)(478600001)(53546011)(107886003)(7696005)(55016003)(6506007)(83380400001)(86362001)(71200400001)(41300700001)(8676002)(4326008)(8936002)(64756008)(66946007)(54906003)(6916009)(66556008)(316002)(66476007)(66446008)(76116006)(2906002)(33656002)(9686003)(38070700005)(38100700002)(52536014)(5660300002)(44832011)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MnmwpLoyYTy5NbWtVHjD1NZRQwWWSPieN/5C2DxGTDThdS3ZgDJ78Rpyj47i?= =?us-ascii?Q?3MtNEjFxfSiS+zGoFz5x46AsRAAdy5Qzx7ZS09ewTrNQwEhBeTWAtt8QwMkR?= =?us-ascii?Q?9N/8QdjvqniqE/9Ea95xL77UhQK9g0N86HC+lnkvrBR+B30FfI8TFOJFHxoM?= =?us-ascii?Q?Co1qLf9ScH7CM24HiHZt8fNiaieArRRHvcBT1la/0Vg+9Qp9f6JTTeyMdc2T?= =?us-ascii?Q?DXlDtcyTSxj/zCC2pe9qcyypLb17eNtLPE2bj6HdPtljUVsLxQG0rkZJWg6T?= =?us-ascii?Q?ov4ZillDhyv48PJ/X22Ac1InXnqsolDqD0jQxT6GzcBxUp9NvZeAZFEMsGUQ?= =?us-ascii?Q?m8Fa94H+DQtcMIrPYho9Nrgqc3nVMC+ofo4MT7P0jt0Oewehx2o/jEFauKEg?= =?us-ascii?Q?lSCDty8gJFo9eRW+CPhvutOCEaTS//VHvua/TZ3zxsxtxWMKIYT5eE58Waqr?= =?us-ascii?Q?JMB1iQcbfks9zr3bG6pBgl4Lrw335f5Wn3IzpX1Fh3pGJ2RAjOqre+8SjfDc?= =?us-ascii?Q?b9Pyu2i+zeikUEosUdDeGajL4FulBoD9J1cTxZfxPUCKdBduEA9ddHNIr5cM?= =?us-ascii?Q?C+q1BYUZ4Q1B+EJALTpk2hJyVaKs1xRrj/5GBU3io0gcM78XXT34wBt/JKFx?= =?us-ascii?Q?FK9EmZMPZHKa8Q7h+luyuLLEe0wp0bAEWiq212l7Jnwi5yZf41Um4SgJsnX3?= =?us-ascii?Q?WI43JGWCcHCRZQompc8No6syPvb2FHzvJaxUbQgSFt6o11gFYGDqowMbphLo?= =?us-ascii?Q?iD6Q+oPWEaRZtFtZvntqH0w6iRMl6sVxqaWopIEoyCjYf26ZXLr6sMR+pqv4?= =?us-ascii?Q?WX6b/iYBNGeqDbHubuUsxuur9pb9t0kTujxZaOcHVxAb45wu7FeQghYkZWff?= =?us-ascii?Q?Vk0+tWegAnTk7664oCYMIHDxdWexpykvyUQ8Hxas9LCHCqjU69RNwywSrsSJ?= =?us-ascii?Q?pQiz2zIlXxPRXfGEjAJWis73hfEuPFzFdh9nOLKgqA6agOVZxqbcJiWhYn52?= =?us-ascii?Q?g0e2WASdUVHXwGa4PIcJs0Ily0CcwsFPjt9pkVL/43m4JUshXC1Ei68DVzwJ?= =?us-ascii?Q?/8AaOMitHFbl3jUrrgxynNWf+4XfVoTWgMOWdXvZpIFL98JB1cs5Oe/Pupyp?= =?us-ascii?Q?CqXWYc6XXkp4Iq6L4ylq4kn4V35supLXzMGMSWaejY6BKjKcjphCia9JXUYb?= =?us-ascii?Q?R0xwAhJ3cCsEedaekcccnSgaZ0b43B7uX07hMepQeqyvV9P9E03afVVTKP4W?= =?us-ascii?Q?P8WdaAuKSelZ75sY38Wu0ttQFFx7nFqLWyYTU3FQFEU+07pU7Ar6r5nm9wPJ?= =?us-ascii?Q?PbLp/zceuBWNeBqfRlsTEJAbDLb7Q81ej5dE2XWgNpLle0b6NsSpyeRHQUeN?= =?us-ascii?Q?DLSEXr3NZG1x5/Zx99Pt/khUbqlCtJ51aSTz+6a7l7i18REv6cSC65wBrL5J?= =?us-ascii?Q?kwygBlEND79jl/iULefqxPpatryQpJr0cMIlm6X6gk41yk1a07MmWLuYe9ph?= =?us-ascii?Q?Zlj1yhDJ+Sjgj5/hQ8xHrz2AMAnNj8MFUW+Y7qpTiSqUTTaZx8viBJEznGR7?= =?us-ascii?Q?Y/1eWpsI8DM/f+n4sdm5u4fkpNQosuZDfIDlYnOJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc0fbfc-8796-4615-f8d6-08dbcac444fd X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 01:40:52.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lcOBvz7KRilH11Yi+7tu9n6uGbTqOpeZ5IXi3nxsqpTioz4nplf4ckbEdkjf8X265xprLSo+DyEu3Bryyv6a1zBQzpx2BmiRvpXkABZ03vI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB5031 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, October 12, 2023 9:39 AM > To: Chaoyong He > Cc: dev@dpdk.org; oss-drivers ; Long Wu > ; Nole Zhang > Subject: Re: [PATCH v2 05/11] net/nfp: adjust the log statement >=20 > On Thu, 12 Oct 2023 09:26:58 +0800 > Chaoyong He wrote: >=20 > > + PMD_RX_LOG(ERR, "mbuf overflow likely due to the > RX offset.\n" > > + "\t\tYour mbuf size should have extra > space for" > > + " RX offset=3D%u bytes.\n" > > + "\t\tCurrently you just have %u bytes > available" > > + " but the received packet is %u bytes > long", > > + hw->rx_offset, > > + rxq->mbuf_size - hw->rx_offset, > > + mb->data_len); >=20 > Multi-line log messages with tabs look good on command line (developer) b= ut > don't work well when application is run as a service and logging is going= to > syslog. > Syslog doesn't like messages with newlines in them. > The message is way to long. Make it shorter, and put any other notes in a > comment please.. Thanks, got it. I will revise as you said in the next version.