From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>
Subject: RE: [PATCH v2 05/24] net/nfp: add the offload support of basic actions
Date: Wed, 19 Oct 2022 11:32:21 +0000 [thread overview]
Message-ID: <SJ0PR13MB55451A2907D8B2D0B6B88EDA9E2B9@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <378d8349-19de-b952-67ba-32243e40cca8@amd.com>
> On 10/10/2022 7:08 AM, Chaoyong He wrote:
> > Add the offload support of very basic actions: mark, rss, count, drop
> > and output.
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> > ---
> > doc/guides/nics/features/nfp.ini | 6 ++
> > doc/guides/rel_notes/release_22_11.rst | 6 ++
> > drivers/net/nfp/flower/nfp_flower_cmsg.h | 11 +++
> > drivers/net/nfp/nfp_flow.c | 112
> +++++++++++++++++++++++++++++++
> > drivers/net/nfp/nfp_flow.h | 37 ++++++++++
> > 5 files changed, 172 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/nfp.ini
> > b/doc/guides/nics/features/nfp.ini
> > index 4460cf0..194fe64 100644
> > --- a/doc/guides/nics/features/nfp.ini
> > +++ b/doc/guides/nics/features/nfp.ini
> > @@ -29,3 +29,9 @@ Usage doc = Y
> > [rte_flow items]
> > eth = Y
> > port_id = Y
> > +
> > +[rte_flow actions]
> > +count = Y
> > +dec_ttl = Y
> > +drop = Y
> > +port_id = Y
>
> Are these actions supported? As far as I can see all done in the code is print
> log when these actions detected.
>
> For 'dec_ttl' even logging seems missing.
>
> I think better to document them as supported when actual support is added.
>
I will delete the 'dec_ttl' here, and we does support the offload of other ones, thanks.
> > diff --git a/doc/guides/rel_notes/release_22_11.rst
> > b/doc/guides/rel_notes/release_22_11.rst
> > index cd22d95..ac0223f 100644
> > --- a/doc/guides/rel_notes/release_22_11.rst
> > +++ b/doc/guides/rel_notes/release_22_11.rst
> > @@ -155,6 +155,12 @@ New Features
> >
> > * Ethernet
> >
> > + Add the support of rte_flow actions as follow:
> > +
> > + * Count
> > + * Drop
> > + * TTL decrement
>
> Not sure if this level of details is required in release notes, it can be sufficient
> that driver flow API support is added.
Okay, I will revise them at next version patch, thanks.
next prev parent reply other threads:[~2022-10-19 11:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 6:08 [PATCH v2 00/24] add the basic rte_flow offload support of nfp PMD Chaoyong He
2022-10-10 6:08 ` [PATCH v2 01/24] net/nfp: add the stats process logic in ctrl VNIC service Chaoyong He
2022-10-10 14:48 ` Ferruh Yigit
2022-10-10 6:08 ` [PATCH v2 02/24] net/nfp: add the structures and functions for flow offload Chaoyong He
2022-10-10 14:49 ` Ferruh Yigit
2022-10-19 2:50 ` Chaoyong He
2022-10-19 10:48 ` Ferruh Yigit
2022-10-10 6:08 ` [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD Chaoyong He
2022-10-10 14:51 ` Ferruh Yigit
2022-10-19 3:00 ` Chaoyong He
2022-10-19 11:11 ` Ferruh Yigit
2022-10-19 11:30 ` Chaoyong He
2022-10-19 11:38 ` Ferruh Yigit
2022-10-10 6:08 ` [PATCH v2 04/24] net/nfp: add the offload support of basic items Chaoyong He
2022-10-10 6:08 ` [PATCH v2 05/24] net/nfp: add the offload support of basic actions Chaoyong He
2022-10-10 14:52 ` Ferruh Yigit
2022-10-19 11:32 ` Chaoyong He [this message]
2022-10-10 6:08 ` [PATCH v2 06/24] net/nfp: add the offload support of VLAN item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 07/24] net/nfp: add the offload support of IPv4 item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 08/24] net/nfp: add the offload support of IPv6 item Chaoyong He
2022-10-10 14:53 ` Ferruh Yigit
2022-10-19 11:33 ` Chaoyong He
2022-10-10 6:08 ` [PATCH v2 09/24] net/nfp: add the offload support of TCP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 10/24] net/nfp: add the offload support of UDP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 11/24] net/nfp: add the offload support of SCTP item Chaoyong He
2022-10-10 6:08 ` [PATCH v2 12/24] net/nfp: add the offload support of set SRC MAC action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 13/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 14/24] net/nfp: add the offload support of pop VLAN action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 15/24] net/nfp: add the offload support of push " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 16/24] net/nfp: add the offload support of set SRC IPv4 action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 17/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 18/24] net/nfp: add the offload support of set SRC IPv6 action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 19/24] net/nfp: add the offload support of set DST " Chaoyong He
2022-10-10 6:08 ` [PATCH v2 20/24] net/nfp: add the offload support of set TP SRC port action Chaoyong He
2022-10-10 6:08 ` [PATCH v2 21/24] net/nfp: add the offload support of set TP DST " Chaoyong He
2022-10-10 6:09 ` [PATCH v2 22/24] net/nfp: add the offload support of set TTL action Chaoyong He
2022-10-10 6:09 ` [PATCH v2 23/24] net/nfp: add the offload support of set IPv4 DSCP action Chaoyong He
2022-10-10 6:09 ` [PATCH v2 24/24] net/nfp: add the offload support of set IPv6 " Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB55451A2907D8B2D0B6B88EDA9E2B9@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).