DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
	Niklas Soderlund <niklas.soderlund@corigine.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/nfp: fix the Tx descriptor free logic of nfd3
Date: Thu, 18 May 2023 10:49:37 +0000	[thread overview]
Message-ID: <SJ0PR13MB55453E0DCB443546367891669E7F9@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <de0d9c6f-a434-257e-d62e-4b05500023fe@amd.com>

> On 5/12/2023 3:07 AM, Chaoyong He wrote:
> > In the tx descriptor free logic of nfd3, the former logic might force
> > cast a negative number into a very big unsigned number, and which will
> > cause potential problem in the xmit loop.
> >
> > The xmit loop will continue in the place where it should break, and
> > will overwrite the Tx descriptor which is not free to use by the PMD.
> >
> > Fixes: 74a640dac864 ("net/nfp: avoid modulo operations for handling
> > ring wrapping")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> > ---
> >  drivers/net/nfp/nfp_rxtx.h | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h
> > index 5e651518ed..e642bc970a 100644
> > --- a/drivers/net/nfp/nfp_rxtx.h
> > +++ b/drivers/net/nfp/nfp_rxtx.h
> > @@ -401,10 +401,14 @@ nfp_net_mbuf_alloc_failed(struct nfp_net_rxq
> > *rxq)  static inline uint32_t  nfp_net_nfd3_free_tx_desc(struct
> > nfp_net_txq *txq)  {
> > +	uint32_t free_desc;
> > +
> >  	if (txq->wr_p >= txq->rd_p)
> > -		return txq->tx_count - (txq->wr_p - txq->rd_p) - 8;
> > +		free_desc = txq->tx_count - (txq->wr_p - txq->rd_p);
> >  	else
> > -		return txq->rd_p - txq->wr_p - 8;
> > +		free_desc = txq->rd_p - txq->wr_p;
> > +
> > +	return (free_desc > 8) ? (free_desc - 8) : 0;
> >  }
> >
> >  /*
> 
> 
> Can you please rebase this patch on top of latest next-net?
> 
> 'nfp_net_nfd3_free_tx_desc()' moved to 'drivers/net/nfp/nfd3/nfp_nfd3.h'
> in commit '2344d6272fe9 ("net/nfp: move NFD3 logic to own source file")'

Okay, I'll send out a v2 patch soon.

  reply	other threads:[~2023-05-18 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12  2:07 Chaoyong He
2023-05-18 10:33 ` Ferruh Yigit
2023-05-18 10:49   ` Chaoyong He [this message]
2023-05-18 11:02 ` [PATCH v2] " Chaoyong He
2023-05-18 14:43   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR13MB55453E0DCB443546367891669E7F9@SJ0PR13MB5545.namprd13.prod.outlook.com \
    --to=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).