From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA53C45AFB; Thu, 10 Oct 2024 05:24:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C1B04029A; Thu, 10 Oct 2024 05:24:17 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2109.outbound.protection.outlook.com [40.107.236.109]) by mails.dpdk.org (Postfix) with ESMTP id 756484025C for ; Thu, 10 Oct 2024 05:24:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C50V9NmTDcASD4HgUNSvf6R25g7IqOMM72mOzXlSX0seYcdkTlTCrWKClxcf04pZq8cJm7b6h8CQrp7/Jt2b2VhV12C2MTmGwI0e4E1XMazCwNIWhrXwkLJgSvsBhLJn5oYuoZ8p2GFE5lJJQp9DHeWqD+EmyyjCRLahRmvu4tx4d2nE8g9BNfLWV4UXZN0LKOmAZYOPZgCZMK+OIE8/o87KVaOPMcOeVJ+qMegmJLXCzBjCgeZN1xdGaiB6vv6X/0/wx4ujs4u3MnMizCaZ3IgVC3Kr046Ya5A0KR+YxdotapAqw7wC/eo4b1e8kp7yHLVL8oGowIiAw2TdzSZSgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O3Bhd5At67WmhN5JO+wq88z9HGTe66P/RJdoMov5VJQ=; b=J91+q6SrlJsmpHodvA2ALCD9dM8FmDrhdo/88+NzbU37hnVuRR/wKFlWqRettZ2HagJOhtoov6+eDSBIRMZPbkhQypLYra87CdP7HbGdyfSOgFpStAQZynYaHEZitMOR17eweXtvYvor9KapLdY42sB4SooJ1BLZCQ0YcuF7HLrdIhUQMSRjiNhPOGiqLMikHS6KU8E3AI9ZYQQbY2ujjrJmOdwBicSf1OGlwkDQqZH7cozHXPNng9E5DvYGqMURw1Qkyz/XJ8mOaQ794rje9TD+DFrBJO6+2c7yIlj+cjYRj46J5TaXLE7MixZmNRAGJe6NE6ry1/Hiihz6yURnFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3Bhd5At67WmhN5JO+wq88z9HGTe66P/RJdoMov5VJQ=; b=dGVDKx11cwbQ/4493agsa2WhI+hNmI3XQS/EaMqfan763Manwfh51udM7qul/xGnsRiuNN/0sI6AMNYatk5ZieDbtdqJbyCy3j9U2N3aRZiGlbJpvc5ERtwBTs4KUbakO/52k3yIv+YnPIzSrDHVgv6Jr+AjHujoUYhopqJoIMM= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by DS7PR13MB4622.namprd13.prod.outlook.com (2603:10b6:5:297::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Thu, 10 Oct 2024 03:24:11 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024 03:24:11 +0000 From: Chaoyong He To: Chengwen Feng , "thomas@monjalon.net" , "ferruh.yigit@amd.com" CC: "dev@dpdk.org" , "stephen@networkplumber.org" Subject: RE: [PATCH v6 4/4] common/nfp: use new API to parse kvargs Thread-Topic: [PATCH v6 4/4] common/nfp: use new API to parse kvargs Thread-Index: AQHbGgamlM3MZtRcxUGhpckKJ6tsTLJ/U5yw Date: Thu, 10 Oct 2024 03:24:11 +0000 Message-ID: References: <20230314124813.39521-1-fengchengwen@huawei.com> <20241009045030.26874-1-fengchengwen@huawei.com> <20241009045030.26874-5-fengchengwen@huawei.com> In-Reply-To: <20241009045030.26874-5-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|DS7PR13MB4622:EE_ x-ms-office365-filtering-correlation-id: 975db087-3334-4af8-47bc-08dce8db0270 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?4CTSoj6rt5PfiH4HwjRnxc6r9cRItJBjsRSB3MBNreBbXR8Mwkn3MiIAdgJG?= =?us-ascii?Q?5Q/jhQTEX3ovDt7AD94tsJFUy+83E/EWAVtn2QpomsmBpmFrHsJRUkN21o2n?= =?us-ascii?Q?ixmQ2uERuySrnq2bXtUjJ/rqcSQvsx2V0GDlXyVHWi5+SFmMkVW+O7zE5ay+?= =?us-ascii?Q?2wQ7oTP2aYlK2WiOto1ne3JOPs4KYgg5ECxOmYvLZItTT0WS0UnaWvbXtI+2?= =?us-ascii?Q?/XH9uOwxFt/x8Yf34SV/PWWA/vAHbcQUvsyvPJuQpfn1s6Xd+LIpBqFG46cI?= =?us-ascii?Q?bCgs88dtTcFKma8Qd0nJwvxvXTy0WhEb75fQfV8PblUatEph7y2zOwluODKB?= =?us-ascii?Q?GxOYrjPBy03UOS8SUtyhgnrv5kD1NMK67FYHz5CtMUNvp6AT0ZxcIwrQgdLB?= =?us-ascii?Q?DYqcKn74qGaCVRDcIqvDO/8cPP4DRuIPGEKwb3n2tB/jm3lqqKe7VffeS3n7?= =?us-ascii?Q?9Ba2gVv/s55GohuDmZq0w7p6KoZJXa/oSMXbvtc+niBzzkS/+hIG8/sMHe11?= =?us-ascii?Q?ArofRkKh5CMHmVXhcrYYGwfrXASFrCwFLCrKFoQQ9qP8S78CGrbQlF45qMDs?= =?us-ascii?Q?f4jKh+9Doc0+bmZqGuQxdMbtbSivkP+HjZGpbFTbOo//j2TLKX72pwNyNwFa?= =?us-ascii?Q?au26bQB9AWwhoEzaxjG+SvpcaKnYPxKa4Ht5GY0JW2EdB9Q7h+8oLWgEa8Bx?= =?us-ascii?Q?7exOA2J816sRliqyic6Q6qO6IPryise0gc4OxNjxaUbL0dQwzSWOmEom8EBa?= =?us-ascii?Q?RuLAMtjzMTRgVY9I7xTFWSg5ygIzTHCB8ATOdQtkyb5vbTMPRiO3h0ZuQEeV?= =?us-ascii?Q?gaQEkDkoz4B5gvDeQvwWkbSYmtAgp8GE5/HsHWztDwtr+oCK1n/DjgPoYz+d?= =?us-ascii?Q?/uBr94FfC6XR1s62XIW2GgeNKMjiAddRoKBJUcWtlO1Bya5NgA/absxp6W53?= =?us-ascii?Q?foCrFnOKZrayFg7wXJEvoQ+wjlyBKpSwJlzlMnFBiJ81aEO+DcXocPlEUNRO?= =?us-ascii?Q?ee9f0S21nr3zodkcJnLx1/W2kBIxbpu9g5vGLXCvEuyvtRhIMW9PEz8MN3A4?= =?us-ascii?Q?BKtH65u0R2WcLgGuFjXFvL50kr12phzTNYiYdSf854p44O940Uu5OPWpij4x?= =?us-ascii?Q?utkhmk3eUFrZXMB/gXe0qeVUfs21/ZkppTNEgDCZxuQJ1Ej6bCrdhh1w7Qey?= =?us-ascii?Q?SD4Zso3RstDUTaXeUjwqzte21oGk8kjUysHMLheJBonPeHo+ZTDAZZhz3DzF?= =?us-ascii?Q?qL4gVvU7lAuhfBVLfbcHuTQAk6M7e7ckhwoI+PgI+V8T/UJyUZ+x8hWPhZK3?= =?us-ascii?Q?SRcDn+yCYBWy1F/AraZxGlCervWLhJcfiPe5h8e92P0q8A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xTSw6iUMGBb48siqIsGuBwfkVHw6zPeuB+x0hGd1Amf7kKTwHxlr+Lmv2JKa?= =?us-ascii?Q?buOAz/PxgOyubmLEtmCOAqDlSJ+oL4DVuid7mf7q28Z46K/S3MHyp7NZNQyD?= =?us-ascii?Q?1TbpqyjLeRouR4vNyOCGg3AXg0HdV6lFhRFW/zDjyhSy5zFbUwN2zqGoHQfC?= =?us-ascii?Q?VEFcUhKuUcHfAsuK2eWbhJJIR5Rb2Y7KWdcjDMevApzlIH4EkvmiftJdNh1a?= =?us-ascii?Q?s4PCCoo9Xp+3PLEIyuNJ7vFAnS9d40Y1tzbNdUefqoLwmJxeWJRjEaOG9qbs?= =?us-ascii?Q?6yge8kn8En8a+x58Lf6syJVdoSLPlJi94bwq58dA+nV+l2Rfr1PAKcYOl6yB?= =?us-ascii?Q?bRC5fPpFUfSAGSiPRpXURAnVPJrqgoxYbLEx7Rc2i2m8ZQO4hVeI6Qg1j08J?= =?us-ascii?Q?N2XtE/yTdJrfkgZRFkHLuR9dnjZWmqxcTQs1NhGpU4kDXrWNqvzmfxDcI8+M?= =?us-ascii?Q?U4BHxWXT9qfzewXWMoihFjGFPmu2mOmgsJPuYMmFzieREwh5pWH55mxrF01n?= =?us-ascii?Q?g7XENKMMCECzTXEByrg8GL3b/OMt73mYEIi5JEnEP1zX1Rnj3EBXVtiOieb2?= =?us-ascii?Q?n344vPVPKL4tjLxzqaXxXfwOxLpDL1Ccx3xdYJrffJF8DNVgWrbpNsKbCOs4?= =?us-ascii?Q?uEpvXFJVIdhS+ugFNxj+7mnf/NzWUnP7cA7knzBgNWNKulsA1ApqVx/S7wK5?= =?us-ascii?Q?9UwbPtcu04QHLOAO7s6mfu7HfmM3eGe9jUmLt6cQdRLc8I9xWSeXY22V/3Eg?= =?us-ascii?Q?eXsgVfuF1PZmyIAl2YmM7PyF4nT/esHiur+OI6EZoVawflElmyJR2ShvcMqJ?= =?us-ascii?Q?Hy8HQP4zeoaPEZNlVpu5AD+byrZVCt4UuD6rNEtmCAatn32lpc0j77A4/8zZ?= =?us-ascii?Q?E0961kETvxTAzXAPNiEiQCiZvPXH6RuesdhDNju4VawtK/oOt/tIr47fs6V0?= =?us-ascii?Q?ubvuLukMkoJ5FM/ntYcFqkwXdXFNzs4IlBB7vm+1ExPNuPZqkyI/SVfhUG8s?= =?us-ascii?Q?ssZOxo2pxACFJ0yvfNyjVPjunD+f30Oy1mfVlzc4d+vFaPWXDBD+NUfOpLaH?= =?us-ascii?Q?xWeMvZ9dRsO47zNXA8bSrF+wCF+g/uYsWV3pCBGxbohBLvjzo5jD9A3kzO+i?= =?us-ascii?Q?T6mU0ytKOsf9y5p3Gfm8EJHAA9yBtk+70YpNEorrnIGn3EluA/K2BmX5Da4O?= =?us-ascii?Q?O9tzy96oWLUkbSZm5n3lauuHvQ290HL2gZuUfiCI6pnf+TUA/szez8Xq96kq?= =?us-ascii?Q?SZqGaOqsG+fyEQOofKoqONVpKA0r0vjhpeSYqayapd4bGX1MwCAeDryVMz5D?= =?us-ascii?Q?dRjghUAQxM0iXtFr54jWYIyoKE5CZ+Mwmu2z69SkygZJHYEdUotOSzMB4JVQ?= =?us-ascii?Q?cByWY6PolWRwqhJW1KdZ2NwwDE+95WF91V8KixKjD4yiKvnsiUvnWY8sT3ur?= =?us-ascii?Q?d6XDwf3ShviwtpKpb9pRQraMCqD5sX3YpeSI2sBBeNQdOvtsnyhGPDF0TNYe?= =?us-ascii?Q?qj6q4P3cD+XMASW3w0bNaKlK7AtbnHItwEvfHbOEHvQtittf3p9WMg2qgD0A?= =?us-ascii?Q?+luYdf4MWAD+7v2xc0YrRaxm2OSV3DRc3vFAyiO9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 975db087-3334-4af8-47bc-08dce8db0270 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2024 03:24:11.6043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eY1oMW+bS81bCuybQTL8EPsCgis6h1sqoOav8wIbS3jwV12G1Q71HY9y1eudW3dui9lm/tm93UoXGaNp3p+sHmSuaeRG3UgYUhYowSUa1EE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4622 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Chengwen Feng > Sent: Wednesday, October 9, 2024 12:51 PM > To: thomas@monjalon.net; ferruh.yigit@amd.com; Chaoyong He > > Cc: dev@dpdk.org; stephen@networkplumber.org > Subject: [PATCH v6 4/4] common/nfp: use new API to parse kvargs >=20 > The nfp_parse_class_options() function could handle both key=3Dvalue and > only-key, so it should use rte_kvargs_process_opt() instead of > rte_kvargs_process() to parse. >=20 > Signed-off-by: Chengwen Feng > --- > drivers/common/nfp/nfp_common_pci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/common/nfp/nfp_common_pci.c > b/drivers/common/nfp/nfp_common_pci.c > index 723035d0f7..5c36052f9d 100644 > --- a/drivers/common/nfp/nfp_common_pci.c > +++ b/drivers/common/nfp/nfp_common_pci.c > @@ -170,10 +170,8 @@ nfp_parse_class_options(const struct rte_devargs > *devargs) > if (kvargs =3D=3D NULL) > return dev_class; >=20 > - if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) !=3D 0) { > - rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS, > - nfp_kvarg_dev_class_handler, &dev_class); > - } > + rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS, > + nfp_kvarg_dev_class_handler, &dev_class); >=20 > rte_kvargs_free(kvargs); >=20 > -- > 2.17.1 Looks good to me. Acked-by: Chaoyong He