From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB020432EF; Fri, 10 Nov 2023 07:58:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73D6F402E7; Fri, 10 Nov 2023 07:58:37 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2112.outbound.protection.outlook.com [40.107.237.112]) by mails.dpdk.org (Postfix) with ESMTP id EF3A74026D for ; Fri, 10 Nov 2023 07:58:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dCOSfqaG9VizFryEBwp7TLj2S2WuZMyahOzTK2W0MEd8MHQ9I/Kl2Rnlh6UJGzf7cBbOxILamTkcJh4sTVVYQj3zsPcQKThOR2JeUtIz7RX70i+bnymEP0NhzY7wUAY0seYmN/ZE4AjME19PwDul7IHyMYyfgtNJktgnqPZBUgGgKC40jI1XFN+QZIJhtSO5IwFaPkMkH6L7A6YUttbVAnEjldI/cNnWqAtRF1mo1EUsMxT3eJRIRh2smjYPVf0AQSyfXQR7ef4mVzN574w4PKKvbsaF0OFFHb1ynMWI5REQmI3Ei8+IVExedxd0afB3zXXUtN9+MJBHa3j5gW283A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pxBwjVpkBWPYL2ZE7aRSrpTB4HsFRaO6iu7ulKbEtU=; b=CrgbqWi0+iYLQ4WCkpt/XT39CpIuKBAzm0sxpTQTK3m9VsMonmcokSMKRHC6Q3ClTNfiry3BAqfF+6etMw7TrApYcUPC3+X6zPsmmqTmbfNE8EXRFSZIt6HvjyK6sg8A9OxHfxgPU40X0YpKNuubzxHYpMcku1svcaBRuKIZPofmXRm9krZw9PMopLUrnJLoeZfpiz5wwWiPJgS1JIouJYGFG+IZgdoLQboaKTp8X5wzh6CjMm2iX/gHkzfNLHO8aWtPT0vgw1s9xfCg+jCFqiTgXev5qiUhM0az/6TJtOTp1+UnToYKtffvuw9AaAixHUVMAdp6I4rtmWMBw5bonA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pxBwjVpkBWPYL2ZE7aRSrpTB4HsFRaO6iu7ulKbEtU=; b=HDK1+Nr6YodLiE/NhLGYkR/ziFmf4M8ovB/6JCvRcUbJIWQKlvdr33UMzFZD7FIIE2kVdkS5eIwoUHQ9Mp96jysgzaD+LEXinye/edz7v69K17O9ZBeg1o16z3HPoDIMg0excs7b+5Sf/4fP9whzoFiUcHjniNa2LkE1ZCnbAAs= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5378.namprd13.prod.outlook.com (2603:10b6:510:fc::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.27; Fri, 10 Nov 2023 06:58:32 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6954.025; Fri, 10 Nov 2023 06:58:32 +0000 From: Chaoyong He To: Chengwen Feng , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Chang Miao , Shihong Wang CC: "dev@dpdk.org" Subject: RE: [PATCH 08/16] net/nfp: verify strdup return value Thread-Topic: [PATCH 08/16] net/nfp: verify strdup return value Thread-Index: AQHaE6CyvMYIQXDfvEKUh76RjcoPArBzHtNQ Date: Fri, 10 Nov 2023 06:58:32 +0000 Message-ID: References: <20231110063653.5948-1-fengchengwen@huawei.com> <20231110063653.5948-9-fengchengwen@huawei.com> In-Reply-To: <20231110063653.5948-9-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5378:EE_ x-ms-office365-filtering-correlation-id: 436271df-5f7c-43a7-1728-08dbe1ba7388 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: McMF6PXIbTMNfLQHeWxS04fU5gZvL27f8MHdgp4cIjtjH4o1SrbgEv8NDODnam5YxivxpyNOeAtvhT1R1AIFsW0AcpiUT0XgkvP7Zo3CKB6cD2WOoPuLVGRTvPA1RrpKKOuRqJZH8/CiZbzHrT+cFoEY/LRV/FCUNqcy1TtdZtAzDnSQoaN+Bd3OEAOVQH+Hxbjs4bht65eXmGGKyt1TljZsLx41Yj3CqqBh032GcGRf/waSi0Y+omQ1Ax8g1nJFvjXTBx+XQ3U/dfOmomKg1qZEfHmPBSP1mSGVAkX7xlJdUU3BP2aGSF6PvAzEEohRW+M9Ujewb/SuPWSwxVXzMnfbAk82KGWMXnk46qHxH4MOzv250FNRBEe+4VTAMz1hNKZlAqAnLQ0xxwsndDbkkOAm9uWsWkBVm1DlNa+V22I7gXyAWuSbizTEIEheRvli2vGMJO+r5O4BxJlQ3GAQXjH1ol0Cd7Mjb+3g1foQq5eBHnViZar/4c/idkcH1mkKK/nxSW537xD/vyz1O/kSnPxHYQwdlBdb5Akz/ttpPlu+eljm4lHaQZMBuoAe2DUDCwqDfJ5QDdXknUCYyjaTRzqbbj2nDLiibQyqPxrHibXkMveJscB+kCGI2y2bMzWf7VpewOzeiRZFhBdGINw5DemAdy4f3FIv9s4OuvhY2Vm1g6ZqUL0q+PWVqgK+WfdVRis8GEWcidm2RnAkwQydrC3PrQWsFJoSkq9zA2AjtAF2PekQHcSmf0TC4jlD3Jh2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(39830400003)(136003)(376002)(230273577357003)(230473577357003)(230173577357003)(230922051799003)(230373577357003)(64100799003)(186009)(451199024)(1800799009)(8936002)(52536014)(122000001)(41300700001)(26005)(6506007)(9686003)(4744005)(478600001)(83380400001)(4326008)(71200400001)(8676002)(66556008)(5660300002)(44832011)(64756008)(76116006)(110136005)(66476007)(66446008)(316002)(2906002)(38070700009)(66946007)(38100700002)(966005)(86362001)(33656002)(7696005)(15650500001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oYTpDtUzuNvW28zp7uR2mmgX5CE8buQSaCxVaeyjGUCJUKJhjcoRKj+fIQmA?= =?us-ascii?Q?y1mmQFiiwSa7nLeAND0Db9zmXeGk6aqjz14G2dMPdjNJOQekXbwCBBF6iil+?= =?us-ascii?Q?Wr+RRrfD+hKhyettZmkv98Aqxf9wbfj+cTcQ4pEXZUMhxt13rq+gM8X//Fkn?= =?us-ascii?Q?33bZY7S+JGpt5RIP3HPwOo/CPehCRr1/2ZOneKEUGW9v+voFcKfewScTrTsM?= =?us-ascii?Q?nnRFsFN3RyFTDogzkCCr8CoQglgJyUN5vmA+nfUepj6KS1JcJ8V8ra/6AR7U?= =?us-ascii?Q?73adS6FYvGIwIOHFlAa6l5UwjeETjz9QcfFguerm4ICycWOteO6lZJu8Pu2x?= =?us-ascii?Q?d+SE/NLmi9mixiJK89iufqYddx4M48JO7I9XeF2kerix2tviO5NtGUHI/YgI?= =?us-ascii?Q?8dO1rQg+m43TDtBIOWNzlOYxEwX6iDRyyye3mTw7cgl6PHrXkKhbNeHDQd3a?= =?us-ascii?Q?e0hZoy1rXhZwweGG3Ql13CNC/cvEbXgtTPAm/t3yL0D96VbAJE27To43YBAh?= =?us-ascii?Q?lraafhgtSIsh2Pq8ebaX3jPjg2lbAfQ00n5j3iTaoQzzjO4d+CIdZdAuin+Q?= =?us-ascii?Q?tNVNwgImXKfzdpOVnWkn7m/Xy375tXEvW68lQtgDqN9s7XJ8YpaZ778o7/OY?= =?us-ascii?Q?y9EVhBSC5tiXz8vbaG6WHPGgMHxD76m5xjxfUJ2bPhSEJ3vuWUyizLnoDjoM?= =?us-ascii?Q?a/YLIIf/5ysF78gC0Fa4DVXeCYcGUDM8sXgPvKaueE3e0WxmT5saFSRyR38s?= =?us-ascii?Q?96B6CUEi0Ye2elwNRRtrJ8YoPFMHRwnZiNmav4vIbtws/XpLCGVS0uSAetL+?= =?us-ascii?Q?D07C9G10F9+m3caEu9lRoVTrpl6K3C4pc5UCgEQhvXp6rcsccVfP2EAVG0f9?= =?us-ascii?Q?GrxVefNdeyFjoHOLzeNYk4rPlTB0EUblzfgTkwOTFWGpLnXJEcUIWJfHYY9t?= =?us-ascii?Q?j9AiBD1QgX6isjwNTjrrAxCsnXiWZiFSY9m4QLhl+BAyR3vL2uGrQORBVjco?= =?us-ascii?Q?2UCQj1qPDTYeQxalykWjnvu8gKdJsFZ5z0qKY500501heU+BLs8Wg3HFuEQz?= =?us-ascii?Q?HaStV8uIIBwSsZMov1RZGcUCUdylxJKa+bIlMpE6nxb6vYCkoQeSg5+DIHk6?= =?us-ascii?Q?/YJR4ibU47EuHzfyxQOw8cGjU6HoQlxCWyrJoXSf8j4hiJXEABUqiDKtI5yW?= =?us-ascii?Q?VQXCYpSIxlb8L+YrMpm5iRPgs3lcMidlka3Cy9Tx7b4IeOy2Ypxf2jnRHdPK?= =?us-ascii?Q?t33BEBxAbAGkBa8a6+qdRij23/V6ePEwD0+fYLzU3oHL6tR4k0L1ckjzSb39?= =?us-ascii?Q?ovfKSYT1+uN/dLFWRMNlVm/GgGIWsA9sO+y34QnzsMl/iWm+EuFDHERvGCrT?= =?us-ascii?Q?Hn+HxR/DCcSQFabmkCAlc8++lPQorSBnitpgP7/YM1SuKgI1YWFfBIHgIoCI?= =?us-ascii?Q?Oo3L7LX1pnCxK/aM6CaPzhSbxMVLs5GmrvGBqA3h8+zOUg5twCekUaEYBvnm?= =?us-ascii?Q?xpuMmKKQbP8dIFhwOTW7BzLeiga5izs+2MgSrzMfw241eE+KlyQ23NgXTSg3?= =?us-ascii?Q?j1a1NRMqAbb8n64fvFl3+5BYA3fPwdYxalXNAKX/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 436271df-5f7c-43a7-1728-08dbe1ba7388 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2023 06:58:32.1290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3G0QIfkzVgtRL6jQvBPcwuHUMv/7NUviDEX6k/5WJ7J1PXApAEefRfgus7B4H8TuXDLzDffsrJgJqYUWZr1R9tD9iq7c1Z4dXLwHc6mRwdY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5378 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > [You don't often get email from fengchengwen@huawei.com. Learn why this > is important at https://aka.ms/LearnAboutSenderIdentification ] >=20 > Add verify strdup return value logic. >=20 > Fixes: 3d21da66c06b ("net/nfp: create security session") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > --- > drivers/net/nfp/nfp_ipsec.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c in= dex > 452947380e..7ce9cca0b2 100644 > --- a/drivers/net/nfp/nfp_ipsec.c > +++ b/drivers/net/nfp/nfp_ipsec.c > @@ -524,6 +524,11 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg, > uint8_t *cfg_iv; >=20 > iv_str =3D strdup(iv_string); > + if (iv_str =3D=3D NULL) { > + PMD_DRV_LOG(ERR, "Failed to strdup iv_string"); > + return; > + } > + > cfg_iv =3D (uint8_t *)cfg->aesgcm_fields.iv; >=20 > for (i =3D 0; i < iv_len; i++) { > -- > 2.17.1 Looks good tome. Thanks. Acked-by: Chaoyong He