From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D487145E34; Thu, 5 Dec 2024 02:14:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 950A34111C; Thu, 5 Dec 2024 02:14:17 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2105.outbound.protection.outlook.com [40.107.93.105]) by mails.dpdk.org (Postfix) with ESMTP id CF01940691 for ; Thu, 5 Dec 2024 02:14:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tIJSOnjZtBPpAh333TQquLsjMVjqjInaHBZ0wqvG0QkqsKcL97lBZp0pfYRgcwb6ErJ7Xre8c8wPKmR/9LULhEUSBEczJc4wmqK69zp3Yg7F/BejCCeFteAxLGkZlsETLu5BNcB1P7cIjxFq/WcoPw6ph/NeK8DCdt7ZJdh5YxSi/4jU1m8pAhto37C5IUN+fjDYQLfKBGUwpxFixK9qyZND+M6Z2qtuyFgzxoG5wr0HYgr9Mm8grEBxiDcjp0H26uXP6/ZOntL6hSF41iyp+P/TCwzuBmJlJfKAu7wL5AWJtd6uvOeT+QDqVVuFL0T0Mi1wxIMVSHlsxeQK2Z/CtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SzPv4ap5ZaUcLP2cPAd+mB22qm/oWgF/jOIzHaGP8R0=; b=P2xlSjdaj7eMIGkrWvf0EuLGxKOlywfh4thkgPzGsuevV/6wINmb8aBlkshxqRDJtxID8Z2sWE2oXCzRQuR7SfUcnIUbEsv/PZw4W760lAbuWLwYtNGnvayD/oaklR3a7zYfZI4BT3I3dHtfsyRj6LxJwLK225e7UTplbR7SuxDh7QmgN7p9LqcskM4yeV11JiPKw0nsS+pawrwPJUonOSKlrVYU2sVp2vOjFQISR+sNa8yJgngxOkKkRh0zgunz9fOb1d/62eJe2VJunceb1FzN4Ys8zG1/dDeMPrBFvVwDZc8jrwAB4J1XogXD+6Y+H/zXrNTrn8wgdLcr4M3DFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzPv4ap5ZaUcLP2cPAd+mB22qm/oWgF/jOIzHaGP8R0=; b=C8odjPeRrO/kpAohXYTpsIjm/pNfokJ3ZFRPeGn4Yzewu9BlDWAhOqNo2+3+uz4Pyu9TmZw0KXWsqEh55LQSX6EAjXO2LqTIxPwoFNTCij01ejyBT7B7S89z4XRw/PugJ0xDwnIj5NBkdsty+4rxxWtO/W/VAJRYFJG5K++mNxo= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MW5PR13MB5877.namprd13.prod.outlook.com (2603:10b6:303:1c7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Thu, 5 Dec 2024 01:14:12 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8207.017; Thu, 5 Dec 2024 01:14:12 +0000 From: Chaoyong He To: Andre Muezerie , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra CC: "dev@dpdk.org" Subject: RE: [PATCH 2/6] drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__ Thread-Topic: [PATCH 2/6] drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__ Thread-Index: AQHbRoiapgGWVuSvdkyXt24iEH/G7LLW2JwA Date: Thu, 5 Dec 2024 01:14:12 +0000 Message-ID: References: <1733342995-3722-1-git-send-email-andremue@linux.microsoft.com> <1733342995-3722-3-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1733342995-3722-3-git-send-email-andremue@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|MW5PR13MB5877:EE_ x-ms-office365-filtering-correlation-id: fa9ad57a-e0b6-4a58-3f68-08dd14ca2114 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?ZBYRjvGVcoEVu30coh67RpTamNlzrvvKKJAbUWFTP2YC/T8EqPSl1UJaBW1/?= =?us-ascii?Q?V+RzIydOwoHrMAb3K/u5UV4imJ5jyvsjyLY/rzxSkTxC3PGkCMyp+AKGWtOl?= =?us-ascii?Q?NMe7pkzZBfapE5n4wa0tGjpnuQ9WM6Q3IUg666oX1EsxKrPYl/xM4fZk8tuF?= =?us-ascii?Q?57Xnvgk5dxEmGkCvtC73We6FBKxNkGkE3bknS7THDlzv4zNRyT+dJNSF1K3g?= =?us-ascii?Q?YTToe1rMucklxQ7fB1MlyKJXvcKJHZ9Wxk+MgCEFP6wCJWtQU0tK8e5gHLRX?= =?us-ascii?Q?ZAl9ue2p7ZlvyUs3BtugMbyY3EjX5518uVVaEs7zXT2ZUJ+HEnoVoN2OFbul?= =?us-ascii?Q?pi3u1R4u4tugT5wMlqtUu00LQpIFTE6bHbOTJbzneEN57KyVQVrQIinFSW2b?= =?us-ascii?Q?kiEVwSx61Z/X01lwZU43GC3oP+V6Z48DCd6BzAXmctYMiM/kxv9J0EsIQPEv?= =?us-ascii?Q?VX7JDwIxCVU00uxi0vwpt1qcxAPZj+aQ5K47uHpzVhFuwLz2W0uYV5a4g1l2?= =?us-ascii?Q?ab020WbwPnpo1bYSg9vpFPnSJneX+DQQYN0XczSOerH5DY7DBBy2XsH9NZhC?= =?us-ascii?Q?5EY2Q45PHnCFCMnubuJF9em1GOhzurFVN4CB9d9bs+cPrns3EicxlykQlFgM?= =?us-ascii?Q?cxUg6XdkP5ibgZnX9fP2ZO2Ps9Ott3WXmry2DKCjpqakN26dBHlnZq61nnix?= =?us-ascii?Q?clTCUKpd8vx1VPLHUmcJc2nqL49tsEohIVffYJQYxZCYRQkOnGtrYdE8rRVB?= =?us-ascii?Q?JRdLcjG5JNhm55F67zWVpPeVYZs2o7lpQuBYkQZn3BDrqpfe5GYZwcbCMJve?= =?us-ascii?Q?Gpgdp4sx7hYW/104bSUThEHrbFi+xk5FPdj/3PcdkZj45IK63VJSGNLJS3fA?= =?us-ascii?Q?zxcnVWBk4cc361OXV1nuZCw8Mh5FuvKKuxlL8At6MBJr4qF3ixU9Q5sSc73R?= =?us-ascii?Q?Cr9zCcxd1sHdVQFlOPmwecCp6bC6erWfJy0x6Se2Gqn+hL2jcOGAoWcKXarH?= =?us-ascii?Q?uzIPVhBzoNegBqgVSDJTu0sPwabyNJdPqtO+oHQbuB37YN8mRIAtZV7mUG5C?= =?us-ascii?Q?TGPxw2lT75ynFqXcOPpJdEj/lSBrdyqITmvuOM+X8+QLMugqNkuMD3FU76xM?= =?us-ascii?Q?Tts2AkItsKgb4J7kqrpmjlNAz0Rhurj2TwFBvRnnxgRLto4uxL54YZZ1bV2m?= =?us-ascii?Q?Bo8MMvE2XXyu29d//XnDLdjPLhTOm0gay90lH2f+PL9AEASy5eC+oh7N+prH?= =?us-ascii?Q?4PGEy0jDXGV2m5A5w2KFWpSsBGXBowDGiZyRrTLDWZZvkYG2+XITG1k0zkUh?= =?us-ascii?Q?bVMazDt0ERDF/jrYft5n0Vr6dc67TG9rwQvRrHjmHw55FaqVKkzi1/zZPMm0?= =?us-ascii?Q?UIF6VJLLpgA1zyLYvuuqbdzTA2HFfdnU/cKXcwLQkxRGWA1AOw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6i/JoCvZkiANIW5GIjs4i1aBQuxXYEfdBJdt2kG8twKixGH6VWWNchtYDl7U?= =?us-ascii?Q?2YRYPhY/CCEu36CPAekfa+3cVDiqtTnEl8HkZF7wocnlhIh3PW5ahkvYXJFc?= =?us-ascii?Q?lsYQdRgye3yGQqUeiwTjfr3MgytZeOBVh1VRuK4B328/iJMQ6JrxsZMBRxLz?= =?us-ascii?Q?L9DJD6kfboLcYojKwBIM0B0iFWVVCfdY6Nhftr2B6YqaPMYnX27d0Dbb/6g8?= =?us-ascii?Q?JFbkuzWlhm3yOKMDfxc4TtGr7esP8EVJp5D+MOYECvDdtgAemenZNN0RSHQX?= =?us-ascii?Q?ICC8uY/TYo+oMD6OXZJYJtA3QoZcoKkC1zilDUqR04sobIFveGpy2hGXYR4X?= =?us-ascii?Q?UQpUUllao+EX8dECHTL1h808Ij/DHuNssSl1TAhLqEem6O7wjQDQY1EPyFH/?= =?us-ascii?Q?sluqJoM5MvKALAXRaaje/kfwXr0+3JANtQn0besNRB42r+Wjjx5pOwshxLc0?= =?us-ascii?Q?gyAuiEOW9tHLUSJ+IOj8yLORVprhVuG+iR+XjSkas8FUX7SexKl9iWKa3Tfo?= =?us-ascii?Q?dFngj9QDn7YCHTa6E11tEYZ4fa50x+aY66hzeq49zAv+W3YnwdtFmReCRyro?= =?us-ascii?Q?t8A6wJWUA+g558wlCxv7tFuCSf2gmn74pksUIsw1hxrlOK7ljXtaTelk4EM1?= =?us-ascii?Q?Fyfhf3eWUIsvFCrEek7Im3F+p6r7oct9rqI/P4xYsGoBCth0ztI7j7EgVGZY?= =?us-ascii?Q?QJ10rUkdrwuhJH2FOmLR2/q+UjE+KlpLZ3x93Kk8GoPz/VOBwk8VltPe36a0?= =?us-ascii?Q?Tcl+uswa4/C/Pmoc6Sz4EOd9Do88St3DCuyfaNPpm/XcXY5v/ITgRJjEta8G?= =?us-ascii?Q?scBtj5+ycecKnlzy6svbutm5HiNlss4RF7X13MAQVhL1SPWDKJ4MyiFP4EWM?= =?us-ascii?Q?oQDu7+uzndzMLOonOk3vQASkS8mN5Q7yG+XCXNGWSj7q+IxrMCB8IIqcdgxf?= =?us-ascii?Q?Ge7XZ+jH+MWyW84V7zX5G5FVK02SXWW6khoVHRtpKfZ7eQgg+aQ5ptS6QrMt?= =?us-ascii?Q?LlxHBBJDOrZLJ9+FTRURkf5go1YMnlgNgh/3LnRVvemTxsDlHxkW5WdaNmjM?= =?us-ascii?Q?mna3ZMKoqod5fIheBO52EjrzVGeAQaXI4QQzYKXfluiNNRFJDXSKO+/8DGcz?= =?us-ascii?Q?+Kq2tgxA4OEUsmGMbcJCRNSTsXArdWi7znjN/GThCR57mXmcMiMyScgV4SvE?= =?us-ascii?Q?QTPfd6ear/RDUgvMnd0wkDssffof1wx1SbwaVcDONZAe42lObKwi9SwSaZtd?= =?us-ascii?Q?cwb2oYaViJBRUMUQ1nKGYkYCW8K0UAcDIByYPVB3GYZ9G79EN5O9W1F821Ue?= =?us-ascii?Q?OZ3vjcxYOc20XbpUjiq0mIfSAciq1EcG268oCwL5KPJ+zci8PeTUSVV62dqE?= =?us-ascii?Q?Zf8qfqDa8Zyp54cS0zVv9lFG+sxSPc2b2SYFUM7G7OTF+zRMatbH+4ei3XIs?= =?us-ascii?Q?2Q6oEbZWMCiaQGFfH12zn76dvnnJok0ado1rwMdSGcstLFcc3S+sb19kd0yF?= =?us-ascii?Q?EcHWc6lBdSADRISrXyaVc8f9x+dFiIUbENfmS5MUNvfZvdKnbWv2fY7eSOu7?= =?us-ascii?Q?irx4NowxLVoAEKu5NvrU6/4/s5lRR6oQUcwKPauH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa9ad57a-e0b6-4a58-3f68-08dd14ca2114 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2024 01:14:12.6835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mKgvcSXkGz95hlLsgbkVwkjQrxjMx0/Bleyf58ATcObOHIoxS2jvb/4O2fixeC4R3iV1FcEUYDYbVPoz04+VPXlEuDiEO68LojKG5Q66EkM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5877 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > Therefore the errors below are seen with MSVC: >=20 > ../lib/mldev/mldev_utils_scalar.c(465): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar.c(478): error C2051: > case expression not constant >=20 > ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051: > case expression not constant >=20 > Turns out that the places where __SIZEOF_LONG__ is currently being used c= an > equaly well use sizeof(long) instead. >=20 > Signed-off-by: Andre Muezerie > --- > drivers/common/cnxk/roc_bits.h | 4 ++-- > drivers/common/nfp/nfp_platform.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/common/cnxk/roc_bits.h > b/drivers/common/cnxk/roc_bits.h index 11216d9d63..aa4944ae7f 100644 > --- a/drivers/common/cnxk/roc_bits.h > +++ b/drivers/common/cnxk/roc_bits.h > @@ -14,10 +14,10 @@ > #endif >=20 > #ifndef BITS_PER_LONG > -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) > +#define BITS_PER_LONG (sizeof(long) * 8) > #endif > #ifndef BITS_PER_LONG_LONG > -#define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8) > +#define BITS_PER_LONG_LONG (sizeof(long long) * 8) > #endif >=20 > #ifndef GENMASK > diff --git a/drivers/common/nfp/nfp_platform.h > b/drivers/common/nfp/nfp_platform.h > index 0b02fcf1e8..27792aca97 100644 > --- a/drivers/common/nfp/nfp_platform.h > +++ b/drivers/common/nfp/nfp_platform.h > @@ -14,8 +14,8 @@ >=20 > #define DMA_BIT_MASK(n) ((1ULL << (n)) - 1) >=20 > -#define BITS_PER_LONG (__SIZEOF_LONG__ * 8) > -#define BITS_PER_LONG_LONG (__SIZEOF_LONG_LONG__ * 8) > +#define BITS_PER_LONG (sizeof(long) * 8) > +#define BITS_PER_LONG_LONG (sizeof(long long) * 8) This looks good to me, thanks. Acked-by: Chaoyong He >=20 > #define GENMASK(h, l) \ > ((~0UL << (l)) & (~0UL >> (BITS_PER_LONG - (h) - 1))) > -- > 2.47.0.vfs.0.3